Re: [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ()

From: Paul Walmsley <pjw@kernel.org>
To: Charlie Jenkins <thecharlesjenkins@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>, Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	 Sergey Matyukevich <geomatsi@gmail.com>,
	Andy Chiu <andybnac@gmail.com>,
	 Deepak Gupta <debug@rivosinc.com>,
	linux-kselftest@vger.kernel.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ()
Date: Fri, 20 Mar 2026 18:24:17 -0600 (MDT)	[thread overview]
Message-ID: <d79b23d2-f8e8-b92e-cad4-5cbdf7690f12@kernel.org> (raw)
In-Reply-To: <20260309-fix_selftests-v2-2-9d5a553a531e@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Mon, 9 Mar 2026, Charlie Jenkins via B4 Relay wrote:

> From: Charlie Jenkins <thecharlesjenkins@gmail.com>
> 
> EXPECT_EQ() expands to multiple lines, breaking up one-line if
> statements. This issue was not present in the patch on the mailing list
> but was instead introduced by the maintainer when attempting to fix up
> checkpatch warnings. Add braces around EXPECT_EQ() to avoid the error
> even though checkpatch suggests them to be removed:
> 
> validate_v_ptrace.c:626:17: error: ‘else’ without a previous ‘if’

That's annoying.  Can't the macro body be wrapped in do { ... } while (0); 
instead, rather than adding these permanent checkpatch warnings?

- Paul