All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Walmsley <pjw@kernel.org>
To: Charlie Jenkins <thecharlesjenkins@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>, Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	 Sergey Matyukevich <geomatsi@gmail.com>,
	Andy Chiu <andybnac@gmail.com>,
	 Deepak Gupta <debug@rivosinc.com>,
	linux-kselftest@vger.kernel.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] riscv: ptrace: Fix BIT() compilation issues
Date: Fri, 20 Mar 2026 18:53:37 -0600 (MDT)	[thread overview]
Message-ID: <d87c7b4c-5849-6254-8e85-805c752acb5b@kernel.org> (raw)
In-Reply-To: <20260309-fix_selftests-v2-3-9d5a553a531e@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

On Mon, 9 Mar 2026, Charlie Jenkins via B4 Relay wrote:

> From: Charlie Jenkins <thecharlesjenkins@gmail.com>
> 
> BIT() is being used in ptrace.h without a definition, resulting in
> compilation errors in tools/testing/selftests/riscv/cfi/cfitests.c:
> 
> cfitests.c:101:60: error: implicit declaration of function ‘BIT’ [-Wimplicit-function-declaration]
>   101 |                      if ((cfi_reg.cfi_status.cfi_state & CFI_ENABLE_MASK) != CFI_ENABLE_MASK)
> 
> Include linux/bits.h to resolve this issue.
> 
> Fixes: 2af7c9cf021c ("riscv/ptrace: expose riscv CFI status and state via ptrace and in core files")
> Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>

Thanks, queued for v7.0-rc.


- Paul

WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <pjw@kernel.org>
To: Charlie Jenkins <thecharlesjenkins@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>, Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	 Sergey Matyukevich <geomatsi@gmail.com>,
	Andy Chiu <andybnac@gmail.com>,
	 Deepak Gupta <debug@rivosinc.com>,
	linux-kselftest@vger.kernel.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] riscv: ptrace: Fix BIT() compilation issues
Date: Fri, 20 Mar 2026 18:53:37 -0600 (MDT)	[thread overview]
Message-ID: <d87c7b4c-5849-6254-8e85-805c752acb5b@kernel.org> (raw)
In-Reply-To: <20260309-fix_selftests-v2-3-9d5a553a531e@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

On Mon, 9 Mar 2026, Charlie Jenkins via B4 Relay wrote:

> From: Charlie Jenkins <thecharlesjenkins@gmail.com>
> 
> BIT() is being used in ptrace.h without a definition, resulting in
> compilation errors in tools/testing/selftests/riscv/cfi/cfitests.c:
> 
> cfitests.c:101:60: error: implicit declaration of function ‘BIT’ [-Wimplicit-function-declaration]
>   101 |                      if ((cfi_reg.cfi_status.cfi_state & CFI_ENABLE_MASK) != CFI_ENABLE_MASK)
> 
> Include linux/bits.h to resolve this issue.
> 
> Fixes: 2af7c9cf021c ("riscv/ptrace: expose riscv CFI status and state via ptrace and in core files")
> Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>

Thanks, queued for v7.0-rc.


- Paul

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2026-03-21  0:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  1:52 [PATCH v2 0/4] selftests: riscv: Fix compilation issues for v_ptrace and cfi Charlie Jenkins
2026-03-10  1:52 ` Charlie Jenkins via B4 Relay
2026-03-10  1:52 ` Charlie Jenkins via B4 Relay
2026-03-10  1:52 ` [PATCH v2 1/4] selftests: riscv: Add definition of BIT() macro Charlie Jenkins
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  8:18   ` Sergey Matyukevich
2026-03-10  8:18     ` Sergey Matyukevich
2026-03-21  0:48     ` Paul Walmsley
2026-03-21  0:48       ` Paul Walmsley
2026-03-21  0:53   ` Paul Walmsley
2026-03-21  0:53     ` Paul Walmsley
2026-03-10  1:52 ` [PATCH v2 2/4] selftests: riscv: Add braces around EXPECT_EQ() Charlie Jenkins
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  3:50   ` Joe Perches
2026-03-10  3:50     ` Joe Perches
2026-03-10  8:17   ` Sergey Matyukevich
2026-03-10  8:17     ` Sergey Matyukevich
2026-03-21  0:24   ` Paul Walmsley
2026-03-21  0:24     ` Paul Walmsley
2026-04-03 17:46     ` Paul Walmsley
2026-04-03 17:46       ` Paul Walmsley
2026-03-10  1:52 ` [PATCH v2 3/4] riscv: ptrace: Fix BIT() compilation issues Charlie Jenkins
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  2:58   ` Deepak Gupta
2026-03-10  2:58     ` Deepak Gupta
2026-03-21  0:53   ` Paul Walmsley [this message]
2026-03-21  0:53     ` Paul Walmsley
2026-03-10  1:52 ` [PATCH v2 4/4] selftests: riscv: Add license to cfi selftest Charlie Jenkins
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  1:52   ` Charlie Jenkins via B4 Relay
2026-03-10  2:58   ` Deepak Gupta
2026-03-10  2:58     ` Deepak Gupta
2026-03-21  0:54   ` Paul Walmsley
2026-03-21  0:54     ` Paul Walmsley
2026-03-21  5:20 ` [PATCH v2 0/4] selftests: riscv: Fix compilation issues for v_ptrace and cfi patchwork-bot+linux-riscv
2026-03-21  5:20   ` patchwork-bot+linux-riscv
2026-04-03 18:30 ` patchwork-bot+linux-riscv
2026-04-03 18:30   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d87c7b4c-5849-6254-8e85-805c752acb5b@kernel.org \
    --to=pjw@kernel.org \
    --cc=andybnac@gmail.com \
    --cc=debug@rivosinc.com \
    --cc=geomatsi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=shuah@kernel.org \
    --cc=thecharlesjenkins@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.