* [XEN PATCH] xen: add acmacros.h to exclude-list.json @ 2023-12-19 9:02 Nicola Vetrini 2023-12-19 10:37 ` Jan Beulich 0 siblings, 1 reply; 9+ messages in thread From: Nicola Vetrini @ 2023-12-19 9:02 UTC (permalink / raw) To: xen-devel Cc: consulting, Nicola Vetrini, Andrew Cooper, George Dunlap, Jan Beulich, Julien Grall, Stefano Stabellini, Wei Liu The file was inherited from Linux and ACPI CA, therefore it's not subject to MISRA compliance at the moment. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- docs/misra/exclude-list.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json index 48f671c548b6..36cca71fae2d 100644 --- a/docs/misra/exclude-list.json +++ b/docs/misra/exclude-list.json @@ -209,6 +209,10 @@ "rel_path": "include/acpi/acglobal.h", "comment": "Imported from Linux, ignore for now" }, + { + "rel_path": "include/acpi/acmacros.h", + "comment": "Imported from Linux, ignore for now" + }, { "rel_path": "include/xen/acpi.h", "comment": "Imported from Linux, ignore for now" -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-19 9:02 [XEN PATCH] xen: add acmacros.h to exclude-list.json Nicola Vetrini @ 2023-12-19 10:37 ` Jan Beulich 2023-12-19 10:51 ` Nicola Vetrini 0 siblings, 1 reply; 9+ messages in thread From: Jan Beulich @ 2023-12-19 10:37 UTC (permalink / raw) To: Nicola Vetrini Cc: consulting, Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu, xen-devel On 19.12.2023 10:02, Nicola Vetrini wrote: > --- a/docs/misra/exclude-list.json > +++ b/docs/misra/exclude-list.json > @@ -209,6 +209,10 @@ > "rel_path": "include/acpi/acglobal.h", > "comment": "Imported from Linux, ignore for now" > }, > + { > + "rel_path": "include/acpi/acmacros.h", > + "comment": "Imported from Linux, ignore for now" > + }, Together with what's already there (in context), wouldn't it better be the entire directory then which is excluded, or at least all include/acpi/ac*.h collectively (and perhaps also include/acpi/platform/ac*.h)? Jan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-19 10:37 ` Jan Beulich @ 2023-12-19 10:51 ` Nicola Vetrini 2023-12-19 11:05 ` Nicola Vetrini 0 siblings, 1 reply; 9+ messages in thread From: Nicola Vetrini @ 2023-12-19 10:51 UTC (permalink / raw) To: Jan Beulich Cc: consulting, Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu, xen-devel, Luca Fancellu On 2023-12-19 11:37, Jan Beulich wrote: > On 19.12.2023 10:02, Nicola Vetrini wrote: >> --- a/docs/misra/exclude-list.json >> +++ b/docs/misra/exclude-list.json >> @@ -209,6 +209,10 @@ >> "rel_path": "include/acpi/acglobal.h", >> "comment": "Imported from Linux, ignore for now" >> }, >> + { >> + "rel_path": "include/acpi/acmacros.h", >> + "comment": "Imported from Linux, ignore for now" >> + }, > > Together with what's already there (in context), wouldn't it better be > the entire directory then which is excluded, or at least all > include/acpi/ac*.h collectively (and perhaps also > include/acpi/platform/ac*.h)? > > Jan +Cc Luca Fancellu Sure. I wasn't certain which files are imported from ACPI CA and which aren't. I'm also not sure whether "include/acpi/ac*.h" would be properly recognized by other tooling that uses exclude-list.json (only cppcheck I think). I Cc-ed Luca Fancellu on this. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-19 10:51 ` Nicola Vetrini @ 2023-12-19 11:05 ` Nicola Vetrini 2023-12-19 11:09 ` Luca Fancellu 0 siblings, 1 reply; 9+ messages in thread From: Nicola Vetrini @ 2023-12-19 11:05 UTC (permalink / raw) To: Jan Beulich Cc: consulting, Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu, xen-devel, Luca Fancellu On 2023-12-19 11:51, Nicola Vetrini wrote: > On 2023-12-19 11:37, Jan Beulich wrote: >> On 19.12.2023 10:02, Nicola Vetrini wrote: >>> --- a/docs/misra/exclude-list.json >>> +++ b/docs/misra/exclude-list.json >>> @@ -209,6 +209,10 @@ >>> "rel_path": "include/acpi/acglobal.h", >>> "comment": "Imported from Linux, ignore for now" >>> }, >>> + { >>> + "rel_path": "include/acpi/acmacros.h", >>> + "comment": "Imported from Linux, ignore for now" >>> + }, >> >> Together with what's already there (in context), wouldn't it better be >> the entire directory then which is excluded, or at least all >> include/acpi/ac*.h collectively (and perhaps also >> include/acpi/platform/ac*.h)? >> >> Jan > > +Cc Luca Fancellu > > Sure. I wasn't certain which files are imported from ACPI CA and which > aren't. > I'm also not sure whether "include/acpi/ac*.h" would be properly > recognized by other tooling that uses exclude-list.json (only cppcheck > I think). I Cc-ed Luca Fancellu on this. It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-19 11:05 ` Nicola Vetrini @ 2023-12-19 11:09 ` Luca Fancellu 2023-12-20 0:17 ` Stefano Stabellini 0 siblings, 1 reply; 9+ messages in thread From: Luca Fancellu @ 2023-12-19 11:09 UTC (permalink / raw) To: Nicola Vetrini Cc: Jan Beulich, consulting@bugseng.com, Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu, xen-devel@lists.xenproject.org Hi! > On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: > > On 2023-12-19 11:51, Nicola Vetrini wrote: >> On 2023-12-19 11:37, Jan Beulich wrote: >>> On 19.12.2023 10:02, Nicola Vetrini wrote: >>>> --- a/docs/misra/exclude-list.json >>>> +++ b/docs/misra/exclude-list.json >>>> @@ -209,6 +209,10 @@ >>>> "rel_path": "include/acpi/acglobal.h", >>>> "comment": "Imported from Linux, ignore for now" >>>> }, >>>> + { >>>> + "rel_path": "include/acpi/acmacros.h", >>>> + "comment": "Imported from Linux, ignore for now" >>>> + }, >>> Together with what's already there (in context), wouldn't it better be >>> the entire directory then which is excluded, or at least all >>> include/acpi/ac*.h collectively (and perhaps also >>> include/acpi/platform/ac*.h)? >>> Jan >> +Cc Luca Fancellu >> Sure. I wasn't certain which files are imported from ACPI CA and which aren't. >> I'm also not sure whether "include/acpi/ac*.h" would be properly recognized by other tooling that uses exclude-list.json (only cppcheck I think). I Cc-ed Luca Fancellu on this. > > It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". Yes I think it’s fine, it just come to my mind now that this could have the risk that if another file is added with ‘ac' prefix, even if it could be subject to MISRA compliance, it will be excluded. If that risk is negligible for the maintainer of that part, then it’s fine. > > -- > Nicola Vetrini, BSc > Software Engineer, BUGSENG srl (https://bugseng.com) ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-19 11:09 ` Luca Fancellu @ 2023-12-20 0:17 ` Stefano Stabellini 2023-12-20 8:41 ` Jan Beulich 0 siblings, 1 reply; 9+ messages in thread From: Stefano Stabellini @ 2023-12-20 0:17 UTC (permalink / raw) To: Luca Fancellu Cc: Nicola Vetrini, Jan Beulich, consulting@bugseng.com, Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu, xen-devel@lists.xenproject.org [-- Attachment #1: Type: text/plain, Size: 1690 bytes --] On Tue, 19 Dec 2023, Luca Fancellu wrote: > Hi! > > > On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: > > > > On 2023-12-19 11:51, Nicola Vetrini wrote: > >> On 2023-12-19 11:37, Jan Beulich wrote: > >>> On 19.12.2023 10:02, Nicola Vetrini wrote: > >>>> --- a/docs/misra/exclude-list.json > >>>> +++ b/docs/misra/exclude-list.json > >>>> @@ -209,6 +209,10 @@ > >>>> "rel_path": "include/acpi/acglobal.h", > >>>> "comment": "Imported from Linux, ignore for now" > >>>> }, > >>>> + { > >>>> + "rel_path": "include/acpi/acmacros.h", > >>>> + "comment": "Imported from Linux, ignore for now" > >>>> + }, > >>> Together with what's already there (in context), wouldn't it better be > >>> the entire directory then which is excluded, or at least all > >>> include/acpi/ac*.h collectively (and perhaps also > >>> include/acpi/platform/ac*.h)? > >>> Jan > >> +Cc Luca Fancellu > >> Sure. I wasn't certain which files are imported from ACPI CA and which aren't. > >> I'm also not sure whether "include/acpi/ac*.h" would be properly recognized by other tooling that uses exclude-list.json (only cppcheck I think). I Cc-ed Luca Fancellu on this. > > > > It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". > > Yes I think it’s fine, it just come to my mind now that this could have the risk that if > another file is added with ‘ac' prefix, even if it could be subject to MISRA compliance, > it will be excluded. > > If that risk is negligible for the maintainer of that part, then it’s fine. I think it is OK either way, I'll let Jan pick his preference. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-20 0:17 ` Stefano Stabellini @ 2023-12-20 8:41 ` Jan Beulich 2023-12-20 8:50 ` Luca Fancellu 0 siblings, 1 reply; 9+ messages in thread From: Jan Beulich @ 2023-12-20 8:41 UTC (permalink / raw) To: Stefano Stabellini, Nicola Vetrini Cc: consulting@bugseng.com, Andrew Cooper, George Dunlap, Julien Grall, Wei Liu, xen-devel@lists.xenproject.org, Luca Fancellu On 20.12.2023 01:17, Stefano Stabellini wrote: > On Tue, 19 Dec 2023, Luca Fancellu wrote: >>> On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: >>> On 2023-12-19 11:51, Nicola Vetrini wrote: >>>> On 2023-12-19 11:37, Jan Beulich wrote: >>>>> On 19.12.2023 10:02, Nicola Vetrini wrote: >>>>>> --- a/docs/misra/exclude-list.json >>>>>> +++ b/docs/misra/exclude-list.json >>>>>> @@ -209,6 +209,10 @@ >>>>>> "rel_path": "include/acpi/acglobal.h", >>>>>> "comment": "Imported from Linux, ignore for now" >>>>>> }, >>>>>> + { >>>>>> + "rel_path": "include/acpi/acmacros.h", >>>>>> + "comment": "Imported from Linux, ignore for now" >>>>>> + }, >>>>> Together with what's already there (in context), wouldn't it better be >>>>> the entire directory then which is excluded, or at least all >>>>> include/acpi/ac*.h collectively (and perhaps also >>>>> include/acpi/platform/ac*.h)? >>>>> Jan >>>> +Cc Luca Fancellu >>>> Sure. I wasn't certain which files are imported from ACPI CA and which aren't. >>>> I'm also not sure whether "include/acpi/ac*.h" would be properly recognized by other tooling that uses exclude-list.json (only cppcheck I think). I Cc-ed Luca Fancellu on this. >>> >>> It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". >> >> Yes I think it’s fine, it just come to my mind now that this could have the risk that if >> another file is added with ‘ac' prefix, even if it could be subject to MISRA compliance, >> it will be excluded. >> >> If that risk is negligible for the maintainer of that part, then it’s fine. > > I think it is OK either way, I'll let Jan pick his preference. It hasn't become clear to me what the benefit would be of omitting the trailing .h. Jan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-20 8:41 ` Jan Beulich @ 2023-12-20 8:50 ` Luca Fancellu 2023-12-20 9:10 ` Nicola Vetrini 0 siblings, 1 reply; 9+ messages in thread From: Luca Fancellu @ 2023-12-20 8:50 UTC (permalink / raw) To: Nicola Vetrini Cc: Stefano Stabellini, consulting@bugseng.com, Andrew Cooper, George Dunlap, Julien Grall, Wei Liu, xen-devel@lists.xenproject.org, Jan Beulich > On 20 Dec 2023, at 08:41, Jan Beulich <jbeulich@suse.com> wrote: > > On 20.12.2023 01:17, Stefano Stabellini wrote: >> On Tue, 19 Dec 2023, Luca Fancellu wrote: >>>> On 19 Dec 2023, at 11:05, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: >>>> On 2023-12-19 11:51, Nicola Vetrini wrote: >>>>> On 2023-12-19 11:37, Jan Beulich wrote: >>>>>> On 19.12.2023 10:02, Nicola Vetrini wrote: >>>>>>> --- a/docs/misra/exclude-list.json >>>>>>> +++ b/docs/misra/exclude-list.json >>>>>>> @@ -209,6 +209,10 @@ >>>>>>> "rel_path": "include/acpi/acglobal.h", >>>>>>> "comment": "Imported from Linux, ignore for now" >>>>>>> }, >>>>>>> + { >>>>>>> + "rel_path": "include/acpi/acmacros.h", >>>>>>> + "comment": "Imported from Linux, ignore for now" >>>>>>> + }, >>>>>> Together with what's already there (in context), wouldn't it better be >>>>>> the entire directory then which is excluded, or at least all >>>>>> include/acpi/ac*.h collectively (and perhaps also >>>>>> include/acpi/platform/ac*.h)? >>>>>> Jan >>>>> +Cc Luca Fancellu >>>>> Sure. I wasn't certain which files are imported from ACPI CA and which aren't. >>>>> I'm also not sure whether "include/acpi/ac*.h" would be properly recognized by other tooling that uses exclude-list.json (only cppcheck I think). I Cc-ed Luca Fancellu on this. >>>> >>>> It occurred to me that it's surely ok to use "include/acpi/ac*" and "include/acpi/platform/ac*". >>> >>> Yes I think it’s fine, it just come to my mind now that this could have the risk that if >>> another file is added with ‘ac' prefix, even if it could be subject to MISRA compliance, >>> it will be excluded. >>> >>> If that risk is negligible for the maintainer of that part, then it’s fine. >> >> I think it is OK either way, I'll let Jan pick his preference. > > It hasn't become clear to me what the benefit would be of omitting the > trailing .h. Yes, with the extension is better, the same as we already do here: [...] { "rel_path": "common/un*.c”, "comment": "unlz4.c implementation by Yann Collet, the others un* are from Linux, ignore for now" }, [...] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [XEN PATCH] xen: add acmacros.h to exclude-list.json 2023-12-20 8:50 ` Luca Fancellu @ 2023-12-20 9:10 ` Nicola Vetrini 0 siblings, 0 replies; 9+ messages in thread From: Nicola Vetrini @ 2023-12-20 9:10 UTC (permalink / raw) To: Luca Fancellu Cc: Stefano Stabellini, consulting, Andrew Cooper, George Dunlap, Julien Grall, Wei Liu, xen-devel, Jan Beulich On 2023-12-20 09:50, Luca Fancellu wrote: >> On 20 Dec 2023, at 08:41, Jan Beulich <jbeulich@suse.com> wrote: >> >> On 20.12.2023 01:17, Stefano Stabellini wrote: >>> On Tue, 19 Dec 2023, Luca Fancellu wrote: >>>>> On 19 Dec 2023, at 11:05, Nicola Vetrini >>>>> <nicola.vetrini@bugseng.com> wrote: >>>>> On 2023-12-19 11:51, Nicola Vetrini wrote: >>>>>> On 2023-12-19 11:37, Jan Beulich wrote: >>>>>>> On 19.12.2023 10:02, Nicola Vetrini wrote: >>>>>>>> --- a/docs/misra/exclude-list.json >>>>>>>> +++ b/docs/misra/exclude-list.json >>>>>>>> @@ -209,6 +209,10 @@ >>>>>>>> "rel_path": "include/acpi/acglobal.h", >>>>>>>> "comment": "Imported from Linux, ignore for now" >>>>>>>> }, >>>>>>>> + { >>>>>>>> + "rel_path": "include/acpi/acmacros.h", >>>>>>>> + "comment": "Imported from Linux, ignore for now" >>>>>>>> + }, >>>>>>> Together with what's already there (in context), wouldn't it >>>>>>> better be >>>>>>> the entire directory then which is excluded, or at least all >>>>>>> include/acpi/ac*.h collectively (and perhaps also >>>>>>> include/acpi/platform/ac*.h)? >>>>>>> Jan >>>>>> +Cc Luca Fancellu >>>>>> Sure. I wasn't certain which files are imported from ACPI CA and >>>>>> which aren't. >>>>>> I'm also not sure whether "include/acpi/ac*.h" would be properly >>>>>> recognized by other tooling that uses exclude-list.json (only >>>>>> cppcheck I think). I Cc-ed Luca Fancellu on this. >>>>> >>>>> It occurred to me that it's surely ok to use "include/acpi/ac*" and >>>>> "include/acpi/platform/ac*". >>>> >>>> Yes I think it’s fine, it just come to my mind now that this could >>>> have the risk that if >>>> another file is added with ‘ac' prefix, even if it could be subject >>>> to MISRA compliance, >>>> it will be excluded. >>>> >>>> If that risk is negligible for the maintainer of that part, then >>>> it’s fine. >>> >>> I think it is OK either way, I'll let Jan pick his preference. >> >> It hasn't become clear to me what the benefit would be of omitting the >> trailing .h. > > Yes, with the extension is better, the same as we already do here: > > [...] > { > "rel_path": "common/un*.c”, > "comment": "unlz4.c implementation by Yann Collet, the others un* > are from Linux, ignore for now" > }, > [...] Ok, I'll send a v2 -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com) ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-12-20 9:10 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-12-19 9:02 [XEN PATCH] xen: add acmacros.h to exclude-list.json Nicola Vetrini 2023-12-19 10:37 ` Jan Beulich 2023-12-19 10:51 ` Nicola Vetrini 2023-12-19 11:05 ` Nicola Vetrini 2023-12-19 11:09 ` Luca Fancellu 2023-12-20 0:17 ` Stefano Stabellini 2023-12-20 8:41 ` Jan Beulich 2023-12-20 8:50 ` Luca Fancellu 2023-12-20 9:10 ` Nicola Vetrini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.