Re: [RFC PATCH 6/6] pcie/cxl_timeout: Add CXL.mem Timeout & Isolation interrupt support

[Ben Cheatham <benjamin.cheatham@amd.com>]

On 2/15/24 3:57 PM, Bjorn Helgaas wrote:
> On Thu, Feb 15, 2024 at 01:40:48PM -0600, Ben Cheatham wrote:
>> Add support for CXL.mem Timeout & Isolation interrupts. A CXL root port
>> under isolation will not complete writes and will return an exception
>> response (i.e. poison) on reads (CXL 3.0 12.3.2). Therefore, when a
>> CXL-enabled PCIe root port enters isolation, we assume that the memory
>> under the port is unreachable and will need to be unmapped.
> 
>> --- a/drivers/pci/pcie/portdrv.h
>> +++ b/drivers/pci/pcie/portdrv.h
>> @@ -10,6 +10,7 @@
>>  #define _PORTDRV_H_
>>  
>>  #include <linux/compiler.h>
>> +#include <linux/errno.h>
> 
> This doesn't look required by portdrv.h.  If it's only needed by
> something that *includes* portdrv.h, I think errno.h should be
> included by that .c file instead.
> 

I agree. It's a remnant of an older version of this that had a declaration
that needed it, I'll remove it.

Thanks again,
Ben