All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ben Cheatham <Benjamin.Cheatham@amd.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH 6/6] pcie/cxl_timeout: Add CXL.mem Timeout & Isolation interrupt support
Date: Sun, 18 Feb 2024 05:31:50 +0800	[thread overview]
Message-ID: <202402180558.S6rTa5mq-lkp@intel.com> (raw)
In-Reply-To: <20240215194048.141411-7-Benjamin.Cheatham@amd.com>

Hi Ben,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus cxl/next cxl/pending linus/master v6.8-rc4 next-20240216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ben-Cheatham/cxl-core-Add-CXL-Timeout-Isolation-capability-parsing/20240216-034328
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20240215194048.141411-7-Benjamin.Cheatham%40amd.com
patch subject: [RFC PATCH 6/6] pcie/cxl_timeout: Add CXL.mem Timeout & Isolation interrupt support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240218/202402180558.S6rTa5mq-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240218/202402180558.S6rTa5mq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402180558.S6rTa5mq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pci/pcie/cxl_timeout.c:231:13: warning: no previous prototype for 'cxl_timeout_thread' [-Wmissing-prototypes]
     231 | irqreturn_t cxl_timeout_thread(int irq, void *data)
         |             ^~~~~~~~~~~~~~~~~~


vim +/cxl_timeout_thread +231 drivers/pci/pcie/cxl_timeout.c

   230	
 > 231	irqreturn_t cxl_timeout_thread(int irq, void *data)
   232	{
   233		struct cxl_timeout_wq_data *wq_data;
   234		struct cxl_timeout *cxlt = data;
   235		struct pcie_device *pcie_dev = cxlt->dev;
   236		struct pcie_cxlt_data *pdata;
   237		struct cxl_dport *dport;
   238		u32 status;
   239	
   240		/*
   241		 * If the CXL core didn't register a cxl_dport with this PCIe device,
   242		 * then dport enumeration failed and there's nothing to do CXL-wise.
   243		 */
   244		pdata = get_service_data(pcie_dev);
   245		if (!pdata || !pdata->dport)
   246			return IRQ_HANDLED;
   247	
   248		dport = pdata->dport;
   249	
   250		status = readl(cxlt->regs + CXL_TIMEOUT_STATUS_OFFSET);
   251		if (!(status & CXL_TIMEOUT_STATUS_MEM_ISO
   252		      || status & CXL_TIMEOUT_STATUS_MEM_TIMEOUT))
   253			return IRQ_HANDLED;
   254	
   255		dport->isolated = true;
   256	
   257		wq_data = kzalloc(sizeof(struct cxl_timeout_wq_data), GFP_NOWAIT);
   258		if (!wq_data)
   259			return IRQ_NONE;
   260	
   261		wq_data->dport = dport;
   262	
   263		INIT_WORK(&wq_data->w, cxl_timeout_handler);
   264		queue_work(cxl_timeout_wq, &wq_data->w);
   265	
   266		return IRQ_HANDLED;
   267	}
   268	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-02-17 21:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 19:40 [RFC PATCH 0/6] Implement initial CXL Timeout & Isolation support Ben Cheatham
2024-02-15 19:40 ` [RFC PATCH 1/6] cxl/core: Add CXL Timeout & Isolation capability parsing Ben Cheatham
2024-02-15 19:40 ` [RFC PATCH 2/6] pcie/cxl_timeout: Add CXL Timeout & Isolation service driver Ben Cheatham
2024-02-15 21:13   ` Bjorn Helgaas
2024-02-15 22:21     ` Ben Cheatham
2024-02-15 22:26       ` Bjorn Helgaas
2024-02-15 19:40 ` [RFC PATCH 3/6] pcie/cxl_timeout: Add CXL.mem timeout range programming Ben Cheatham
2024-02-15 21:35   ` Bjorn Helgaas
2024-02-15 22:21     ` Ben Cheatham
2024-02-15 22:29       ` Bjorn Helgaas
2024-02-15 22:30         ` Ben Cheatham
2024-02-15 19:40 ` [RFC PATCH 4/6] pcie/cxl_timeout: Add CXL.mem error isolation support Ben Cheatham
2024-02-15 21:49   ` Bjorn Helgaas
2024-02-15 22:21     ` Ben Cheatham
2024-02-15 19:40 ` [RFC PATCH 5/6] pcie/portdrv: Add CXL MSI/-X allocation Ben Cheatham
2024-02-15 21:51   ` Bjorn Helgaas
2024-02-15 22:22     ` Ben Cheatham
2024-02-15 19:40 ` [RFC PATCH 6/6] pcie/cxl_timeout: Add CXL.mem Timeout & Isolation interrupt support Ben Cheatham
2024-02-15 21:57   ` Bjorn Helgaas
2024-02-15 22:22     ` Ben Cheatham
2024-02-17 21:31   ` kernel test robot [this message]
2024-02-17 22:44   ` kernel test robot
2024-02-17 22:55   ` kernel test robot
2024-02-15 23:43 ` [RFC PATCH 0/6] Implement initial CXL Timeout & Isolation support Dan Williams
2024-03-25 15:15   ` Ben Cheatham
2024-03-25 15:54     ` Dan Williams
2024-04-01 19:41       ` Ben Cheatham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402180558.S6rTa5mq-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Benjamin.Cheatham@amd.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.