* [RFC] update opkg* SRCREV to 201 @ 2009-02-25 20:46 Koen Kooi 2009-02-26 14:55 ` Koen Kooi 2009-02-27 19:31 ` Koen Kooi 0 siblings, 2 replies; 12+ messages in thread From: Koen Kooi @ 2009-02-25 20:46 UTC (permalink / raw) To: openembedded-devel Hi, I was getting seriously annoyed with the useless error codes opkg was giving me and Tick pointed me to: http://code.google.com/p/opkg/issues/detail?id=6&can=1 We're at 197 now in OE (with r201 applied as patch). I'd like to get r199 and r200 in as well, and since I'm lazy I though we'd get r198 in as well, which means instead of adding a few patches I can just bump up SRCREV to 201. What do you think? regards, Koen ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-25 20:46 [RFC] update opkg* SRCREV to 201 Koen Kooi @ 2009-02-26 14:55 ` Koen Kooi 2009-02-26 15:40 ` Tom Rini ` (2 more replies) 2009-02-27 19:31 ` Koen Kooi 1 sibling, 3 replies; 12+ messages in thread From: Koen Kooi @ 2009-02-26 14:55 UTC (permalink / raw) To: openembedded-devel On 25-02-09 21:46, Koen Kooi wrote: > Hi, > > I was getting seriously annoyed with the useless error codes opkg was > giving me and Tick pointed me to: > > http://code.google.com/p/opkg/issues/detail?id=6&can=1 > > We're at 197 now in OE (with r201 applied as patch). I'd like to get > r199 and r200 in as well, and since I'm lazy I though we'd get r198 in > as well, which means instead of adding a few patches I can just bump up > SRCREV to 201. > > What do you think? Noone is thinking anything? regards, Koen ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 14:55 ` Koen Kooi @ 2009-02-26 15:40 ` Tom Rini 2009-02-27 7:20 ` Koen Kooi 2009-02-26 15:46 ` Philip Balister 2009-02-26 16:13 ` Graeme Gregory 2 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2009-02-26 15:40 UTC (permalink / raw) To: openembedded-devel On Thu, Feb 26, 2009 at 03:55:32PM +0100, Koen Kooi wrote: > On 25-02-09 21:46, Koen Kooi wrote: >> Hi, >> >> I was getting seriously annoyed with the useless error codes opkg was >> giving me and Tick pointed me to: >> >> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >> >> We're at 197 now in OE (with r201 applied as patch). I'd like to get >> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >> as well, which means instead of adding a few patches I can just bump up >> SRCREV to 201. >> >> What do you think? > > Noone is thinking anything? <sarcasm> not since I switched to debs </sarcasm> -- Tom Rini ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 15:40 ` Tom Rini @ 2009-02-27 7:20 ` Koen Kooi 2009-02-27 19:56 ` Tom Rini 0 siblings, 1 reply; 12+ messages in thread From: Koen Kooi @ 2009-02-27 7:20 UTC (permalink / raw) To: openembedded-devel On 26-02-09 16:40, Tom Rini wrote: > On Thu, Feb 26, 2009 at 03:55:32PM +0100, Koen Kooi wrote: >> On 25-02-09 21:46, Koen Kooi wrote: >>> Hi, >>> >>> I was getting seriously annoyed with the useless error codes opkg was >>> giving me and Tick pointed me to: >>> >>> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >>> >>> We're at 197 now in OE (with r201 applied as patch). I'd like to get >>> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >>> as well, which means instead of adding a few patches I can just bump up >>> SRCREV to 201. >>> >>> What do you think? >> Noone is thinking anything? > > <sarcasm> not since I switched to debs</sarcasm> You still going to get bitten by opkg bugs when using packaged-staging ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-27 7:20 ` Koen Kooi @ 2009-02-27 19:56 ` Tom Rini 0 siblings, 0 replies; 12+ messages in thread From: Tom Rini @ 2009-02-27 19:56 UTC (permalink / raw) To: openembedded-devel On Fri, Feb 27, 2009 at 08:20:51AM +0100, Koen Kooi wrote: > On 26-02-09 16:40, Tom Rini wrote: >> On Thu, Feb 26, 2009 at 03:55:32PM +0100, Koen Kooi wrote: >>> On 25-02-09 21:46, Koen Kooi wrote: >>>> Hi, >>>> >>>> I was getting seriously annoyed with the useless error codes opkg was >>>> giving me and Tick pointed me to: >>>> >>>> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >>>> >>>> We're at 197 now in OE (with r201 applied as patch). I'd like to get >>>> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >>>> as well, which means instead of adding a few patches I can just bump up >>>> SRCREV to 201. >>>> >>>> What do you think? >>> Noone is thinking anything? >> >> <sarcasm> not since I switched to debs</sarcasm> > > You still going to get bitten by opkg bugs when using packaged-staging Something I wanna find the time to fix. -- Tom Rini ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 14:55 ` Koen Kooi 2009-02-26 15:40 ` Tom Rini @ 2009-02-26 15:46 ` Philip Balister 2009-02-26 19:09 ` Mike (mwester) 2009-02-26 16:13 ` Graeme Gregory 2 siblings, 1 reply; 12+ messages in thread From: Philip Balister @ 2009-02-26 15:46 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 811 bytes --] Koen Kooi wrote: > On 25-02-09 21:46, Koen Kooi wrote: >> Hi, >> >> I was getting seriously annoyed with the useless error codes opkg was >> giving me and Tick pointed me to: >> >> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >> >> We're at 197 now in OE (with r201 applied as patch). I'd like to get >> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >> as well, which means instead of adding a few patches I can just bump up >> SRCREV to 201. >> >> What do you think? > > Noone is thinking anything? Well, it looks ok to me, but I am not a follower of opkg. Hearing no positive comments, does anyone object to pushing this, knowing that if Koen is wrong about this working, it messes up our builds? Philip [*] Yes, that is an awful sentence. [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/x-pkcs7-signature, Size: 3303 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 15:46 ` Philip Balister @ 2009-02-26 19:09 ` Mike (mwester) 0 siblings, 0 replies; 12+ messages in thread From: Mike (mwester) @ 2009-02-26 19:09 UTC (permalink / raw) To: openembedded-devel Philip Balister wrote: > Koen Kooi wrote: >> On 25-02-09 21:46, Koen Kooi wrote: >>> Hi, >>> >>> I was getting seriously annoyed with the useless error codes opkg was >>> giving me and Tick pointed me to: >>> >>> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >>> >>> We're at 197 now in OE (with r201 applied as patch). I'd like to get >>> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >>> as well, which means instead of adding a few patches I can just bump up >>> SRCREV to 201. >>> >>> What do you think? >> >> Noone is thinking anything? > > Well, it looks ok to me, but I am not a follower of opkg. > > Hearing no positive comments, does anyone object to pushing this, > knowing that if Koen is wrong about this working, it messes up our builds? [I have failed -- I had intended to remain silent on the topic of opkg ;-) ] I use PREFERRED_VERSION, for a reason -- opkg has numerous issues, few of which seem to be well-understood much less being worked on, and it seems that small-memory devices trigger these issues more so than the larger more common systems. I will be back-porting these patches for the opkg-nogpg-nocurl recipe, regardless. If folks would rather not have the ever-growing set of opkg-nogpg-nocurl patches clutter up the opkg recipe directory, feel free to instruct me to move that all to a different directory. -Mike (mwester) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 14:55 ` Koen Kooi 2009-02-26 15:40 ` Tom Rini 2009-02-26 15:46 ` Philip Balister @ 2009-02-26 16:13 ` Graeme Gregory 2009-02-26 18:31 ` Tick 2 siblings, 1 reply; 12+ messages in thread From: Graeme Gregory @ 2009-02-26 16:13 UTC (permalink / raw) To: openembedded-devel Koen Kooi wrote: > On 25-02-09 21:46, Koen Kooi wrote: >> Hi, >> >> I was getting seriously annoyed with the useless error codes opkg was >> giving me and Tick pointed me to: >> >> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >> >> We're at 197 now in OE (with r201 applied as patch). I'd like to get >> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >> as well, which means instead of adding a few patches I can just bump up >> SRCREV to 201. >> >> What do you think? > > Noone is thinking anything? > Sorry been AFK, my opinion of these things is always no-one will test until stuff is committed anyway. So you might as well go ahead! Without the bug reports tick won't be able to improve opkg. Graeme (XorA) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 16:13 ` Graeme Gregory @ 2009-02-26 18:31 ` Tick 2009-02-26 19:41 ` Michael 'Mickey' Lauer 2009-02-26 20:25 ` Mike (mwester) 0 siblings, 2 replies; 12+ messages in thread From: Tick @ 2009-02-26 18:31 UTC (permalink / raw) To: openembedded-devel, Opkg devel List Hi, Koen and Graeme Thanks. To my understanding, the fix from R197 to R201 are some easy defect fixing. Fixing some typos, memory leak, and giving initial value some variable. There were no big change in these versions. Therefore I didn't bump up versions here. There are still some issues in my mind and I am still finding large chunk of time to deal with them. 1. the algorithm calculate the dependency is not very efficient. (Much faster than R180 now, but I know it can be faster) Because of there were some duplicated code and ill structured code from ipkg, I need to refactorying them first before changing the algorithm. 2. memory leak problem, ipkg were designed for running once and exit, and therefore there were many place are not took carefully. Thomas and I already fixed a lot, but not all of them. Most of the largest memory leaks were fixed, however there were still some small leaks need to be find out. Especially libopkg is used as library, this should be take care well. (If anyone find a leak, please report or help. thanks) 3. memory hungry issue, opkg will eat a large amount of memory if you have many packages metadata. This may cause problem, however there is dilemma. Storing metadata will make opkg faster, but may cause very limited device run out of memory. Saving memory will cause cpu busying malloc and free all the time, and it will be very slow. Though the algorithm now seems to be okay, for device having so many packages should be powerful enough. XD I am considering adding a flag decide which policy (fast or save memory) to use while building opkg. 4. buffer over issue, some of the code did not check the boundary well. Actually R197 is fixing an buffer overflow issue, in which not be found for a long long time until it cause problem (on x86_64 arch only). >_< Many code needs to be reviewed/tested again and again to make sure the quality is good enough, and it's need your reports, help and patches. If I break anything, I am sorry. And please mail to opkg-devel@googlegroups.com poking me, creating a ticket with backtrace and some analysis to http://code.google.com/p/opkg/issues/list is good, sending a patch is even welcome. When I realize if it cause serious problem to you, I will try to fix it asap. I will be glad if every opkg user does not aware it's existence, except the developers. Thank a lot. Cheers, Tick 2009/2/27 Graeme Gregory <dp@xora.org.uk>: > Koen Kooi wrote: >> On 25-02-09 21:46, Koen Kooi wrote: >>> Hi, >>> >>> I was getting seriously annoyed with the useless error codes opkg was >>> giving me and Tick pointed me to: >>> >>> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >>> >>> We're at 197 now in OE (with r201 applied as patch). I'd like to get >>> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >>> as well, which means instead of adding a few patches I can just bump up >>> SRCREV to 201. >>> >>> What do you think? >> >> Noone is thinking anything? >> > Sorry been AFK, my opinion of these things is always no-one will test > until stuff is committed anyway. So you might as well go ahead! Without > the bug reports tick won't be able to improve opkg. > > Graeme (XorA) > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 18:31 ` Tick @ 2009-02-26 19:41 ` Michael 'Mickey' Lauer 2009-02-26 20:25 ` Mike (mwester) 1 sibling, 0 replies; 12+ messages in thread From: Michael 'Mickey' Lauer @ 2009-02-26 19:41 UTC (permalink / raw) To: openembedded-devel; +Cc: Opkg devel List Tick being available and standing by helping us to bring opkg in shape is all I need to know. Let's co-work with him and bump it. -- :M: ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-26 18:31 ` Tick 2009-02-26 19:41 ` Michael 'Mickey' Lauer @ 2009-02-26 20:25 ` Mike (mwester) 1 sibling, 0 replies; 12+ messages in thread From: Mike (mwester) @ 2009-02-26 20:25 UTC (permalink / raw) To: openembedded-devel I'm glad to hear that there's work on some of these issues, as outlined below! -Mike Tick wrote: > Hi, > Koen and Graeme Thanks. > To my understanding, the fix from R197 to R201 are some easy defect fixing. > Fixing some typos, memory leak, and giving initial value some variable. > There were no big change in these versions. > Therefore I didn't bump up versions here. > There are still some issues in my mind and I am still finding large > chunk of time to deal with them. > 1. the algorithm calculate the dependency is not very efficient. > (Much faster than R180 now, but I know it can be faster) Because of > there were some duplicated code and ill structured code from ipkg, I > need to refactorying them first before changing the algorithm. > 2. memory leak problem, ipkg were designed for running once and > exit, and therefore there were many place are not took carefully. > Thomas and I already fixed a lot, but not all of them. Most of the > largest memory leaks were fixed, however there were still some small > leaks need to be find out. Especially libopkg is used as library, this > should be take care well. (If anyone find a leak, please report or > help. thanks) > 3. memory hungry issue, opkg will eat a large amount of memory if > you have many packages metadata. This may cause problem, however there > is dilemma. Storing metadata will make opkg faster, but may cause very > limited device run out of memory. Saving memory will cause cpu busying > malloc and free all the time, and it will be very slow. Though the > algorithm now seems to be okay, for device having so many packages > should be powerful enough. XD I am considering adding a flag decide > which policy (fast or save memory) to use while building opkg. > 4. buffer over issue, some of the code did not check the boundary > well. Actually R197 is fixing an buffer overflow issue, in which not > be found for a long long time until it cause problem (on x86_64 arch > only). >_< > Many code needs to be reviewed/tested again and again to make sure the > quality is good enough, and it's need your reports, help and patches. > If I break anything, I am sorry. And please mail to > opkg-devel@googlegroups.com poking me, creating a ticket with > backtrace and some analysis to > http://code.google.com/p/opkg/issues/list is good, sending a patch is > even welcome. When I realize if it cause serious problem to you, I > will try to fix it asap. I will be glad if every opkg user does not > aware it's existence, except the developers. > Thank a lot. > > Cheers, > Tick > > > 2009/2/27 Graeme Gregory <dp@xora.org.uk>: >> Koen Kooi wrote: >>> On 25-02-09 21:46, Koen Kooi wrote: >>>> Hi, >>>> >>>> I was getting seriously annoyed with the useless error codes opkg was >>>> giving me and Tick pointed me to: >>>> >>>> http://code.google.com/p/opkg/issues/detail?id=6&can=1 >>>> >>>> We're at 197 now in OE (with r201 applied as patch). I'd like to get >>>> r199 and r200 in as well, and since I'm lazy I though we'd get r198 in >>>> as well, which means instead of adding a few patches I can just bump up >>>> SRCREV to 201. >>>> >>>> What do you think? >>> Noone is thinking anything? >>> >> Sorry been AFK, my opinion of these things is always no-one will test >> until stuff is committed anyway. So you might as well go ahead! Without >> the bug reports tick won't be able to improve opkg. >> >> Graeme (XorA) >> >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel >> > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [RFC] update opkg* SRCREV to 201 2009-02-25 20:46 [RFC] update opkg* SRCREV to 201 Koen Kooi 2009-02-26 14:55 ` Koen Kooi @ 2009-02-27 19:31 ` Koen Kooi 1 sibling, 0 replies; 12+ messages in thread From: Koen Kooi @ 2009-02-27 19:31 UTC (permalink / raw) To: openembedded-devel On 25-02-09 21:46, Koen Kooi wrote: > Hi, > > I was getting seriously annoyed with the useless error codes opkg was > giving me and Tick pointed me to: > > http://code.google.com/p/opkg/issues/detail?id=6&can=1 > > We're at 197 now in OE (with r201 applied as patch). I'd like to get > r199 and r200 in as well, and since I'm lazy I though we'd get r198 in > as well, which means instead of adding a few patches I can just bump up > SRCREV to 201. Since no-one objected I'll apply it this weekend when I get some time. regards, Koen ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2009-02-27 20:00 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-02-25 20:46 [RFC] update opkg* SRCREV to 201 Koen Kooi 2009-02-26 14:55 ` Koen Kooi 2009-02-26 15:40 ` Tom Rini 2009-02-27 7:20 ` Koen Kooi 2009-02-27 19:56 ` Tom Rini 2009-02-26 15:46 ` Philip Balister 2009-02-26 19:09 ` Mike (mwester) 2009-02-26 16:13 ` Graeme Gregory 2009-02-26 18:31 ` Tick 2009-02-26 19:41 ` Michael 'Mickey' Lauer 2009-02-26 20:25 ` Mike (mwester) 2009-02-27 19:31 ` Koen Kooi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.