Proposal to remove libattr recipe

Proposal to remove libattr recipe

[Henning Heinold]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hi,

the libattr from xfsprogs clashes with the attr recipe from udev and I can
find any recipe which uses libattr, besides libcap2 which could use attr
from udev too. So my proposal is to remove the libattr recipe and switch
libcap2 to use attr from udev. Attached are the two patches, to do it.

I would like to see some ack's.

Bye Henning

[-- Attachment #2: libattr.patch --]
[-- Type: text/x-diff, Size: 1529 bytes --]

From cd0071c89450f81df538107350065036b00f68a9 Mon Sep 17 00:00:00 2001
From: Henning Heinold <heinold@inf.fu-berlin.de>
Date: Thu, 17 Jun 2010 10:24:01 +0200
Subject: [PATCH 2/2] libattr: remove libattr because it is clashing with attr from udev and not used by anyother recipe

---
 recipes/xfsprogs/libattr_2.4.43.bb |   30 ------------------------------
 1 files changed, 0 insertions(+), 30 deletions(-)
 delete mode 100644 recipes/xfsprogs/libattr_2.4.43.bb

diff --git a/recipes/xfsprogs/libattr_2.4.43.bb b/recipes/xfsprogs/libattr_2.4.43.bb
deleted file mode 100644
index cf846cc..0000000
--- a/recipes/xfsprogs/libattr_2.4.43.bb
+++ /dev/null
@@ -1,30 +0,0 @@
-DESCRIPTION = "library functions to get attribute bits"
-HOMEPAGE = "http://oss.sgi.com/projects/xfs"
-LICENSE = "GPL"
-SECTION = "base"
-PR = "r0"
-DEPENDS = "gettext"
-
-SRC_URI = "ftp://oss.sgi.com/projects/xfs/cmd_tars/attr_${PV}-1.tar.gz"
-S = "${WORKDIR}/attr-${PV}"
-
-PARALLEL_MAKE = ""
-inherit autotools
-EXTRA_OECONF = "--enable-gettext=no --enable-shared=yes"
-
-do_configure () {
-	export LIBTOOL="${STAGING_BINDIR_NATIVE}/${HOST_SYS}-libtool"
-	export DEBUG="-DNDEBUG"
-	oe_runconf
-}
-
-do_install () {
-	export DIST_ROOT=${D}
-	oe_runmake install
-	oe_libinstall -a libattr ${D}${libdir}
-	oe_libinstall -a libattr ${STAGING_LIBDIR}
-}
-
-
-SRC_URI[md5sum] = "91583a14bcbd637adaa9b07ea49c5d4b"
-SRC_URI[sha256sum] = "d358b233b3e2ad235e63fd8697e337006fc7506844e424b0d9dd7a24affec5bf"
-- 
1.7.1


[-- Attachment #3: libcap2.patch --]
[-- Type: text/x-diff, Size: 1344 bytes --]

From cbccc349878874c876958ca65b1cdbcb2176c0db Mon Sep 17 00:00:00 2001
From: Henning Heinold <heinold@inf.fu-berlin.de>
Date: Thu, 17 Jun 2010 10:16:56 +0200
Subject: [PATCH 1/2] libcap2: use attr instead of libattr as dependency, fixes systemd

* convert to new staging system, by removing do_stage
---
 recipes/libcap/libcap2_2.16.bb |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/recipes/libcap/libcap2_2.16.bb b/recipes/libcap/libcap2_2.16.bb
index ebcb981..947811b 100644
--- a/recipes/libcap/libcap2_2.16.bb
+++ b/recipes/libcap/libcap2_2.16.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "Libcap is a library for getting and setting POSIX.1e (formerly PO
 PRIORITY = "optional"
 SECTION = "libs"
 LICENSE = "GPL"
-DEPENDS = "bison-native flex-native libattr"
+DEPENDS = "bison-native flex-native attr"
 PR = "r0"
 
 BUILD_CFLAGS += "-I${S}/libcap/include"
@@ -25,11 +25,5 @@ do_install() {
 	oe_libinstall -s -C libcap libcap ${D}${libdir}
 }
 
-do_stage() {
-	install -d ${STAGING_INCDIR}/sys
-	install -m 0644 libcap/include/sys/capability.h ${STAGING_INCDIR}/sys/
-	oe_libinstall -s -C libcap libcap ${STAGING_LIBDIR}
-}
-
 SRC_URI[md5sum] = "6e2c9d0f3c3118e41cd07288ba9577ce"
 SRC_URI[sha256sum] = "9c5a41a5577d6f702fe4d29e92f91f1d586a2ef272f6b7fa137bae3f0e76cc2f"
-- 
1.7.1

Re: Proposal to remove libattr recipe

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-06-10 14:19, Henning Heinold wrote:
> Hi,
> 
> the libattr from xfsprogs clashes with the attr recipe from udev

That statement is confusing, I think you mean:

"the libattr recipe in recipes/xfsprogs clashes with the attr recipe in
recipes/udev"

> and I can
> find any recipe which uses libattr, besides libcap2 which could use attr
> from udev too. So my proposal is to remove the libattr recipe and switch
> libcap2 to use attr from udev. Attached are the two patches, to do it.

libattr and attr build the same thing, I hadn't noticed 'libattr' when
adding 'attr', so it's completely safe to remove either one. Since the
attr one is newer your patches look good.

For both:

Acked-by: Koen Kooi <koen@openembedded.org>

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMGhXHMkyGM64RGpERAluWAJ9696wd9V3w2h1C7IQMiZPk+HTW6ACfd/vd
sIjXLPlqHboo11F2vJCPX54=
=NYpe
-----END PGP SIGNATURE-----

Re: Proposal to remove libattr recipe

[Frans Meulenbroeks]

2010/6/17 Henning Heinold <heinold@inf.fu-berlin.de>:
> Hi,
>
> the libattr from xfsprogs clashes with the attr recipe from udev and I can
> find any recipe which uses libattr, besides libcap2 which could use attr
> from udev too. So my proposal is to remove the libattr recipe and switch
> libcap2 to use attr from udev. Attached are the two patches, to do it.
>
> I would like to see some ack's.
>
> Bye Henning

Looks fine to me (but didn't play-test it).
Did check at my side too, but could not find recipes depending on
libattr either (grep -r libattr recipes) so:

Acked-By: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

Re: Proposal to remove libattr recipe

[Enrico Scholz]

Henning Heinold <heinold@inf.fu-berlin.de> writes:

> the libattr from xfsprogs clashes with the attr recipe from udev and I
> can find any recipe which uses libattr, besides libcap2 which could
> use attr from udev too. So my proposal is to remove the libattr recipe
> and switch libcap2 to use attr from udev.

Because 'xfs' is upstream for attr + acl it would be probably better to
do the opposite thing (remove these general libraries from udev/ and
update the xfsprogs/ version).  Or, remove both versions and move the
best one into toplevel /attr + /acl.


Enrico