From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/6] media: davinci: VPIF: add DT support
Date: Fri, 11 Nov 2016 09:55:54 -0800 [thread overview]
Message-ID: <m2bmxllx3p.fsf@baylibre.com> (raw)
In-Reply-To: <6058d790-5409-01c0-1d3f-b1bb45f8f85c@xs4all.nl> (Hans Verkuil's message of "Fri, 11 Nov 2016 16:36:31 +0100")
Hans Verkuil <hverkuil@xs4all.nl> writes:
> Hi Kevin,
>
> On 10/26/2016 01:55 AM, Kevin Hilman wrote:
>> This series attempts to add DT support to the davinci VPIF capture
>> driver.
>>
>> I'm not sure I've completely grasped the proper use of the ports and
>> endpoints stuff, so this RFC is primarily to get input on whether I'm
>> on the right track.
>>
>> The last patch is the one where all my questions are, the rest are
>> just prep work to ge there.
>>
>> Tested on da850-lcdk and was able to do basic frame capture from the
>> composite input.
>>
>> Series applies on v4.9-rc1
>>
>> Kevin Hilman (6):
>> [media] davinci: add support for DT init
>> ARM: davinci: da8xx: VPIF: enable DT init
>> ARM: dts: davinci: da850: add VPIF
>> ARM: dts: davinci: da850-lcdk: enable VPIF capture
>> [media] davinci: vpif_capture: don't lock over s_stream
>> [media] davinci: vpif_capture: get subdevs from DT
>
> Looks good, but wouldn't it be better to do the dts changes last when all the
> supporting code is in?
I guess it doesn't really matter in this case, because the DT nodes will
be nops until the driver changes are in.
Either way, next week I'll repost a non-RFC version and separate out the
arch and DT patches, since those will go through Sekhar's davinci tree,
and then via arm-soc.
Thanks for the review,
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org, "Sekhar Nori" <nsekhar@ti.com>,
"Axel Haslam" <ahaslam@baylibre.com>,
"Bartosz Gołaszewski" <bgolaszewski@baylibre.com>,
"Alexandre Bailon" <abailon@baylibre.com>,
"David Lechner" <david@lechnology.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 0/6] media: davinci: VPIF: add DT support
Date: Fri, 11 Nov 2016 09:55:54 -0800 [thread overview]
Message-ID: <m2bmxllx3p.fsf@baylibre.com> (raw)
In-Reply-To: <6058d790-5409-01c0-1d3f-b1bb45f8f85c@xs4all.nl> (Hans Verkuil's message of "Fri, 11 Nov 2016 16:36:31 +0100")
Hans Verkuil <hverkuil@xs4all.nl> writes:
> Hi Kevin,
>
> On 10/26/2016 01:55 AM, Kevin Hilman wrote:
>> This series attempts to add DT support to the davinci VPIF capture
>> driver.
>>
>> I'm not sure I've completely grasped the proper use of the ports and
>> endpoints stuff, so this RFC is primarily to get input on whether I'm
>> on the right track.
>>
>> The last patch is the one where all my questions are, the rest are
>> just prep work to ge there.
>>
>> Tested on da850-lcdk and was able to do basic frame capture from the
>> composite input.
>>
>> Series applies on v4.9-rc1
>>
>> Kevin Hilman (6):
>> [media] davinci: add support for DT init
>> ARM: davinci: da8xx: VPIF: enable DT init
>> ARM: dts: davinci: da850: add VPIF
>> ARM: dts: davinci: da850-lcdk: enable VPIF capture
>> [media] davinci: vpif_capture: don't lock over s_stream
>> [media] davinci: vpif_capture: get subdevs from DT
>
> Looks good, but wouldn't it be better to do the dts changes last when all the
> supporting code is in?
I guess it doesn't really matter in this case, because the DT nodes will
be nops until the driver changes are in.
Either way, next week I'll repost a non-RFC version and separate out the
arch and DT patches, since those will go through Sekhar's davinci tree,
and then via arm-soc.
Thanks for the review,
Kevin
next prev parent reply other threads:[~2016-11-11 17:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 23:55 [RFC PATCH 0/6] media: davinci: VPIF: add DT support Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 1/6] [media] davinci: add support for DT init Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 2/6] ARM: davinci: da8xx: VPIF: enable " Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 3/6] ARM: dts: davinci: da850: add VPIF Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 4/6] ARM: dts: davinci: da850-lcdk: enable VPIF capture Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 5/6] [media] davinci: vpif_capture: don't lock over s_stream Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-10-25 23:55 ` [RFC PATCH 6/6] [media] davinci: vpif_capture: get subdevs from DT Kevin Hilman
2016-10-25 23:55 ` Kevin Hilman
2016-11-11 15:36 ` Hans Verkuil
2016-11-11 15:36 ` Hans Verkuil
2016-11-11 15:50 ` Javier Martinez Canillas
2016-11-11 15:50 ` Javier Martinez Canillas
2016-11-11 15:53 ` Javier Martinez Canillas
2016-11-11 15:53 ` Javier Martinez Canillas
2016-10-28 17:17 ` [RFC PATCH 0/6] media: davinci: VPIF: add DT support Kevin Hilman
2016-10-28 17:17 ` Kevin Hilman
2016-11-11 15:36 ` Hans Verkuil
2016-11-11 15:36 ` Hans Verkuil
2016-11-11 17:55 ` Kevin Hilman [this message]
2016-11-11 17:55 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bmxllx3p.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.