From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Balbir Singh <bsingharora@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Shailabh Nagar <nagar@us.ibm.com>,
linux-kernel@vger.kernel.org, security@kernel.org,
Eric Paris <eparis@redhat.com>, Stephen Wilson <wilsons@start.ca>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [Security] [PATCH 2/2] taskstats: restrict access to user
Date: Mon, 19 Sep 2011 11:29:28 -0700 [thread overview]
Message-ID: <m2ipooe67r.fsf@firstfloor.org> (raw)
In-Reply-To: <CA+55aFxXS9z=NwoYug+qGoYufqN-6dCo4fm5ggTsoDonsMi4Dw@mail.gmail.com> (Linus Torvalds's message of "Mon, 19 Sep 2011 09:40:19 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> rc = parse(info->attrs[TASKSTATS_CMD_ATTR_REGISTER_CPUMASK], mask);
> diff --git a/kernel/tsacct.c b/kernel/tsacct.c
> index 24dc60d9fa1f..110ca5a03bd6 100644
> --- a/kernel/tsacct.c
> +++ b/kernel/tsacct.c
> @@ -78,6 +78,7 @@ void bacct_add_tsk(struct taskstats *stats, struct task_struct *tsk)
>
> #define KB 1024
Needs to be 1024ULL, because the counters are 64bit.
> #define MB (1024*KB)
> +#define KB_MASK (~(KB-1))
Otherwise you lose the upper 32bits here.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Balbir Singh <bsingharora@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Shailabh Nagar <nagar@us.ibm.com>,
linux-kernel@vger.kernel.org, security@kernel.org,
Eric Paris <eparis@redhat.com>, Stephen Wilson <wilsons@start.ca>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
kernel-hardening@lists.openwall.com
Subject: Re: [Security] [PATCH 2/2] taskstats: restrict access to user
Date: Mon, 19 Sep 2011 11:29:28 -0700 [thread overview]
Message-ID: <m2ipooe67r.fsf@firstfloor.org> (raw)
In-Reply-To: <CA+55aFxXS9z=NwoYug+qGoYufqN-6dCo4fm5ggTsoDonsMi4Dw@mail.gmail.com> (Linus Torvalds's message of "Mon, 19 Sep 2011 09:40:19 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> rc = parse(info->attrs[TASKSTATS_CMD_ATTR_REGISTER_CPUMASK], mask);
> diff --git a/kernel/tsacct.c b/kernel/tsacct.c
> index 24dc60d9fa1f..110ca5a03bd6 100644
> --- a/kernel/tsacct.c
> +++ b/kernel/tsacct.c
> @@ -78,6 +78,7 @@ void bacct_add_tsk(struct taskstats *stats, struct task_struct *tsk)
>
> #define KB 1024
Needs to be 1024ULL, because the counters are 64bit.
> #define MB (1024*KB)
> +#define KB_MASK (~(KB-1))
Otherwise you lose the upper 32bits here.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-09-19 18:29 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 12:09 [PATCH 2/2] taskstats: restrict access to user Vasiliy Kulikov
2011-06-29 1:27 ` Balbir Singh
2011-06-29 11:42 ` Vasiliy Kulikov
2011-06-29 20:17 ` Vasiliy Kulikov
2011-07-02 7:36 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-02 7:36 ` Vasiliy Kulikov
2011-07-04 2:57 ` [kernel-hardening] " Balbir Singh
2011-07-04 2:57 ` Balbir Singh
2011-07-04 17:45 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-04 17:45 ` Vasiliy Kulikov
2011-07-07 8:55 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-07 8:55 ` Vasiliy Kulikov
2011-07-07 11:53 ` [kernel-hardening] " Balbir Singh
2011-07-07 11:53 ` Balbir Singh
2011-07-07 16:23 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-07 16:23 ` Vasiliy Kulikov
2011-07-09 15:36 ` [kernel-hardening] " Balbir Singh
2011-07-09 15:36 ` Balbir Singh
2011-07-11 14:07 ` [kernel-hardening] " Vasiliy Kulikov
2011-07-11 14:07 ` Vasiliy Kulikov
2011-06-29 20:09 ` [Security] " Linus Torvalds
2011-06-30 7:57 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-30 7:57 ` Vasiliy Kulikov
2011-06-30 10:59 ` [kernel-hardening] " Balbir Singh
2011-06-30 10:59 ` Balbir Singh
2011-06-30 12:08 ` [kernel-hardening] " Vasiliy Kulikov
2011-06-30 12:08 ` Vasiliy Kulikov
2011-06-30 16:40 ` [kernel-hardening] " Linus Torvalds
2011-06-30 16:40 ` Linus Torvalds
2011-07-01 3:02 ` [kernel-hardening] " Balbir Singh
2011-07-01 3:02 ` Balbir Singh
2011-09-19 16:40 ` [kernel-hardening] " Linus Torvalds
2011-09-19 16:40 ` Linus Torvalds
2011-09-19 17:20 ` [kernel-hardening] " Balbir Singh
2011-09-19 17:20 ` Balbir Singh
2011-09-19 17:39 ` [kernel-hardening] " Vasiliy Kulikov
2011-09-19 17:39 ` Vasiliy Kulikov
2011-09-19 17:45 ` [kernel-hardening] " Linus Torvalds
2011-09-19 17:45 ` Linus Torvalds
2011-09-20 3:35 ` [kernel-hardening] " Eric W. Biederman
2011-09-20 3:35 ` Eric W. Biederman
2011-09-20 5:47 ` [kernel-hardening] " Alexey Dobriyan
2011-09-20 5:47 ` Alexey Dobriyan
2011-09-19 17:47 ` [kernel-hardening] " Balbir Singh
2011-09-19 17:47 ` Balbir Singh
2011-09-19 18:29 ` Andi Kleen [this message]
2011-09-19 18:29 ` Andi Kleen
2011-09-19 18:32 ` [kernel-hardening] " Linus Torvalds
2011-09-19 18:32 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ipooe67r.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=eparis@redhat.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@us.ibm.com \
--cc=rientjes@google.com \
--cc=security@kernel.org \
--cc=segoon@openwall.com \
--cc=torvalds@linux-foundation.org \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.