From: Andreas Schwab <schwab@linux-m68k.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
"Artem S. Tashkinov" <t.artem@mailcity.com>,
Dave Jones <davej@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t
Date: Thu, 22 Dec 2011 01:14:39 +0100 [thread overview]
Message-ID: <m2zkelo428.fsf@igel.home> (raw)
In-Reply-To: <20111221155624.1555d8a4.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 21 Dec 2011 15:56:24 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 22 Dec 2011 00:50:06 +0100
> Andreas Schwab <schwab@linux-m68k.org> wrote:
>
>> Andrew Morton <akpm@linux-foundation.org> writes:
>>
>> > From: Andreas Schwab <schwab@linux-m68k.org>
>> > Subject: procfs: do not confuse jiffies with cputime64_t
>> >
>> > get_{idle,iowait}_time are supposed to return cputime64_t values, not
>> > jiffies. Add usecs_to_cputime64 for this.
>>
>> For most architectures (which use the asm-generic/cputime.h) jiffies use
>> the same unit as cputime64_t values, but ia64, powerpc and s390 make
>> them different.
>>
>
> OK, but
>
> a) what effect does this problem have upon users of the kernel?
get_idle_time returns the value in the wrong unit.
> b) which kernel version(s) are affected?
get_idle_time got broken in 2a95ea6c0d129b4568fb64e1deda16ceb20e6636.
$ git tag --contains a25cac5198d4ff2842ccca63b423962848ad24b2
v3.2-rc1
v3.2-rc2
v3.2-rc3
v3.2-rc4
v3.2-rc5
v3.2-rc6
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-12-22 0:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m28vmi7ip3.fsf@igel.home>
2011-12-12 8:16 ` [PATCH] procfs: do not confuse jiffies with cputime64_t Michal Hocko
2011-12-12 9:22 ` Arnd Bergmann
2011-12-12 10:17 ` Andreas Schwab
2011-12-12 11:51 ` [PATCH v2] " Andreas Schwab
2011-12-12 12:43 ` Michal Hocko
2011-12-12 13:07 ` [PATCH v3] " Andreas Schwab
2011-12-12 13:12 ` Michal Hocko
2011-12-21 10:03 ` [resend PATCH for 3.2] " Michal Hocko
2011-12-21 19:43 ` Andrew Morton
2011-12-21 19:59 ` Andrew Morton
2011-12-21 23:50 ` Andreas Schwab
2011-12-21 23:56 ` Andrew Morton
2011-12-22 0:14 ` Andreas Schwab [this message]
2011-12-22 0:19 ` Andrew Morton
2011-12-22 10:18 ` Andreas Schwab
2011-12-21 23:55 ` Andreas Schwab
2011-12-21 23:59 ` Andrew Morton
2011-12-22 0:20 ` Andreas Schwab
2011-12-22 9:55 ` Martin Schwidefsky
2011-12-22 10:19 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zkelo428.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=schwidefsky@de.ibm.com \
--cc=t.artem@mailcity.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.