All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 8/9] vscode: add a dictionary for cSpell
From: Johannes Schindelin via GitGitGadget @ 2018-07-23 13:52 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin
In-Reply-To: <pull.2.git.gitgitgadget@gmail.com>

From: Johannes Schindelin <johannes.schindelin@gmx.de>

The quite useful cSpell extension allows VS Code to have "squiggly"
lines under spelling mistakes. By default, this would add too much
clutter, though, because so much of Git's source code uses words that
would trigger cSpell.

Let's add a few words to make the spell checking more useful by reducing
the number of false positives.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 contrib/vscode/init.sh | 169 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 168 insertions(+), 1 deletion(-)

diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index 29f2a729d..a134cb4c5 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -32,7 +32,174 @@ cat >.vscode/settings.json.new <<\EOF ||
     "files.associations": {
         "*.h": "c",
         "*.c": "c"
-    }
+    },
+    "cSpell.words": [
+        "DATAW",
+        "DBCACHED",
+        "DFCHECK",
+        "DTYPE",
+        "Hamano",
+        "HCAST",
+        "HEXSZ",
+        "HKEY",
+        "HKLM",
+        "IFGITLINK",
+        "IFINVALID",
+        "ISBROKEN",
+        "ISGITLINK",
+        "ISSYMREF",
+        "Junio",
+        "LPDWORD",
+        "LPPROC",
+        "LPWSTR",
+        "MSVCRT",
+        "NOARG",
+        "NOCOMPLETE",
+        "NOINHERIT",
+        "RENORMALIZE",
+        "STARTF",
+        "STARTUPINFOEXW",
+        "Schindelin",
+        "UCRT",
+        "YESNO",
+        "argcp",
+        "beginthreadex",
+        "committish",
+        "contentp",
+        "cpath",
+        "cpidx",
+        "ctim",
+        "dequote",
+        "envw",
+        "ewah",
+        "fdata",
+        "fherr",
+        "fhin",
+        "fhout",
+        "fragp",
+        "fsmonitor",
+        "hnsec",
+        "idents",
+        "includeif",
+        "interpr",
+        "iprog",
+        "isexe",
+        "iskeychar",
+        "kompare",
+        "mksnpath",
+        "mktag",
+        "mktree",
+        "mmblob",
+        "mmbuffer",
+        "mmfile",
+        "noenv",
+        "nparents",
+        "ntpath",
+        "ondisk",
+        "ooid",
+        "oplen",
+        "osdl",
+        "pnew",
+        "pold",
+        "ppinfo",
+        "pushf",
+        "pushv",
+        "rawsz",
+        "rebasing",
+        "reencode",
+        "repo",
+        "rerere",
+        "scld",
+        "sharedrepo",
+        "spawnv",
+        "spawnve",
+        "spawnvpe",
+        "strdup'ing",
+        "submodule",
+        "submodules",
+        "topath",
+        "topo",
+        "tpatch",
+        "unexecutable",
+        "unhide",
+        "unkc",
+        "unkv",
+        "unmark",
+        "unmatch",
+        "unsets",
+        "unshown",
+        "untracked",
+        "untrackedcache",
+        "unuse",
+        "upos",
+        "uval",
+        "vreportf",
+        "wargs",
+        "wargv",
+        "wbuffer",
+        "wcmd",
+        "wcsnicmp",
+        "wcstoutfdup",
+        "wdeltaenv",
+        "wdir",
+        "wenv",
+        "wenvblk",
+        "wenvcmp",
+        "wenviron",
+        "wenvpos",
+        "wenvsz",
+        "wfile",
+        "wfilename",
+        "wfopen",
+        "wfreopen",
+        "wfullpath",
+        "which'll",
+        "wlink",
+        "wmain",
+        "wmkdir",
+        "wmktemp",
+        "wnewpath",
+        "wotype",
+        "wpath",
+        "wpathname",
+        "wpgmptr",
+        "wpnew",
+        "wpointer",
+        "wpold",
+        "wpos",
+        "wputenv",
+        "wrmdir",
+        "wship",
+        "wtarget",
+        "wtemplate",
+        "wunlink",
+        "xcalloc",
+        "xgetcwd",
+        "xmallocz",
+        "xmemdupz",
+        "xmmap",
+        "xopts",
+        "xrealloc",
+        "xsnprintf",
+        "xutftowcs",
+        "xutftowcsn",
+        "xwcstoutf"
+    ],
+    "cSpell.ignoreRegExpList": [
+        "\\\"(DIRC|FSMN|REUC|UNTR)\\\"",
+        "\\\\u[0-9a-fA-Fx]{4}\\b",
+        "\\b(filfre|frotz|xyzzy)\\b",
+        "\\bCMIT_FMT_DEFAULT\\b",
+        "\\bde-munge\\b",
+        "\\bGET_OID_DISAMBIGUATORS\\b",
+        "\\bHASH_RENORMALIZE\\b",
+        "\\bTREESAMEness\\b",
+        "\\bUSE_STDEV\\b",
+        "\\Wchar *\\*\\W*utfs\\W",
+        "cURL's",
+        "nedmalloc'ed",
+        "ntifs\\.h",
+    ],
 }
 EOF
 die "Could not write settings.json"
-- 
gitgitgadget


^ permalink raw reply related

* [PATCH 9/9] vscode: let cSpell work on commit messages, too
From: Johannes Schindelin via GitGitGadget @ 2018-07-23 13:53 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin
In-Reply-To: <pull.2.git.gitgitgadget@gmail.com>

From: Johannes Schindelin <johannes.schindelin@gmx.de>

By default, the cSpell extension ignores all files under .git/. That
includes, unfortunately, COMMIT_EDITMSG, i.e. commit messages. However,
spell checking is *quite* useful when writing commit messages... And
since the user hardly ever opens any file inside .git (apart from commit
messages, the config, and sometimes interactive rebase's todo lists),
there is really not much harm in *not* ignoring .git/.

The default also ignores `node_modules/`, but that does not apply to
Git, so let's skip ignoring that, too.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 contrib/vscode/init.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index a134cb4c5..27de94994 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -33,6 +33,8 @@ cat >.vscode/settings.json.new <<\EOF ||
         "*.h": "c",
         "*.c": "c"
     },
+    "cSpell.ignorePaths": [
+    ],
     "cSpell.words": [
         "DATAW",
         "DBCACHED",
-- 
gitgitgadget

^ permalink raw reply related

* [PATCH 7/9] vscode: use 8-space tabs, no trailing ws, etc for Git's source code
From: Johannes Schindelin via GitGitGadget @ 2018-07-23 13:52 UTC (permalink / raw)
  To: git; +Cc: Junio C Hamano, Johannes Schindelin
In-Reply-To: <pull.2.git.gitgitgadget@gmail.com>

From: Johannes Schindelin <johannes.schindelin@gmx.de>

This adds a couple settings for the .c/.h files so that it is easier to
conform to Git's conventions while editing the source code.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 contrib/vscode/init.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
index face115e8..29f2a729d 100755
--- a/contrib/vscode/init.sh
+++ b/contrib/vscode/init.sh
@@ -21,6 +21,14 @@ cat >.vscode/settings.json.new <<\EOF ||
         "editor.wordWrap": "wordWrapColumn",
         "editor.wordWrapColumn": 72
     },
+    "[c]": {
+        "editor.detectIndentation": false,
+        "editor.insertSpaces": false,
+        "editor.tabSize": 8,
+        "editor.wordWrap": "wordWrapColumn",
+        "editor.wordWrapColumn": 80,
+        "files.trimTrailingWhitespace": true
+    },
     "files.associations": {
         "*.h": "c",
         "*.c": "c"
-- 
gitgitgadget


^ permalink raw reply related

* rte_mbuf library likely()/unlikely()
From: Morten Brørup @ 2018-07-23 13:53 UTC (permalink / raw)
  To: Olivier Matz; +Cc: dev

Hi Olivier,

 

I noticed that __rte_pktmbuf_read() could do with an unlikely(), so I went through the entire library. Here are my suggested modifications.

 

 

diff -bu rte_mbuf.c.orig rte_mbuf.c

--- rte_mbuf.c.orig     2018-07-23 15:13:22.000000000 +0200

+++ rte_mbuf.c  2018-07-23 15:32:53.000000000 +0200

@@ -173,19 +173,19 @@

{

        unsigned int nb_segs, pkt_len;

 

-       if (m == NULL)

+       if (unlikely(m == NULL))

                rte_panic("mbuf is NULL\n");

 

        /* generic checks */

-       if (m->pool == NULL)

+       if (unlikely(m->pool == NULL))

                rte_panic("bad mbuf pool\n");

-       if (m->buf_iova == 0)

+       if (unlikely(m->buf_iova == 0))

                rte_panic("bad IO addr\n");

-       if (m->buf_addr == NULL)

+       if (unlikely(m->buf_addr == NULL))

                rte_panic("bad virt addr\n");

 

        uint16_t cnt = rte_mbuf_refcnt_read(m);

-       if ((cnt == 0) || (cnt == UINT16_MAX))

+       if (unlikely((cnt == 0) || (cnt == UINT16_MAX)))

                rte_panic("bad ref cnt\n");

 

        /* nothing to check for sub-segments */

@@ -193,7 +193,7 @@

                return;

 

        /* data_len is supposed to be not more than pkt_len */

-       if (m->data_len > m->pkt_len)

+       if (unlikely(m->data_len > m->pkt_len))

                rte_panic("bad data_len\n");

 

        nb_segs = m->nb_segs;

@@ -204,9 +204,9 @@

                pkt_len -= m->data_len;

        } while ((m = m->next) != NULL);

 

-       if (nb_segs)

+       if (unlikely(nb_segs))

                rte_panic("bad nb_segs\n");

-       if (pkt_len)

+       if (unlikely(pkt_len))

                rte_panic("bad pkt_len\n");

}

 

@@ -249,7 +249,7 @@

        const struct rte_mbuf *seg = m;

        uint32_t buf_off = 0, copy_len;

 

-       if (off + len > rte_pktmbuf_pkt_len(m))

+       if (unlikely(off + len > rte_pktmbuf_pkt_len(m)))

                return NULL;

 

        while (off >= rte_pktmbuf_data_len(seg)) {

@@ -257,7 +257,7 @@

                seg = seg->next;

        }

 

-       if (off + len <= rte_pktmbuf_data_len(seg))

+       if (likely(off + len <= rte_pktmbuf_data_len(seg)))

                return rte_pktmbuf_mtod_offset(seg, char *, off);

 

        /* rare case: header is split among several segments */

@@ -344,7 +344,7 @@

        unsigned int i;

        int ret;

 

-       if (buflen == 0)

+       if (unlikely(buflen == 0))

                return -1;

 

        buf[0] = '\0';

@@ -355,9 +355,9 @@

                if (name == NULL)

                        name = rx_flags[i].default_name;

                ret = snprintf(buf, buflen, "%s ", name);

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -440,7 +440,7 @@

        unsigned int i;

        int ret;

 

-       if (buflen == 0)

+       if (unlikely(buflen == 0))

                return -1;

 

        buf[0] = '\0';

@@ -451,9 +451,9 @@

                if (name == NULL)

                        name = tx_flags[i].default_name;

                ret = snprintf(buf, buflen, "%s ", name);

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

 

 

diff -bu rte_mbuf.h.orig rte_mbuf.h

--- rte_mbuf.h.orig     2018-07-23 15:13:26.000000000 +0200

+++ rte_mbuf.h  2018-07-23 15:24:25.000000000 +0200

@@ -1007,7 +1007,7 @@

{

        struct rte_mbuf *m;

 

-       if (rte_mempool_get(mp, (void **)&m) < 0)

+       if (unlikely(rte_mempool_get(mp, (void **)&m) < 0))

                return NULL;

        MBUF_RAW_ALLOC_CHECK(m);

        return m;

@@ -1268,7 +1268,7 @@

static inline struct rte_mbuf *rte_pktmbuf_alloc(struct rte_mempool *mp)

{

        struct rte_mbuf *m;

-       if ((m = rte_mbuf_raw_alloc(mp)) != NULL)

+       if (likely((m = rte_mbuf_raw_alloc(mp)) != NULL))

                rte_pktmbuf_reset(m);

        return m;

}

@@ -1696,7 +1696,7 @@

{

        struct rte_mbuf *m_next;

 

-       if (m != NULL)

+       if (likely(m != NULL))

                __rte_mbuf_sanity_check(m, 1);

 

        while (m != NULL) {

@@ -2099,7 +2099,7 @@

        struct rte_mbuf *cur_tail;

 

        /* Check for number-of-segments-overflow */

-       if (head->nb_segs + tail->nb_segs > RTE_MBUF_MAX_NB_SEGS)

+       if (unlikely(head->nb_segs + tail->nb_segs > RTE_MBUF_MAX_NB_SEGS))

                return -EOVERFLOW;

 

        /* Chain 'tail' onto the old tail */

@@ -2147,28 +2147,28 @@

                                  m->outer_l3_len;

 

        /* Headers are fragmented */

-       if (rte_pktmbuf_data_len(m) < inner_l3_offset + m->l3_len + m->l4_len)

+       if (unlikely(rte_pktmbuf_data_len(m) < inner_l3_offset + m->l3_len + m->l4_len))

                return -ENOTSUP;

 

        /* IP checksum can be counted only for IPv4 packet */

-       if ((ol_flags & PKT_TX_IP_CKSUM) && (ol_flags & PKT_TX_IPV6))

+       if (unlikely((ol_flags & PKT_TX_IP_CKSUM) && (ol_flags & PKT_TX_IPV6)))

                return -EINVAL;

 

        /* IP type not set when required */

        if (ol_flags & (PKT_TX_L4_MASK | PKT_TX_TCP_SEG))

-               if (!(ol_flags & (PKT_TX_IPV4 | PKT_TX_IPV6)))

+               if (unlikely(!(ol_flags & (PKT_TX_IPV4 | PKT_TX_IPV6))))

                        return -EINVAL;

 

        /* Check requirements for TSO packet */

        if (ol_flags & PKT_TX_TCP_SEG)

-               if ((m->tso_segsz == 0) ||

+               if (unlikely((m->tso_segsz == 0) ||

                                ((ol_flags & PKT_TX_IPV4) &&

-                               !(ol_flags & PKT_TX_IP_CKSUM)))

+                               !(ol_flags & PKT_TX_IP_CKSUM))))

                        return -EINVAL;

 

        /* PKT_TX_OUTER_IP_CKSUM set for non outer IPv4 packet. */

-       if ((ol_flags & PKT_TX_OUTER_IP_CKSUM) &&

-                       !(ol_flags & PKT_TX_OUTER_IPV4))

+       if (unlikely((ol_flags & PKT_TX_OUTER_IP_CKSUM) &&

+                       !(ol_flags & PKT_TX_OUTER_IPV4)))

                return -EINVAL;

 

        return 0;

 

 

diff -bu rte_mbuf_ptype.c.orig rte_mbuf_ptype.c

--- rte_mbuf_ptype.c.orig       2018-07-23 15:45:49.000000000 +0200

+++ rte_mbuf_ptype.c    2018-07-23 15:44:59.000000000 +0200

@@ -118,15 +118,15 @@

{

        int ret;

 

-       if (buflen == 0)

+       if (unlikely(buflen == 0))

                return -1;

 

        buf[0] = '\0';

        if ((ptype & RTE_PTYPE_ALL_MASK) == RTE_PTYPE_UNKNOWN) {

                ret = snprintf(buf, buflen, "UNKNOWN");

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                       return -1;

                return 0;

        }

@@ -134,9 +134,9 @@

        if ((ptype & RTE_PTYPE_L2_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_l2_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -144,9 +144,9 @@

        if ((ptype & RTE_PTYPE_L3_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_l3_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -154,9 +154,9 @@

        if ((ptype & RTE_PTYPE_L4_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_l4_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -164,9 +164,9 @@

        if ((ptype & RTE_PTYPE_TUNNEL_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_tunnel_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -174,9 +174,9 @@

        if ((ptype & RTE_PTYPE_INNER_L2_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_inner_l2_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -184,9 +184,9 @@

        if ((ptype & RTE_PTYPE_INNER_L3_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_inner_l3_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

@@ -194,9 +194,9 @@

        if ((ptype & RTE_PTYPE_INNER_L4_MASK) != 0) {

                ret = snprintf(buf, buflen, "%s ",

                        rte_get_ptype_inner_l4_name(ptype));

-               if (ret < 0)

+               if (unlikely(ret < 0))

                        return -1;

-               if ((size_t)ret >= buflen)

+               if (unlikely((size_t)ret >= buflen))

                        return -1;

                buf += ret;

                buflen -= ret;

 

 

 

Med venlig hilsen / kind regards

 

Morten Brørup

CTO

 

 

SmartShare Systems A/S

Tonsbakken 16-18

DK-2740 Skovlunde

Denmark

 

Office      +45 70 20 00 93

Direct      +45 89 93 50 22

Mobile     +45 25 40 82 12

 

mb@smartsharesystems.com <mailto:mb@smartsharesystems.com> 

www.smartsharesystems.com <https://www.smartsharesystems.com/> 

 


^ permalink raw reply

* Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149
From: Kevin Wolf @ 2018-07-23 13:53 UTC (permalink / raw)
  To: John Snow; +Cc: qemu-block, qemu-devel, mreitz, Daniel P. Berrange
In-Reply-To: <b444806b-61da-9930-f0cb-7610d241a16e@redhat.com>

Am 13.07.2018 um 20:12 hat John Snow geschrieben:
> 
> 
> On 07/13/2018 03:10 AM, Kevin Wolf wrote:
> > The test case uses block devices with driver=file, which causes the test
> > to fail after commit 230ff73904 added a deprecation warning for this.
> > Fix the test case to use driver=host_device and update the reference
> > output accordingly.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> 
> 149         [not run] requires password-less sudo access: sudo: a
> password is required
> 
> Ah, this one hides from regression scripts quite well...
> 
> This test fails both before and after this patch for me, with
> 
> +Traceback (most recent call last):
> +  File "149", line 525, in <module>
> +    test_once(config, qemu_img=False)
> +  File "149", line 336, in test_once
> +    cryptsetup_open(config)
> +  File "149", line 200, in cryptsetup_open
> +    cryptsetup(args, password)
> +  File "149", line 124, in cryptsetup
> +    raise Exception(msg)
> +Exception: Device qiotest-145-twofish-128-xts-plain64-sha1 already exists.
> +Command failed with code 17: File exists
> 
> Am I missing some prerequisite, maybe?

Hm, sounds a bit like a failed first attempt that didn't clean up behind
itself properly? Just guessing though.

Kevin

^ permalink raw reply

* Re: [PATCH v3 2/5] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks
From: Sean Paul @ 2018-07-23 13:54 UTC (permalink / raw)
  To: Haneen Mohammed; +Cc: rodrigosiqueiramelo, dri-devel
In-Reply-To: <06fe5281f62eb541496a0e8f79127f20e895a9ac.1531955948.git.hamohammed.sa@gmail.com>

On Thu, Jul 19, 2018 at 03:18:55AM +0300, Haneen Mohammed wrote:
> This patch map/unmap GEM backing memory to kernel address space
> in prepare/cleanup_fb respectively and cache the virtual address
> for later use.
> 
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
> Changes in v2:
> - use vkms_gem_vunmap
> 
> Changes in v3:
> - return error number instead of vkms_obj->vaddr
> 
>  drivers/gpu/drm/vkms/vkms_plane.c | 35 +++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index 9f75b1e2c1c4..aa6cde34710c 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -9,6 +9,7 @@
>  #include "vkms_drv.h"
>  #include <drm/drm_plane_helper.h>
>  #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_gem_framebuffer_helper.h>
>  
>  static const struct drm_plane_funcs vkms_plane_funcs = {
>  	.update_plane		= drm_atomic_helper_update_plane,
> @@ -24,8 +25,42 @@ static void vkms_primary_plane_update(struct drm_plane *plane,
>  {
>  }
>  
> +static int vkms_prepare_fb(struct drm_plane *plane,
> +			   struct drm_plane_state *state)
> +{
> +	struct drm_gem_object *gem_obj;
> +	struct vkms_gem_object *vkms_obj;
> +	int ret;
> +
> +	if (!state->fb)
> +		return 0;
> +
> +	gem_obj = drm_gem_fb_get_obj(state->fb, 0);
> +	vkms_obj = drm_gem_to_vkms_gem(gem_obj);
> +	ret = vkms_gem_vmap(gem_obj);
> +

nit: extra line

> +	if (ret)
> +		DRM_ERROR("vmap failed\n");

Can we actually do anything useful if the vmap fails? Asked another way, what's
the value in not returning the error here? (We should also print the value of
ret).

Sean

> +
> +	return drm_gem_fb_prepare_fb(plane, state);
> +}
> +
> +static void vkms_cleanup_fb(struct drm_plane *plane,
> +			    struct drm_plane_state *old_state)
> +{
> +	struct drm_gem_object *gem_obj;
> +
> +	if (!old_state->fb)
> +		return;
> +
> +	gem_obj = drm_gem_fb_get_obj(old_state->fb, 0);
> +	vkms_gem_vunmap(gem_obj);
> +}
> +
>  static const struct drm_plane_helper_funcs vkms_primary_helper_funcs = {
>  	.atomic_update		= vkms_primary_plane_update,
> +	.prepare_fb		= vkms_prepare_fb,
> +	.cleanup_fb		= vkms_cleanup_fb,
>  };
>  
>  struct drm_plane *vkms_plane_init(struct vkms_device *vkmsdev)
> -- 
> 2.17.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply

* [U-Boot] [PATCH v2 1/5] common: Log should depends on DM not be selected by DM
From: Michal Simek @ 2018-07-23 13:55 UTC (permalink / raw)
  To: u-boot

Better use depends on instead of select.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---

Changes in v2: None

I found this in connection to setup imply CMD_DM and it seems to not
standard that it is selecting DM which is not used anywhere else.

---
 common/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/Kconfig b/common/Kconfig
index 81e88ea77c17..eae5d80cc71b 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -428,7 +428,7 @@ menu "Logging"
 
 config LOG
 	bool "Enable logging support"
-	select DM
+	depends on DM
 	help
 	  This enables support for logging of status and debug messages. These
 	  can be displayed on the console, recorded in a memory buffer, or
-- 
1.9.1

^ permalink raw reply related

* [U-Boot] [PATCH v2 2/5] Kconfig: Replace spaces with tabs and missing newline
From: Michal Simek @ 2018-07-23 13:55 UTC (permalink / raw)
  To: u-boot
In-Reply-To: <c066c7007bdf6864e8695477fb28c091f1f6e9bf.1532354106.git.michal.simek@xilinx.com>

Trivial Kconfig cleanup. Use tabs instead of spaces and every Kconfig
entry should be separated by newline.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- new patch - not to confuse script

 arch/arm/Kconfig              | 10 +++++-----
 arch/arm/mach-imx/mx6/Kconfig | 14 +++++++-------
 cmd/Kconfig                   |  5 +++--
 3 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 376851ef7aa9..ce619641b753 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -169,7 +169,7 @@ config ARM_ERRATA_833471
 	bool
 
 config ARM_ERRATA_845369
-       bool
+	bool
 
 config ARM_ERRATA_852421
 	bool
@@ -683,7 +683,7 @@ config ARCH_MX31
 	select CPU_ARM1136
 
 config ARCH_MX7ULP
-        bool "NXP MX7ULP"
+	bool "NXP MX7ULP"
 	select CPU_V7A
 	select ROM_UNIFIED_SECTIONS
 	imply MXC_GPIO
@@ -709,7 +709,7 @@ config ARCH_MX6
 
 if ARCH_MX6
 config SPL_LDSCRIPT
-        default "arch/arm/mach-omap2/u-boot-spl.lds"
+	default "arch/arm/mach-omap2/u-boot-spl.lds"
 endif
 
 config ARCH_MX5
@@ -1486,8 +1486,8 @@ source "arch/arm/Kconfig.debug"
 endmenu
 
 config SPL_LDSCRIPT
-        default "arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds" if (ARCH_MX23 || ARCH_MX28) && !SPL_FRAMEWORK
-        default "arch/arm/cpu/arm1136/u-boot-spl.lds" if CPU_ARM1136
+	default "arch/arm/cpu/arm926ejs/mxs/u-boot-spl.lds" if (ARCH_MX23 || ARCH_MX28) && !SPL_FRAMEWORK
+	default "arch/arm/cpu/arm1136/u-boot-spl.lds" if CPU_ARM1136
 	default "arch/arm/cpu/armv8/u-boot-spl.lds" if ARM64
 
 
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
index 521fad74b5a2..b7b77cc51b97 100644
--- a/arch/arm/mach-imx/mx6/Kconfig
+++ b/arch/arm/mach-imx/mx6/Kconfig
@@ -293,11 +293,11 @@ config TARGET_MX6SLEVK
 	select SUPPORT_SPL
 
 config TARGET_MX6SLLEVK
-        bool "mx6sll evk"
+	bool "mx6sll evk"
 	select BOARD_LATE_INIT
-        select MX6SLL
-        select DM
-        select DM_THERMAL
+	select MX6SLL
+	select DM
+	select DM_THERMAL
 
 config TARGET_MX6SXSABRESD
 	bool "mx6sxsabresd"
@@ -309,11 +309,11 @@ config TARGET_MX6SXSABRESD
 	select BOARD_EARLY_INIT_F
 
 config TARGET_MX6SXSABREAUTO
-        bool "mx6sxsabreauto"
+	bool "mx6sxsabreauto"
 	select BOARD_LATE_INIT
 	select MX6SX
-        select DM
-        select DM_THERMAL
+	select DM
+	select DM_THERMAL
 	select BOARD_EARLY_INIT_F
 
 config TARGET_MX6UL_9X9_EVK
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 2fa0829925c1..b359ac7118b0 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1012,11 +1012,12 @@ config CMD_USB_SDP
 	help
 	  Enables the command "sdp" which is used to have U-Boot emulating the
 	  Serial Download Protocol (SDP) via USB.
+
 config CMD_ROCKUSB
 	bool "rockusb"
 	depends on USB_FUNCTION_ROCKUSB
 	help
-          Rockusb protocol is widely used by Rockchip SoC based devices. It can
+	  Rockusb protocol is widely used by Rockchip SoC based devices. It can
 	  read/write info, image to/from devices. This enable rockusb command
 	  support to communication with rockusb device. for more detail about
 	  this command, please read doc/README.rockusb.
@@ -1489,7 +1490,7 @@ config CMD_BLOB
 	  the original data.
 
 	  Sub-commands:
-            blob enc - encapsulating data as a cryptgraphic blob
+	    blob enc - encapsulating data as a cryptgraphic blob
 	    blob dec - decapsulating cryptgraphic blob to get the data
 
 	  Syntax:
-- 
1.9.1

^ permalink raw reply related

* [U-Boot] [PATCH v2 3/5] Kconfig: Sort bool, default, select and imply options
From: Michal Simek @ 2018-07-23 13:55 UTC (permalink / raw)
  To: u-boot
In-Reply-To: <c066c7007bdf6864e8695477fb28c091f1f6e9bf.1532354106.git.michal.simek@xilinx.com>

Fix Kconfig bool, default, select and imply options to be
alphabetically sorted.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- new patch

I have sorted only Kconfig which I need for the next patch.

---
 arch/Kconfig                       |  54 +++++-----
 arch/arm/Kconfig                   | 206 ++++++++++++++++++-------------------
 arch/arm/mach-at91/Kconfig         |  60 +++++------
 arch/arm/mach-imx/mx5/Kconfig      |  12 +--
 arch/arm/mach-imx/mx6/Kconfig      | 158 ++++++++++++++--------------
 arch/arm/mach-imx/mx7/Kconfig      |  18 ++--
 arch/arm/mach-omap2/am33xx/Kconfig |  46 ++++-----
 arch/arm/mach-omap2/omap3/Kconfig  |  20 ++--
 arch/arm/mach-rmobile/Kconfig.32   |  14 +--
 arch/arm/mach-tegra/Kconfig        |   8 +-
 arch/microblaze/Kconfig            |   4 +-
 arch/mips/Kconfig                  |  50 ++++-----
 arch/powerpc/cpu/mpc83xx/Kconfig   |   6 +-
 cmd/Kconfig                        |  14 +--
 14 files changed, 335 insertions(+), 335 deletions(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index cbeb9f67348f..7967fa50ac22 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -10,12 +10,12 @@ choice
 
 config ARC
 	bool "ARC architecture"
-	select HAVE_PRIVATE_LIBGCC
-	select SUPPORT_OF_CONTROL
 	select ARCH_EARLY_INIT_R
+	select ARC_TIMER
 	select CLK
+	select HAVE_PRIVATE_LIBGCC
+	select SUPPORT_OF_CONTROL
 	select TIMER
-	select ARC_TIMER
 
 config ARM
 	bool "ARM architecture"
@@ -46,10 +46,10 @@ config NDS32
 
 config NIOS2
 	bool "Nios II architecture"
-	select SUPPORT_OF_CONTROL
-	select OF_CONTROL
-	select DM
 	select CPU
+	select DM
+	select OF_CONTROL
+	select SUPPORT_OF_CONTROL
 
 config PPC
 	bool "PowerPC architecture"
@@ -65,30 +65,30 @@ config RISCV
 config SANDBOX
 	bool "Sandbox"
 	select BOARD_LATE_INIT
-	select SUPPORT_OF_CONTROL
 	select DM
+	select DM_GPIO
+	select DM_I2C
 	select DM_KEYBOARD
-	select DM_SPI_FLASH
+	select DM_MMC
 	select DM_SERIAL
-	select DM_I2C
 	select DM_SPI
-	select DM_GPIO
-	select DM_MMC
+	select DM_SPI_FLASH
 	select HAVE_BLOCK_DEVICE
-	select SPI
 	select LZO
+	select SPI
+	select SUPPORT_OF_CONTROL
 	imply CMD_GETTIME
 	imply CMD_HASH
 	imply CMD_IO
 	imply CMD_IOTRACE
 	imply CMD_LZMADEC
+	imply CMD_SATA
+	imply CMD_SF_TEST
 	imply CRC32_VERIFY
 	imply FAT_WRITE
 	imply HASH_VERIFY
 	imply LZMA
 	imply SCSI
-	imply CMD_SATA
-	imply CMD_SF_TEST
 
 config SH
 	bool "SuperH architecture"
@@ -97,39 +97,39 @@ config SH
 config X86
 	bool "x86 architecture"
 	select CREATE_ARCH_SYMLINK
-	select HAVE_PRIVATE_LIBGCC
-	select USE_PRIVATE_LIBGCC
-	select SUPPORT_OF_CONTROL
-	select OF_CONTROL
 	select DM
 	select DM_PCI
+	select HAVE_PRIVATE_LIBGCC
+	select OF_CONTROL
 	select PCI
+	select SUPPORT_OF_CONTROL
 	select TIMER
+	select USE_PRIVATE_LIBGCC
 	select X86_TSC_TIMER
 	imply BLK
+	imply CMD_FPGA_LOADMK
+	imply CMD_GETTIME
+	imply CMD_IO
+	imply CMD_IRQ
+	imply CMD_PCI
+	imply CMD_SF_TEST
+	imply CMD_ZBOOT
 	imply DM_ETH
 	imply DM_GPIO
 	imply DM_KEYBOARD
 	imply DM_MMC
 	imply DM_RTC
-	imply DM_SERIAL
 	imply DM_SCSI
+	imply DM_SERIAL
 	imply DM_SPI
 	imply DM_SPI_FLASH
 	imply DM_USB
 	imply DM_VIDEO
 	imply SYSRESET
 	imply SYSRESET_X86
-	imply CMD_FPGA_LOADMK
-	imply CMD_GETTIME
-	imply CMD_IO
-	imply CMD_IRQ
-	imply CMD_PCI
-	imply CMD_SF_TEST
-	imply CMD_ZBOOT
-	imply USB_HOST_ETHER
 	imply USB_ETHER_ASIX
 	imply USB_ETHER_SMSC95XX
+	imply USB_HOST_ETHER
 
 config XTENSA
 	bool "Xtensa architecture"
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ce619641b753..0c43c58ef0ed 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -219,25 +219,25 @@ config CPU_ARM1176
 
 config CPU_V7A
 	bool
-	select HAS_VBAR
 	select HAS_THUMB2
+	select HAS_VBAR
 	select SYS_CACHE_SHIFT_6
 	imply SYS_ARM_MMU
 
 config CPU_V7M
 	bool
 	select HAS_THUMB2
-	select THUMB2_KERNEL
-	select SYS_CACHE_SHIFT_5
 	select SYS_ARM_MPU
+	select SYS_CACHE_SHIFT_5
 	select SYS_THUMB_BUILD
+	select THUMB2_KERNEL
 
 config CPU_V7R
 	bool
 	select HAS_THUMB2
-	select SYS_CACHE_SHIFT_6
-	select SYS_ARM_MPU
 	select SYS_ARM_CACHE_CP15
+	select SYS_ARM_MPU
+	select SYS_CACHE_SHIFT_6
 
 config CPU_PXA
 	bool
@@ -427,19 +427,19 @@ config ARCH_DAVINCI
 
 config KIRKWOOD
 	bool "Marvell Kirkwood"
-	select CPU_ARM926EJS
-	select BOARD_EARLY_INIT_F
 	select ARCH_MISC_INIT
+	select BOARD_EARLY_INIT_F
+	select CPU_ARM926EJS
 
 config ARCH_MVEBU
 	bool "Marvell MVEBU family (Armada XP/375/38x/3700/7K/8K)"
-	select OF_CONTROL
-	select OF_SEPARATE
 	select DM
 	select DM_ETH
 	select DM_SERIAL
 	select DM_SPI
 	select DM_SPI_FLASH
+	select OF_CONTROL
+	select OF_SEPARATE
 	select SPI
 
 config TARGET_DEVKIT3250
@@ -463,31 +463,31 @@ config ORION5X
 
 config TARGET_SPEAR300
 	bool "Support spear300"
-	select CPU_ARM926EJS
 	select BOARD_EARLY_INIT_F
-	imply CMD_SAVES
+	select CPU_ARM926EJS
 	select PL011_SERIAL
+	imply CMD_SAVES
 
 config TARGET_SPEAR310
 	bool "Support spear310"
-	select CPU_ARM926EJS
 	select BOARD_EARLY_INIT_F
-	imply CMD_SAVES
+	select CPU_ARM926EJS
 	select PL011_SERIAL
+	imply CMD_SAVES
 
 config TARGET_SPEAR320
 	bool "Support spear320"
-	select CPU_ARM926EJS
 	select BOARD_EARLY_INIT_F
-	imply CMD_SAVES
+	select CPU_ARM926EJS
 	select PL011_SERIAL
+	imply CMD_SAVES
 
 config TARGET_SPEAR600
 	bool "Support spear600"
-	select CPU_ARM926EJS
 	select BOARD_EARLY_INIT_F
-	imply CMD_SAVES
+	select CPU_ARM926EJS
 	select PL011_SERIAL
+	imply CMD_SAVES
 
 config TARGET_STV0991
 	bool "Support stv0991"
@@ -496,16 +496,16 @@ config TARGET_STV0991
 	select DM_SERIAL
 	select DM_SPI
 	select DM_SPI_FLASH
+	select PL01X_SERIAL
 	select SPI
 	select SPI_FLASH
-	select PL01X_SERIAL
 
 config TARGET_X600
 	bool "Support x600"
 	select BOARD_LATE_INIT
 	select CPU_ARM926EJS
-	select SUPPORT_SPL
 	select PL011_SERIAL
+	select SUPPORT_SPL
 
 config TARGET_WOODBURN
 	bool "Support woodburn"
@@ -528,8 +528,8 @@ config TARGET_MX35PDK
 config ARCH_BCM283X
 	bool "Broadcom BCM283X family"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OF_CONTROL
 	select PL01X_SERIAL
 	select SERIAL_SEARCH_ALL
@@ -577,13 +577,13 @@ config TARGET_BCM28155_AP
 config TARGET_BCMCYGNUS
 	bool "Support bcmcygnus"
 	select CPU_V7A
-	imply CRC32_VERIFY
+	imply BCM_SF2_ETH
+	imply BCM_SF2_ETH_GMAC
 	imply CMD_HASH
+	imply CRC32_VERIFY
 	imply FAT_WRITE
 	imply HASH_VERIFY
 	imply NETDEVICES
-	imply BCM_SF2_ETH
-	imply BCM_SF2_ETH_GMAC
 
 config TARGET_BCMNSP
 	bool "Support bcmnsp"
@@ -600,12 +600,12 @@ config TARGET_BCMNS2
 config ARCH_EXYNOS
 	bool "Samsung EXYNOS"
 	select DM
+	select DM_GPIO
 	select DM_I2C
-	select DM_SPI_FLASH
+	select DM_KEYBOARD
 	select DM_SERIAL
 	select DM_SPI
-	select DM_GPIO
-	select DM_KEYBOARD
+	select DM_SPI_FLASH
 	select SPI
 	imply FAT_WRITE
 
@@ -613,9 +613,9 @@ config ARCH_S5PC1XX
 	bool "Samsung S5PC1XX"
 	select CPU_V7A
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
 	select DM_I2C
+	select DM_SERIAL
 
 config ARCH_HIGHBANK
 	bool "Calxeda Highbank"
@@ -630,14 +630,14 @@ config ARCH_INTEGRATOR
 
 config ARCH_KEYSTONE
 	bool "TI Keystone"
+	select CMD_POWEROFF
 	select CPU_V7A
 	select SUPPORT_SPL
-	select SYS_THUMB_BUILD
-	select CMD_POWEROFF
 	select SYS_ARCH_TIMER
+	select SYS_THUMB_BUILD
 	imply CMD_MTDPARTS
-	imply FIT
 	imply CMD_SAVES
+	imply FIT
 
 config ARCH_OMAP2PLUS
 	bool "TI OMAP2+"
@@ -690,12 +690,12 @@ config ARCH_MX7ULP
 
 config ARCH_MX7
 	bool "Freescale MX7"
+	select ARCH_MISC_INIT
+	select BOARD_EARLY_INIT_F
 	select CPU_V7A
 	select SYS_FSL_HAS_SEC if SECURE_BOOT
 	select SYS_FSL_SEC_COMPAT_4
 	select SYS_FSL_SEC_LE
-	select BOARD_EARLY_INIT_F
-	select ARCH_MISC_INIT
 	imply MXC_GPIO
 
 config ARCH_MX6
@@ -714,8 +714,8 @@ endif
 
 config ARCH_MX5
 	bool "Freescale MX5"
-	select CPU_V7A
 	select BOARD_EARLY_INIT_F
+	select CPU_V7A
 	imply MXC_GPIO
 
 config ARCH_OWL
@@ -734,9 +734,9 @@ config ARCH_QEMU
 
 config ARCH_RMOBILE
 	bool "Renesas ARM SoCs"
+	select BOARD_EARLY_INIT_F
 	select DM
 	select DM_SERIAL
-	select BOARD_EARLY_INIT_F
 	imply FAT_WRITE
 	imply SYS_THUMB_BUILD
 
@@ -751,30 +751,32 @@ config ARCH_SNAPDRAGON
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
-	select SPMI
+	select MSM_SMEM
 	select OF_CONTROL
 	select OF_SEPARATE
 	select SMEM
-	select MSM_SMEM
+	select SPMI
 
 config ARCH_SOCFPGA
 	bool "Altera SOCFPGA family"
 	select ARCH_EARLY_INIT_R
 	select ARCH_MISC_INIT
+	select ARM64 if TARGET_SOCFPGA_STRATIX10
 	select CPU_V7A if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
 	select DM
 	select DM_SERIAL
 	select ENABLE_ARM_SOC_BOOT0_HOOK if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
 	select OF_CONTROL
+	select SPL_DM_SERIAL
 	select SPL_LIBCOMMON_SUPPORT
 	select SPL_LIBDISK_SUPPORT
 	select SPL_LIBGENERIC_SUPPORT
 	select SPL_MMC_SUPPORT if DM_MMC
 	select SPL_NAND_SUPPORT if SPL_NAND_DENALI
 	select SPL_OF_CONTROL
-	select SPL_SERIAL_SUPPORT
-	select SPL_DM_SERIAL
 	select SPL_RESET_SUPPORT
+	select SPL_SEPARATE_BSS if TARGET_SOCFPGA_STRATIX10
+	select SPL_SERIAL_SUPPORT
 	select SPL_SPI_FLASH_SUPPORT if SPL_SPI_SUPPORT
 	select SPL_SPI_SUPPORT if DM_SPI
 	select SPL_WATCHDOG_SUPPORT
@@ -782,14 +784,12 @@ config ARCH_SOCFPGA
 	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE
 	select SYS_NS16550
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
-	select ARM64 if TARGET_SOCFPGA_STRATIX10
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
 	imply DM_SPI
 	imply DM_SPI_FLASH
 	imply FAT_WRITE
 	imply SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION
-	select SPL_SEPARATE_BSS if TARGET_SOCFPGA_STRATIX10
 
 config ARCH_SUNXI
 	bool "Support sunxi (Allwinner) SoCs"
@@ -809,12 +809,12 @@ config ARCH_SUNXI
 	select SPECIFY_CONSOLE_INDEX
 	select SPL_STACK_R if SPL
 	select SPL_SYS_MALLOC_SIMPLE if SPL
-	select SYS_NS16550
 	select SPL_SYS_THUMB_BUILD if !ARM64
+	select SYS_NS16550
 	select SYS_THUMB_BUILD if !ARM64
 	select USB if DISTRO_DEFAULTS
-	select USB_STORAGE if DISTRO_DEFAULTS
 	select USB_KEYBOARD if DISTRO_DEFAULTS
+	select USB_STORAGE if DISTRO_DEFAULTS
 	select USE_TINY_PRINTF
 	imply CMD_GPT
 	imply DISTRO_DEFAULTS
@@ -839,51 +839,51 @@ config ARCH_VF610
 
 config ARCH_ZYNQ
 	bool "Xilinx Zynq based platform"
+	select BOARD_EARLY_INIT_F if WDT
 	select BOARD_LATE_INIT
+	select CLK
+	select CLK_ZYNQ
 	select CPU_V7A
-	select SUPPORT_SPL
-	select OF_CONTROL
-	select SPL_BOARD_INIT if SPL
-	select BOARD_EARLY_INIT_F if WDT
-	select SPL_OF_CONTROL if SPL
 	select DM
 	select DM_ETH if NET
-	select SPL_DM if SPL
 	select DM_MMC if MMC
-	select DM_SPI
 	select DM_SERIAL
+	select DM_SPI
 	select DM_SPI_FLASH
-	select SPL_SEPARATE_BSS if SPL
 	select DM_USB if USB
-	select CLK
-	select SPL_CLK if SPL
-	select CLK_ZYNQ
+	select OF_CONTROL
 	select SPI
+	select SPL_BOARD_INIT if SPL
+	select SPL_CLK if SPL
+	select SPL_DM if SPL
+	select SPL_OF_CONTROL if SPL
+	select SPL_SEPARATE_BSS if SPL
+	select SUPPORT_SPL
+	imply ARCH_EARLY_INIT_R
 	imply CMD_CLK
-	imply FAT_WRITE
 	imply CMD_SPL
-	imply ARCH_EARLY_INIT_R
+	imply FAT_WRITE
 
 config ARCH_ZYNQMP_R5
 	bool "Xilinx ZynqMP R5 based platform"
+	select CLK
 	select CPU_V7R
-	select OF_CONTROL
 	select DM
 	select DM_SERIAL
-	select CLK
+	select OF_CONTROL
 
 config ARCH_ZYNQMP
 	bool "Xilinx ZynqMP based platform"
 	select ARM64
 	select BOARD_LATE_INIT
+	select CLK
 	select DM
-	select OF_CONTROL
 	select DM_SERIAL
-	select SUPPORT_SPL
-	select CLK
+	select DM_USB if USB
+	select OF_CONTROL
 	select SPL_BOARD_INIT if SPL
 	select SPL_CLK if SPL
-	select DM_USB if USB
+	select SUPPORT_SPL
 	imply FAT_WRITE
 
 config TEGRA
@@ -899,8 +899,8 @@ config TARGET_VEXPRESS64_AEMV8A
 config TARGET_VEXPRESS64_BASE_FVP
 	bool "Support Versatile Express ARMv8a FVP BASE model"
 	select ARM64
-	select SEMIHOSTING
 	select PL01X_SERIAL
+	select SEMIHOSTING
 
 config TARGET_VEXPRESS64_BASE_FVP_DRAM
 	bool "Support Versatile Express ARMv8a FVP BASE model booting from DRAM"
@@ -920,9 +920,9 @@ config TARGET_VEXPRESS64_JUNO
 config TARGET_LS2080A_EMU
 	bool "Support ls2080a_emu"
 	select ARCH_LS2080A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
-	select ARCH_MISC_INIT
 	help
 	  Support for Freescale LS2080A_EMU platform
 	  The LS2080A Development System (EMULATOR) is a pre silicon
@@ -932,9 +932,9 @@ config TARGET_LS2080A_EMU
 config TARGET_LS2080A_SIMU
 	bool "Support ls2080a_simu"
 	select ARCH_LS2080A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
-	select ARCH_MISC_INIT
 	help
 	  Support for Freescale LS2080A_SIMU platform
 	  The LS2080A Development System (QDS) is a pre silicon
@@ -944,9 +944,9 @@ config TARGET_LS2080A_SIMU
 config TARGET_LS1088AQDS
 	bool "Support ls1088aqds"
 	select ARCH_LS1088A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
-	select ARCH_MISC_INIT
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	help
@@ -958,11 +958,11 @@ config TARGET_LS1088AQDS
 config TARGET_LS2080AQDS
 	bool "Support ls2080aqds"
 	select ARCH_LS2080A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select ARCH_MISC_INIT
 	imply SCSI
 	imply SCSI_AHCI
 	help
@@ -974,11 +974,11 @@ config TARGET_LS2080AQDS
 config TARGET_LS2080ARDB
 	bool "Support ls2080ardb"
 	select ARCH_LS2080A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select ARCH_MISC_INIT
 	imply SCSI
 	imply SCSI_AHCI
 	help
@@ -990,11 +990,11 @@ config TARGET_LS2080ARDB
 config TARGET_LS2081ARDB
 	bool "Support ls2081ardb"
 	select ARCH_LS2080A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select ARCH_MISC_INIT
 	help
 	  Support for Freescale LS2081ARDB platform.
 	  The LS2081A Reference design board (RDB) is a high-performance
@@ -1018,9 +1018,9 @@ config TARGET_POPLAR
 	bool "Support Poplar 96boards Enterprise Edition Platform"
 	select ARM64
 	select DM
-	select OF_CONTROL
 	select DM_SERIAL
 	select DM_USB
+	select OF_CONTROL
 	select PL01X_SERIAL
 	  help
 	  Support for Poplar 96boards EE platform. It features a HI3798cv200
@@ -1067,8 +1067,8 @@ config TARGET_LS1012A2G5RDB
 config TARGET_LS1012AFRWY
 	bool "Support ls1012afrwy"
 	select ARCH_LS1012A
-	select BOARD_LATE_INIT
 	select ARM64
+	select BOARD_LATE_INIT
 	imply SCSI
 	imply SCSI_AHCI
 	help
@@ -1090,9 +1090,9 @@ config TARGET_LS1012AFRDM
 config TARGET_LS1088ARDB
 	bool "Support ls1088ardb"
 	select ARCH_LS1088A
+	select ARCH_MISC_INIT
 	select ARM64
 	select ARMV8_MULTIENTRY
-	select ARCH_MISC_INIT
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	help
@@ -1103,40 +1103,40 @@ config TARGET_LS1088ARDB
 
 config TARGET_LS1021AQDS
 	bool "Support ls1021aqds"
+	select ARCH_LS1021A
+	select ARCH_SUPPORT_PSCI
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select CPU_V7A
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
-	select SUPPORT_SPL
-	select ARCH_LS1021A
-	select ARCH_SUPPORT_PSCI
 	select LS1_DEEP_SLEEP
+	select SUPPORT_SPL
 	select SYS_FSL_DDR
-	select BOARD_EARLY_INIT_F
 	imply SCSI
 
 config TARGET_LS1021ATWR
 	bool "Support ls1021atwr"
+	select ARCH_LS1021A
+	select ARCH_SUPPORT_PSCI
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select CPU_V7A
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
-	select SUPPORT_SPL
-	select ARCH_LS1021A
-	select ARCH_SUPPORT_PSCI
 	select LS1_DEEP_SLEEP
-	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 	imply SCSI
 
 config TARGET_LS1021AIOT
 	bool "Support ls1021aiot"
+	select ARCH_LS1021A
+	select ARCH_SUPPORT_PSCI
 	select BOARD_LATE_INIT
 	select CPU_V7A
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
 	select SUPPORT_SPL
-	select ARCH_LS1021A
-	select ARCH_SUPPORT_PSCI
 	imply SCSI
 	help
 	  Support for Freescale LS1021AIOT platform.
@@ -1149,9 +1149,9 @@ config TARGET_LS1043AQDS
 	select ARCH_LS1043A
 	select ARM64
 	select ARMV8_MULTIENTRY
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 	imply SCSI
 	help
 	  Support for Freescale LS1043AQDS platform.
@@ -1161,9 +1161,9 @@ config TARGET_LS1043ARDB
 	select ARCH_LS1043A
 	select ARM64
 	select ARMV8_MULTIENTRY
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 	imply SCSI
 	help
 	  Support for Freescale LS1043ARDB platform.
@@ -1173,10 +1173,10 @@ config TARGET_LS1046AQDS
 	select ARCH_LS1046A
 	select ARM64
 	select ARMV8_MULTIENTRY
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM_SPI_FLASH if DM_SPI
-	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 	imply SCSI
 	help
 	  Support for Freescale LS1046AQDS platform.
@@ -1189,11 +1189,11 @@ config TARGET_LS1046ARDB
 	select ARCH_LS1046A
 	select ARM64
 	select ARMV8_MULTIENTRY
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM_SPI_FLASH if DM_SPI
 	select POWER_MC34VR500
-	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 	imply SCSI
 	help
 	  Support for Freescale LS1046ARDB platform.
@@ -1247,12 +1247,12 @@ config STM32
 
 config ARCH_STI
 	bool "Support STMicrolectronics SoCs"
+	select BLK
 	select CPU_V7A
 	select DM
-	select DM_SERIAL
-	select BLK
 	select DM_MMC
 	select DM_RESET
+	select DM_SERIAL
 	help
 	  Support for STMicroelectronics STiH407/10 SoC family.
 	  This SoC is used on Linaro 96Board STiH410-B2260
@@ -1266,9 +1266,9 @@ config ARCH_STM32MP
 	select DM_GPIO
 	select DM_RESET
 	select DM_SERIAL
+	select MISC
 	select OF_CONTROL
 	select OF_LIBFDT
-	select MISC
 	select PINCTRL
 	select REGMAP
 	select SUPPORT_SPL
@@ -1283,44 +1283,44 @@ config ARCH_STM32MP
 
 config ARCH_ROCKCHIP
 	bool "Support Rockchip SoCs"
-	select OF_CONTROL
 	select BLK
 	select DM
-	select SPL_DM if SPL
-	select SYS_MALLOC_F
-	select SYS_THUMB_BUILD if !ARM64
-	select SPL_SYS_MALLOC_SIMPLE if SPL
 	select DM_GPIO
 	select DM_I2C
 	select DM_MMC
+	select DM_PWM
+	select DM_REGULATOR
 	select DM_SERIAL
 	select DM_SPI
 	select DM_SPI_FLASH
 	select DM_USB if USB
-	select DM_PWM
-	select DM_REGULATOR
 	select ENABLE_ARM_SOC_BOOT0_HOOK
+	select OF_CONTROL
 	select SPI
+	select SPL_DM if SPL
+	select SPL_SYS_MALLOC_SIMPLE if SPL
+	select SYS_MALLOC_F
+	select SYS_THUMB_BUILD if !ARM64
+	imply ADC
 	imply DISTRO_DEFAULTS
 	imply FAT_WRITE
-	imply USB_FUNCTION_FASTBOOT
-	imply SPL_SYSRESET
-	imply TPL_SYSRESET
-	imply ADC
 	imply SARADC_ROCKCHIP
+	imply SPL_SYSRESET
 	imply SYS_NS16550
+	imply TPL_SYSRESET
+	imply USB_FUNCTION_FASTBOOT
 
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"
 	select ARM64
 	select OF_CONTROL
-	select SYS_CACHE_SHIFT_7
 	select PL01X_SERIAL
+	select SYS_CACHE_SHIFT_7
 
 config ARCH_ASPEED
 	bool "Support Aspeed SoCs"
-	select OF_CONTROL
 	select DM
+	select OF_CONTROL
 
 endchoice
 
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index ce6be3829afe..1a56957cf9d1 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -76,18 +76,18 @@ config TARGET_SNAPPER9260
 	bool "Support snapper9260"
 	select AT91SAM9260
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_GURNARD
 	bool "Support gurnard"
 	select AT91SAM9G45
 	select BOARD_LATE_INIT
 	select DM
+	select DM_ETH
+	select DM_GPIO
 	select DM_SERIAL
 	select DM_SPI
-	select DM_GPIO
-	select DM_ETH
 	select SPI
 
 config TARGET_AT91SAM9261EK
@@ -115,8 +115,8 @@ config TARGET_PM9263
 config TARGET_AT91SAM9M10G45EK
 	bool "Atmel AT91SAM9M10G45-EK board"
 	select AT91SAM9M10G45
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 
 config TARGET_PM9G45
 	bool "Ronetix pm9g45 board"
@@ -130,8 +130,8 @@ config TARGET_PICOSAM9G45
 config TARGET_AT91SAM9N12EK
 	bool "Atmel AT91SAM9N12-EK board"
 	select AT91SAM9N12
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 
 config TARGET_AT91SAM9RLEK
 	bool "Atmel at91sam9rl reference board"
@@ -141,28 +141,28 @@ config TARGET_AT91SAM9RLEK
 config TARGET_AT91SAM9X5EK
 	bool "Atmel AT91SAM9X5-EK board"
 	select AT91SAM9X5
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SUPPORT_SPL
 
 config TARGET_SAMA5D2_PTC_EK
 	bool "SAMA5D2 PTC EK board"
-	select SAMA5D2
 	select BOARD_EARLY_INIT_F
+	select SAMA5D2
 
 config TARGET_SAMA5D2_XPLAINED
 	bool "SAMA5D2 Xplained board"
-	select SAMA5D2
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SAMA5D2
+	select SUPPORT_SPL
 
 config TARGET_SAMA5D27_SOM1_EK
 	bool "SAMA5D27 SOM1 EK board"
-	select CPU_V7A
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select CPU_V7A
+	select SUPPORT_SPL
 	help
 	  The SAMA5D27 SOM1 embeds SAMA5D2 SiP(System in Package),
 	  a 64Mbit QSPI flash, KSZ8081 Phy and a Mac-address EEPROM
@@ -172,30 +172,30 @@ config TARGET_SAMA5D27_SOM1_EK
 
 config TARGET_SAMA5D3_XPLAINED
 	bool "SAMA5D3 Xplained board"
+	select BOARD_EARLY_INIT_F
 	select SAMA5D3
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 
 config TARGET_SAMA5D3XEK
 	bool "SAMA5D3X-EK board"
-	select SAMA5D3
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SAMA5D3
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 
 config TARGET_SAMA5D4_XPLAINED
 	bool "SAMA5D4 Xplained board"
-	select SAMA5D4
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SAMA5D4
+	select SUPPORT_SPL
 
 config TARGET_SAMA5D4EK
 	bool "SAMA5D4 Evaluation Kit"
-	select SAMA5D4
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
+	select SAMA5D4
+	select SUPPORT_SPL
 
 config TARGET_MEESC
 	bool "Support meesc"
@@ -204,39 +204,39 @@ config TARGET_MEESC
 config TARGET_CORVUS
 	bool "Support corvus"
 	select AT91SAM9M10G45
-	select SUPPORT_SPL
 	select DM
-	select DM_SERIAL
-	select DM_GPIO
 	select DM_ETH
+	select DM_GPIO
+	select DM_SERIAL
+	select SUPPORT_SPL
 
 config TARGET_TAURUS
 	bool "Support taurus"
 	select AT91SAM9G20
-	select SUPPORT_SPL
 	select DM
+	select DM_ETH
+	select DM_GPIO
 	select DM_SERIAL
 	select DM_SPI
-	select DM_GPIO
-	select DM_ETH
 	select SPI
+	select SUPPORT_SPL
 
 config TARGET_SMARTWEB
 	bool "Support smartweb"
 	select AT91SAM9260
-	select SUPPORT_SPL
 	select DM
-	select DM_SERIAL
-	select DM_GPIO
 	select DM_ETH
+	select DM_GPIO
+	select DM_SERIAL
+	select SUPPORT_SPL
 
 config TARGET_VINCO
 	bool "Support VINCO"
-	select SAMA5D4
-	select SUPPORT_SPL
 	select DM
 	select DM_SPI
+	select SAMA5D4
 	select SPI
+	select SUPPORT_SPL
 
 config TARGET_WB45N
 	bool "Support Laird WB45N"
@@ -245,10 +245,10 @@ config TARGET_WB45N
 
 config TARGET_WB50N
 	bool "Support Laird WB50N"
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select CPU_V7A
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 
 endchoice
 
diff --git a/arch/arm/mach-imx/mx5/Kconfig b/arch/arm/mach-imx/mx5/Kconfig
index 3654670442fb..1bb373bf2d1c 100644
--- a/arch/arm/mach-imx/mx5/Kconfig
+++ b/arch/arm/mach-imx/mx5/Kconfig
@@ -1,14 +1,14 @@
 if ARCH_MX5
 
 config MX5
-	select GPT_TIMER
 	bool
 	default y
+	select GPT_TIMER
 
 config MX51
 	bool
-	select SYS_FSL_ERRATUM_ESDHC_A001
 	select ARM_CORTEX_A8_CVE_2017_5715
+	select SYS_FSL_ERRATUM_ESDHC_A001
 
 config MX53
 	bool
@@ -21,13 +21,13 @@ choice
 config TARGET_KP_IMX53
 	bool "Support K+P imx53 board"
 	select BOARD_LATE_INIT
-	select MX53
 	select DM
-	select DM_SERIAL
 	select DM_ETH
-	select DM_I2C
 	select DM_GPIO
+	select DM_I2C
 	select DM_PMIC
+	select DM_SERIAL
+	select MX53
 
 config TARGET_MX51EVK
 	bool "Support mx51evk"
@@ -41,9 +41,9 @@ config TARGET_MX53ARD
 config TARGET_MX53CX9020
 	bool "Support CX9020"
 	select BOARD_LATE_INIT
-	select MX53
 	select DM
 	select DM_SERIAL
+	select MX53
 
 config TARGET_MX53EVK
 	bool "Support mx53evk"
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
index b7b77cc51b97..5cce9ce23c0e 100644
--- a/arch/arm/mach-imx/mx6/Kconfig
+++ b/arch/arm/mach-imx/mx6/Kconfig
@@ -1,89 +1,89 @@
 if ARCH_MX6
 
 config MX6_SMP
+	bool
 	select ARM_ERRATA_751472
 	select ARM_ERRATA_761320
 	select ARM_ERRATA_794072
 	select ARM_ERRATA_845369
 	select MP
-	bool
 
 config MX6
-	select ARM_ERRATA_743622 if !MX6UL && !MX6ULL
-	select GPT_TIMER if !MX6UL && !MX6ULL
 	bool
 	default y
+	select ARM_ERRATA_743622 if !MX6UL && !MX6ULL
+	select GPT_TIMER if !MX6UL && !MX6ULL
 	imply CMD_FUSE
 
 config MX6D
+	bool
 	select HAS_CAAM
 	select MX6_SMP
-	bool
 
 config MX6DL
+	bool
 	select HAS_CAAM
 	select MX6_SMP
-	bool
 
 config MX6Q
+	bool
 	select HAS_CAAM
 	select MX6_SMP
-	bool
 
 config MX6QDL
+	bool
 	select HAS_CAAM
 	select MX6_SMP
-	bool
 
 config MX6S
-	select HAS_CAAM
 	bool
+	select HAS_CAAM
 
 config MX6SL
 	bool
 
 config MX6SX
+	bool
 	select HAS_CAAM
 	select ROM_UNIFIED_SECTIONS
-	bool
 
 config MX6SLL
-	select ROM_UNIFIED_SECTIONS
 	bool
+	select ROM_UNIFIED_SECTIONS
 
 config MX6UL
+	bool
 	select HAS_CAAM
-	select SYS_L2CACHE_OFF
 	select ROM_UNIFIED_SECTIONS
 	select SYSCOUNTER_TIMER
-	bool
+	select SYS_L2CACHE_OFF
 
 config MX6UL_LITESOM
 	bool
-	select MX6UL
 	select DM
 	select DM_THERMAL
+	select MX6UL
 	select SUPPORT_SPL
 
 config MX6UL_OPOS6UL
 	bool
-	select MX6UL
 	select BOARD_LATE_INIT
 	select DM
 	select DM_GPIO
 	select DM_MMC
 	select DM_THERMAL
-	select SUPPORT_SPL
+	select MX6UL
 	select SPL_DM if SPL
 	select SPL_OF_CONTROL if SPL
-	select SPL_SEPARATE_BSS if SPL
 	select SPL_PINCTRL if SPL
+	select SPL_SEPARATE_BSS if SPL
+	select SUPPORT_SPL
 
 config MX6ULL
-	select SYS_L2CACHE_OFF
+	bool
 	select ROM_UNIFIED_SECTIONS
 	select SYSCOUNTER_TIMER
-	bool
+	select SYS_L2CACHE_OFF
 
 config MX6_DDRCAL
 	bool "Include dynamic DDR calibration routines"
@@ -106,10 +106,10 @@ config TARGET_ADVANTECH_DMS_BA16
 config TARGET_APALIS_IMX6
 	bool "Toradex Apalis iMX6 board"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_SERIAL
 	select DM_THERMAL
+	select SUPPORT_SPL
 	imply CMD_SATA
 
 config TARGET_ARISTAINETOS
@@ -125,44 +125,44 @@ config TARGET_ARISTAINETOS2B
 
 config TARGET_CGTQMX6EVAL
 	bool "cgtqmx6eval"
-	select MX6QDL
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
+	select MX6QDL
+	select SUPPORT_SPL
 
 config TARGET_CM_FX6
 	bool "CM-FX6"
-	select SUPPORT_SPL
-	select MX6QDL
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
+	select MX6QDL
+	select SUPPORT_SPL
 
 config TARGET_COLIBRI_IMX6
 	bool "Toradex Colibri iMX6 board"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_SERIAL
 	select DM_THERMAL
+	select SUPPORT_SPL
 
 config TARGET_DHCOMIMX6
 	bool "dh_imx6"
-	select MX6QDL
-	select BOARD_LATE_INIT
 	select BOARD_EARLY_INIT_F
-	select SUPPORT_SPL
+	select BOARD_LATE_INIT
 	select DM
 	select DM_THERMAL
+	select MX6QDL
+	select SUPPORT_SPL
 	imply CMD_SPL
 
 config TARGET_DISPLAY5
 	bool "LWN DISPLAY5 board"
-	select SUPPORT_SPL
 	select DM
 	select DM_SERIAL
+	select SUPPORT_SPL
 
 config TARGET_EMBESTMX6BOARDS
 	bool "embestmx6boards"
@@ -192,8 +192,8 @@ config TARGET_MCCMON6
 
 config TARGET_MX6CUBOXI
 	bool "Solid-run mx6 boards"
-	select MX6QDL
 	select BOARD_LATE_INIT
+	select MX6QDL
 	select SUPPORT_SPL
 
 config TARGET_MX6LOGICPD
@@ -222,9 +222,6 @@ config TARGET_MX6QARM2
 
 config TARGET_MX6DL_MAMOJ
 	bool "Support BTicino Mamoj"
-	select MX6QDL
-	select OF_CONTROL
-	select PINCTRL
 	select DM
 	select DM_ETH
 	select DM_GPIO
@@ -233,59 +230,62 @@ config TARGET_MX6DL_MAMOJ
 	select DM_PMIC
 	select DM_PMIC_PFUZE100
 	select DM_THERMAL
+	select MX6QDL
+	select OF_CONTROL
+	select PINCTRL
 	select SPL
-	select SUPPORT_SPL
 	select SPL_DM if SPL
-	select SPL_OF_LIBFDT if SPL
-	select SPL_OF_CONTROL if SPL
-	select SPL_PINCTRL if SPL
-	select SPL_SEPARATE_BSS if SPL
 	select SPL_GPIO_SUPPORT if SPL
 	select SPL_LIBCOMMON_SUPPORT if SPL
 	select SPL_LIBDISK_SUPPORT if SPL
 	select SPL_LIBGENERIC_SUPPORT if SPL
 	select SPL_MMC_SUPPORT if SPL
+	select SPL_OF_CONTROL if SPL
+	select SPL_OF_LIBFDT if SPL
+	select SPL_PINCTRL if SPL
+	select SPL_SEPARATE_BSS if SPL
 	select SPL_SERIAL_SUPPORT if SPL
-	select SPL_USB_HOST_SUPPORT if SPL
 	select SPL_USB_GADGET_SUPPORT if SPL
+	select SPL_USB_HOST_SUPPORT if SPL
 	select SPL_USB_SDP_SUPPORT if SPL
 	select SPL_WATCHDOG_SUPPORT if SPL
+	select SUPPORT_SPL
 
 config TARGET_MX6Q_ENGICAM
 	bool "Support Engicam i.Core(RQS)"
 	select BOARD_LATE_INIT
-	select MX6QDL
-	select OF_CONTROL
-	select SPL_OF_LIBFDT
 	select DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
 	select DM_MMC
 	select DM_THERMAL
-	select SUPPORT_SPL
+	select MX6QDL
+	select OF_CONTROL
 	select SPL_DM if SPL
 	select SPL_OF_CONTROL if SPL
-	select SPL_SEPARATE_BSS if SPL
+	select SPL_OF_LIBFDT
 	select SPL_PINCTRL if SPL
+	select SPL_SEPARATE_BSS if SPL
+	select SUPPORT_SPL
 
 config TARGET_MX6SABREAUTO
 	bool "mx6sabreauto"
-	select MX6QDL
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
-	select BOARD_EARLY_INIT_F
+	select MX6QDL
+	select SUPPORT_SPL
 
 config TARGET_MX6SABRESD
 	bool "mx6sabresd"
-	select MX6QDL
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
-	select BOARD_EARLY_INIT_F
+	select MX6QDL
+	select SUPPORT_SPL
 
 config TARGET_MX6SLEVK
 	bool "mx6slevk"
@@ -295,73 +295,73 @@ config TARGET_MX6SLEVK
 config TARGET_MX6SLLEVK
 	bool "mx6sll evk"
 	select BOARD_LATE_INIT
-	select MX6SLL
 	select DM
 	select DM_THERMAL
+	select MX6SLL
 
 config TARGET_MX6SXSABRESD
 	bool "mx6sxsabresd"
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select MX6SX
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
-	select BOARD_EARLY_INIT_F
+	select MX6SX
+	select SUPPORT_SPL
 
 config TARGET_MX6SXSABREAUTO
 	bool "mx6sxsabreauto"
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
-	select MX6SX
 	select DM
 	select DM_THERMAL
-	select BOARD_EARLY_INIT_F
+	select MX6SX
 
 config TARGET_MX6UL_9X9_EVK
 	bool "mx6ul_9x9_evk"
 	select BOARD_LATE_INIT
-	select MX6UL
 	select DM
 	select DM_THERMAL
+	select MX6UL
 	select SUPPORT_SPL
 
 config TARGET_MX6UL_14X14_EVK
-	select BOARD_LATE_INIT
 	bool "mx6ul_14x14_evk"
-	select MX6UL
+	select BOARD_LATE_INIT
 	select DM
 	select DM_THERMAL
+	select MX6UL
 	select SUPPORT_SPL
 
 config TARGET_MX6UL_ENGICAM
 	bool "Support Engicam GEAM6UL/Is.IoT"
 	select BOARD_LATE_INIT
-	select MX6UL
-	select OF_CONTROL
 	select DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
 	select DM_MMC
 	select DM_THERMAL
-	select SUPPORT_SPL
+	select MX6UL
+	select OF_CONTROL
 	select SPL_DM if SPL
 	select SPL_OF_CONTROL if SPL
-	select SPL_SEPARATE_BSS if SPL
 	select SPL_PINCTRL if SPL
+	select SPL_SEPARATE_BSS if SPL
+	select SUPPORT_SPL
 
 config TARGET_MX6ULL_14X14_EVK
 	bool "Support mx6ull_14x14_evk"
 	select BOARD_LATE_INIT
-	select MX6ULL
 	select DM
 	select DM_THERMAL
+	select MX6ULL
 
 config TARGET_NITROGEN6X
 	bool "nitrogen6x"
-	imply USB_HOST_ETHER
 	imply USB_ETHER_ASIX
-	imply USB_ETHER_SMSC95XX
 	imply USB_ETHER_MCS7830
+	imply USB_ETHER_SMSC95XX
+	imply USB_HOST_ETHER
 
 config TARGET_OPOS6ULDEV
 	bool "Armadeus OPOS6ULDev board"
@@ -396,8 +396,8 @@ config TARGET_PCM058
 
 config TARGET_PFLA02
 	bool "Phytec PFLA02 (PhyFlex) i.MX6 Quad"
-	select MX6QDL
 	select BOARD_LATE_INIT
+	select MX6QDL
 	select SUPPORT_SPL
 
 config TARGET_SECOMX6
@@ -415,12 +415,12 @@ config TARGET_TITANIUM
 
 config TARGET_KP_IMX6Q_TPC
 	bool "K+P KP_IMX6Q_TPC i.MX6 Quad"
-	select MX6QDL
-	select BOARD_LATE_INIT
 	select BOARD_EARLY_INIT_F
-	select SUPPORT_SPL
+	select BOARD_LATE_INIT
 	select DM
 	select DM_THERMAL
+	select MX6QDL
+	select SUPPORT_SPL
 	imply CMD_SPL
 
 config TARGET_TQMA6
@@ -429,57 +429,57 @@ config TARGET_TQMA6
 
 config TARGET_UDOO
 	bool "udoo"
-	select MX6QDL
 	select BOARD_LATE_INIT
+	select MX6QDL
 	select SUPPORT_SPL
 
 config TARGET_UDOO_NEO
 	bool "UDOO Neo"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
-	select MX6SX
 	select DM
 	select DM_THERMAL
+	select MX6SX
+	select SUPPORT_SPL
 
 config TARGET_SAMTEC_VINING_2000
 	bool "samtec VIN|ING 2000"
 	select BOARD_LATE_INIT
-	select MX6SX
 	select DM
 	select DM_THERMAL
+	select MX6SX
 
 config TARGET_WANDBOARD
 	bool "wandboard"
-	select MX6QDL
 	select BOARD_LATE_INIT
+	select MX6QDL
 	select SUPPORT_SPL
 
 config TARGET_WARP
 	bool "WaRP"
-	select MX6SL
 	select BOARD_LATE_INIT
+	select MX6SL
 
 config TARGET_XPRESS
 	bool "CCV xPress"
 	select BOARD_LATE_INIT
-	select MX6UL
 	select DM
 	select DM_THERMAL
+	select MX6UL
 	select SUPPORT_SPL
 
 config TARGET_ZC5202
 	bool "zc5202"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
+	select SUPPORT_SPL
 
 config TARGET_ZC5601
 	bool "zc5601"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
 	select DM
 	select DM_THERMAL
+	select SUPPORT_SPL
 
 endchoice
 
diff --git a/arch/arm/mach-imx/mx7/Kconfig b/arch/arm/mach-imx/mx7/Kconfig
index 2a3db860bbcf..f618a7bb9d1f 100644
--- a/arch/arm/mach-imx/mx7/Kconfig
+++ b/arch/arm/mach-imx/mx7/Kconfig
@@ -2,19 +2,19 @@ if ARCH_MX7
 
 config MX7
 	bool
+	default y
+	select ARCH_SUPPORT_PSCI
+	select CPU_V7_HAS_NONSEC
+	select CPU_V7_HAS_VIRT
 	select ROM_UNIFIED_SECTIONS
 	select SYSCOUNTER_TIMER
-	select CPU_V7_HAS_VIRT
-	select CPU_V7_HAS_NONSEC
-	select ARCH_SUPPORT_PSCI
 	imply CMD_FUSE
-	default y
 
 config MX7D
+	bool
 	select HAS_CAAM
 	select ROM_UNIFIED_SECTIONS
 	imply CMD_FUSE
-	bool
 
 choice
 	prompt "MX7 board select"
@@ -22,31 +22,31 @@ choice
 
 config TARGET_CL_SOM_IMX7
 	bool "CL-SOM-iMX7"
-	select MX7D
 	select DM
 	select DM_THERMAL
+	select MX7D
 	select SUPPORT_SPL
 
 config TARGET_MX7DSABRESD
 	bool "mx7dsabresd"
 	select BOARD_LATE_INIT
-	select MX7D
 	select DM
 	select DM_THERMAL
+	select MX7D
 
 config TARGET_PICO_IMX7D
 	bool "pico-imx7d"
 	select BOARD_LATE_INIT
-	select MX7D
 	select DM
 	select DM_THERMAL
+	select MX7D
 
 config TARGET_WARP7
 	bool "warp7"
 	select BOARD_LATE_INIT
-	select MX7D
 	select DM
 	select DM_THERMAL
+	select MX7D
 
 config TARGET_COLIBRI_IMX7
 	bool "Support Colibri iMX7S/iMX7D modules"
diff --git a/arch/arm/mach-omap2/am33xx/Kconfig b/arch/arm/mach-omap2/am33xx/Kconfig
index 76da6d911ed6..94d9d868f893 100644
--- a/arch/arm/mach-omap2/am33xx/Kconfig
+++ b/arch/arm/mach-omap2/am33xx/Kconfig
@@ -31,9 +31,11 @@ config TARGET_AM335X_EVM
 	bool "Support am335x_evm"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select TI_I2C_BOARD_DETECT
+	imply SPL_DM
+	imply SPL_DM_SEQ_ALIAS
 	imply SPL_ENV_SUPPORT
 	imply SPL_EXT_SUPPORT
 	imply SPL_FAT_SUPPORT
@@ -44,15 +46,13 @@ config TARGET_AM335X_EVM
 	imply SPL_LIBGENERIC_SUPPORT
 	imply SPL_MMC_SUPPORT
 	imply SPL_NAND_SUPPORT
+	imply SPL_OF_LIBFDT
 	imply SPL_POWER_SUPPORT
+	imply SPL_SEPARATE_BSS
 	imply SPL_SERIAL_SUPPORT
+	imply SPL_SYS_MALLOC_SIMPLE
 	imply SPL_WATCHDOG_SUPPORT
 	imply SPL_YMODEM_SUPPORT
-	imply SPL_SYS_MALLOC_SIMPLE
-	imply SPL_SEPARATE_BSS
-	imply SPL_DM
-	imply SPL_DM_SEQ_ALIAS
-	imply SPL_OF_LIBFDT
 	help
 	  This option specifies support for the AM335x
 	  GP and HS EVM development platforms. The AM335x
@@ -65,30 +65,30 @@ config TARGET_AM335X_BALTOS
 	bool "Support am335x_baltos"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_AM335X_IGEP003X
 	bool "Support am335x_igep003x"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_AM335X_SHC
 	bool "Support am335x based shc board from bosch"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	imply CMD_SPL
 
 config TARGET_AM335X_SL50
 	bool "Support am335x_sl50"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_BAV335X
 	bool "Support bav335x"
@@ -122,68 +122,68 @@ config TARGET_CHILIBOARD
 config TARGET_CM_T335
 	bool "Support cm_t335"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_DRACO
 	bool "Support draco"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_ETAMIN
 	bool "Support etamin"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_PCM051
 	bool "Support pcm051"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_PENGWYN
 	bool "Support pengwyn"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_PEPPER
 	bool "Support pepper"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_PXM2
 	bool "Support pxm2"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_RASTABAN
 	bool "Support rastaban"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_RUT
 	bool "Support rut"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_THUBAN
 	bool "Support thuban"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_PDU001
 	bool "Support PDU001"
@@ -258,6 +258,8 @@ endif
 if AM43XX || AM33XX
 config ISW_ENTRY_ADDR
 	hex "Address in memory or XIP flash of bootloader entry point"
+	default 0x402F4000 if AM43XX
+	default 0x402F0400 if AM33XX
 	help
 	  After any reset, the boot ROM on the AM43XX SOC
 	  searches the boot media for a valid boot image.
@@ -268,11 +270,10 @@ config ISW_ENTRY_ADDR
 	  point address depending on the device type
 	  (secure/non-secure), boot media (xip/non-xip) and
 	  image headers.
-	default 0x402F4000 if AM43XX
-	default 0x402F0400 if AM33XX
 
 config PUB_ROM_DATA_SIZE
 	hex "Size in bytes of the L3 SRAM reserved by ROM to store data"
+	default 0x8400
 	help
 	  During the device boot, the public ROM uses the top of
 	  the public L3 OCMC RAM to store r/w data like stack,
@@ -283,5 +284,4 @@ config PUB_ROM_DATA_SIZE
 	  boot image. Once the ROM transfers control to the boot
 	  image, this area is no longer used, and can be reclaimed
 	  for run time use by the boot image.
-	default 0x8400
 endif
diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/omap3/Kconfig
index 6d714f6cdb2c..9e4227d8266b 100644
--- a/arch/arm/mach-omap2/omap3/Kconfig
+++ b/arch/arm/mach-omap2/omap3/Kconfig
@@ -23,10 +23,10 @@ choice
 config TARGET_AM3517_EVM
 	bool "AM3517 EVM"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
 	select DM_I2C
 	select DM_MMC
+	select DM_SERIAL
 
 config TARGET_MT_VENTOUX
 	bool "TeeJet Mt.Ventoux"
@@ -36,8 +36,8 @@ config TARGET_MT_VENTOUX
 config TARGET_OMAP3_BEAGLE
 	bool "TI OMAP3 BeagleBoard"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
 
@@ -56,21 +56,21 @@ config TARGET_CM_T3517
 config TARGET_DEVKIT8000
 	bool "TimLL OMAP3 Devkit8000"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_OMAP3_EVM
 	bool "TI OMAP3 EVM"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_3
 
 config TARGET_OMAP3_IGEP00X0
 	bool "IGEP"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
@@ -78,8 +78,8 @@ config TARGET_OMAP3_IGEP00X0
 config TARGET_OMAP3_OVERO
 	bool "OMAP35xx Gumstix Overo"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_2
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_4
@@ -89,8 +89,8 @@ config TARGET_OMAP3_OVERO
 config TARGET_OMAP3_ZOOM1
 	bool "TI Zoom1"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_AM3517_CRANE
 	bool "am3517_crane"
@@ -118,8 +118,8 @@ config TARGET_OMAP3_LOGIC
 	bool "OMAP3 Logic"
 	select BOARD_LATE_INIT
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_4
 	select OMAP3_GPIO_6
@@ -143,14 +143,14 @@ config TARGET_TWISTER
 config TARGET_OMAP3_CAIRO
 	bool "QUIPOS CAIRO"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 
 config TARGET_SNIPER
 	bool "LG Optimus Black"
 	select DM
-	select DM_SERIAL
 	select DM_GPIO
+	select DM_SERIAL
 	select OMAP3_GPIO_2
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_4
diff --git a/arch/arm/mach-rmobile/Kconfig.32 b/arch/arm/mach-rmobile/Kconfig.32
index c0b5b2457cb1..dc517350ee19 100644
--- a/arch/arm/mach-rmobile/Kconfig.32
+++ b/arch/arm/mach-rmobile/Kconfig.32
@@ -47,25 +47,25 @@ config TARGET_GOSE
 	bool "Gose board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_KOELSCH
 	bool "Koelsch board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_LAGER
 	bool "Lager board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_KZM9G
 	bool "KZM9D board"
@@ -74,33 +74,33 @@ config TARGET_ALT
 	bool "Alt board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_SILK
 	bool "Silk board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_PORTER
 	bool "Porter board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 config TARGET_STOUT
 	bool "Stout board"
 	select DM
 	select DM_SERIAL
+	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
-	select SPL_TINY_MEMSET
 
 endchoice
 
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 0fb0c6339018..cd03705b64c0 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -22,6 +22,8 @@ config TEGRA_IVC
 
 config TEGRA_COMMON
 	bool "Tegra common options"
+	select BINMAN
+	select BOARD_EARLY_INIT_F
 	select CLK
 	select DM
 	select DM_ETH
@@ -35,11 +37,9 @@ config TEGRA_COMMON
 	select DM_SPI
 	select DM_SPI_FLASH
 	select MISC
-	select SPI
 	select OF_CONTROL
+	select SPI
 	select VIDCONSOLE_AS_LCD if DM_VIDEO
-	select BOARD_EARLY_INIT_F
-	select BINMAN
 	imply CRC32_VERIFY
 
 config TEGRA_NO_BPMP
@@ -98,8 +98,8 @@ config TEGRA124
 
 config TEGRA210
 	bool "Tegra210 family"
-	select TEGRA_GPIO
 	select TEGRA_ARMV8_COMMON
+	select TEGRA_GPIO
 	select TEGRA_NO_BPMP
 
 config TEGRA186
diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
index c56459345136..1df1ecf72d19 100644
--- a/arch/microblaze/Kconfig
+++ b/arch/microblaze/Kconfig
@@ -11,10 +11,10 @@ choice
 config TARGET_MICROBLAZE_GENERIC
 	bool "Support microblaze-generic"
 	select BOARD_LATE_INIT
-	select SUPPORT_SPL
-	select OF_CONTROL
 	select DM
 	select DM_SERIAL
+	select OF_CONTROL
+	select SUPPORT_SPL
 	select SYSRESET
 
 endchoice
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d07b92d1b442..315d89dbeb3f 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -14,13 +14,13 @@ choice
 
 config TARGET_QEMU_MIPS
 	bool "Support qemu-mips"
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
-	select SUPPORTS_LITTLE_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SUPPORTS_CPU_MIPS64_R1
 	select SUPPORTS_CPU_MIPS64_R2
-	select ROM_EXCEPTION_VECTORS
+	select SUPPORTS_LITTLE_ENDIAN
 
 config TARGET_MALTA
 	bool "Support malta"
@@ -28,98 +28,98 @@ config TARGET_MALTA
 	select DM_SERIAL
 	select DYNAMIC_IO_PORT_BASE
 	select MIPS_CM
+	select MIPS_L1_CACHE_SHIFT_6
 	select MIPS_L2_CACHE
 	select OF_CONTROL
 	select OF_ISA_BUS
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
-	select SUPPORTS_LITTLE_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SUPPORTS_CPU_MIPS32_R6
 	select SUPPORTS_CPU_MIPS64_R1
 	select SUPPORTS_CPU_MIPS64_R2
 	select SUPPORTS_CPU_MIPS64_R6
+	select SUPPORTS_LITTLE_ENDIAN
 	select SWAP_IO_SPACE
-	select MIPS_L1_CACHE_SHIFT_6
-	select ROM_EXCEPTION_VECTORS
 
 config TARGET_VCT
 	bool "Support vct"
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SYS_MIPS_CACHE_INIT_RAM_LOAD
-	select ROM_EXCEPTION_VECTORS
 
 config TARGET_DBAU1X00
 	bool "Support dbau1x00"
+	select MIPS_TUNE_4KC
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
-	select SUPPORTS_LITTLE_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
+	select SUPPORTS_LITTLE_ENDIAN
 	select SYS_MIPS_CACHE_INIT_RAM_LOAD
-	select ROM_EXCEPTION_VECTORS
-	select MIPS_TUNE_4KC
 
 config TARGET_PB1X00
 	bool "Support pb1x00"
-	select SUPPORTS_LITTLE_ENDIAN
+	select MIPS_TUNE_4KC
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
+	select SUPPORTS_LITTLE_ENDIAN
 	select SYS_MIPS_CACHE_INIT_RAM_LOAD
-	select ROM_EXCEPTION_VECTORS
-	select MIPS_TUNE_4KC
 
 config ARCH_ATH79
 	bool "Support QCA/Atheros ath79"
-	select OF_CONTROL
 	select DM
+	select OF_CONTROL
 
 config ARCH_BMIPS
 	bool "Support BMIPS SoCs"
-	select OF_CONTROL
-	select DM
 	select CLK
 	select CPU
+	select DM
+	select OF_CONTROL
 	select RAM
 	select SYSRESET
 
 config MACH_PIC32
 	bool "Support Microchip PIC32"
-	select OF_CONTROL
 	select DM
+	select OF_CONTROL
 
 config TARGET_BOSTON
 	bool "Support Boston"
 	select DM
 	select DM_SERIAL
-	select OF_CONTROL
 	select MIPS_CM
 	select MIPS_L1_CACHE_SHIFT_6
 	select MIPS_L2_CACHE
 	select OF_BOARD_SETUP
+	select OF_CONTROL
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
-	select SUPPORTS_LITTLE_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SUPPORTS_CPU_MIPS32_R6
 	select SUPPORTS_CPU_MIPS64_R1
 	select SUPPORTS_CPU_MIPS64_R2
 	select SUPPORTS_CPU_MIPS64_R6
-	select ROM_EXCEPTION_VECTORS
+	select SUPPORTS_LITTLE_ENDIAN
 
 config TARGET_XILFPGA
 	bool "Support Imagination Xilfpga"
-	select OF_CONTROL
 	select DM
-	select DM_SERIAL
-	select DM_GPIO
 	select DM_ETH
-	select SUPPORTS_LITTLE_ENDIAN
-	select SUPPORTS_CPU_MIPS32_R1
-	select SUPPORTS_CPU_MIPS32_R2
+	select DM_GPIO
+	select DM_SERIAL
 	select MIPS_L1_CACHE_SHIFT_4
+	select OF_CONTROL
 	select ROM_EXCEPTION_VECTORS
+	select SUPPORTS_CPU_MIPS32_R1
+	select SUPPORTS_CPU_MIPS32_R2
+	select SUPPORTS_LITTLE_ENDIAN
 	help
 	  This supports IMGTEC MIPSfpga platform
 
diff --git a/arch/powerpc/cpu/mpc83xx/Kconfig b/arch/powerpc/cpu/mpc83xx/Kconfig
index 05d29d2fd95f..385a7a6e2172 100644
--- a/arch/powerpc/cpu/mpc83xx/Kconfig
+++ b/arch/powerpc/cpu/mpc83xx/Kconfig
@@ -26,8 +26,8 @@ config TARGET_MPC8308RDB
 
 config TARGET_MPC8313ERDB
 	bool "Support MPC8313ERDB"
-	select SUPPORT_SPL
 	select BOARD_EARLY_INIT_F
+	select SUPPORT_SPL
 
 config TARGET_MPC8315ERDB
 	bool "Support MPC8315ERDB"
@@ -42,10 +42,10 @@ config TARGET_MPC832XEMDS
 
 config TARGET_MPC8349EMDS
 	bool "Support MPC8349EMDS"
+	select BOARD_EARLY_INIT_F
 	select SYS_FSL_DDR
-	select SYS_FSL_HAS_DDR2
 	select SYS_FSL_DDR_BE
-	select BOARD_EARLY_INIT_F
+	select SYS_FSL_HAS_DDR2
 
 config TARGET_MPC8349ITX
 	bool "Support MPC8349ITX"
diff --git a/cmd/Kconfig b/cmd/Kconfig
index b359ac7118b0..e1c45eeb5ce4 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -152,8 +152,8 @@ config CMD_BDI
 
 config CMD_CONFIG
 	bool "config"
-	select BUILD_BIN2C
 	default SANDBOX
+	select BUILD_BIN2C
 	help
 	  Print ".config" contents.
 
@@ -429,8 +429,8 @@ config CMD_BINOP
 
 config CMD_CRC32
 	bool "crc32"
-	select HASH
 	default y
+	select HASH
 	help
 	  Compute CRC32.
 
@@ -737,9 +737,9 @@ config CMD_GPIO
 
 config CMD_GPT
 	bool "GPT (GUID Partition Table) command"
-	select PARTITION_UUIDS
 	select EFI_PARTITION
 	select HAVE_BLOCK_DEVICE
+	select PARTITION_UUIDS
 	imply RANDOM_UUID
 	help
 	  Enable the 'gpt' command to ready and write GPT style partition
@@ -899,8 +899,8 @@ config CMD_ONENAND
 
 config CMD_PART
 	bool "part"
-	select PARTITION_UUIDS
 	select HAVE_BLOCK_DEVICE
+	select PARTITION_UUIDS
 	help
 	  Read and display information about the partition table on
 	  various media.
@@ -1797,10 +1797,10 @@ endmenu
 
 config CMD_UBI
 	tristate "Enable UBI - Unsorted block images commands"
+	default y if NAND_SUNXI
+	select CMD_MTDPARTS
 	select CRC32
 	select MTD_UBI
-	select CMD_MTDPARTS
-	default y if NAND_SUNXI
 	help
 	  UBI is a software layer above MTD layer which admits use of LVM-like
 	  logical volumes on top of MTD devices, hides some complexities of
@@ -1812,9 +1812,9 @@ config CMD_UBI
 config CMD_UBIFS
 	tristate "Enable UBIFS - Unsorted block images filesystem commands"
 	depends on CMD_UBI
+	default y if CMD_UBI
 	select CRC32
 	select LZO
-	default y if CMD_UBI
 	help
 	  UBIFS is a file system for flash devices which works on top of UBI.
 
-- 
1.9.1

^ permalink raw reply related

* [U-Boot] [PATCH v2 4/5] dm: Change CMD_DM enabling
From: Michal Simek @ 2018-07-23 13:55 UTC (permalink / raw)
  To: u-boot
In-Reply-To: <c066c7007bdf6864e8695477fb28c091f1f6e9bf.1532354106.git.michal.simek@xilinx.com>

CMD_DM is used for debug purpose and it shouldn't be enabled by default
via Kconfig. Unfortunately this is in the tree for quite a long time
that's why solution is to use imply DM for all targets which are
enabling DM.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2:
- sort them

Based on this discussion:
https://lists.denx.de/pipermail/u-boot/2018-July/334952.html

Done by:
for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
uniq`; do
	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
done

And sort:

And checked by
for i in `ls configs/*`; do
	NAME=`basename $i`; echo $NAME;
	make $NAME;
	make savedefconfig;
	cp defconfig $i;
done

---
 arch/Kconfig                       |  3 +++
 arch/arm/Kconfig                   | 25 +++++++++++++++++++++++++
 arch/arm/mach-at91/Kconfig         |  6 ++++++
 arch/arm/mach-imx/mx5/Kconfig      |  2 ++
 arch/arm/mach-imx/mx6/Kconfig      | 25 +++++++++++++++++++++++++
 arch/arm/mach-imx/mx7/Kconfig      |  5 +++++
 arch/arm/mach-meson/Kconfig        |  2 ++
 arch/arm/mach-omap2/am33xx/Kconfig | 18 ++++++++++++++++++
 arch/arm/mach-omap2/omap3/Kconfig  | 10 ++++++++++
 arch/arm/mach-rmobile/Kconfig.32   |  8 ++++++++
 arch/arm/mach-tegra/Kconfig        |  1 +
 arch/microblaze/Kconfig            |  1 +
 arch/mips/Kconfig                  |  6 ++++++
 arch/powerpc/cpu/mpc83xx/Kconfig   |  1 +
 cmd/Kconfig                        |  1 -
 15 files changed, 113 insertions(+), 1 deletion(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index 7967fa50ac22..bf1b4a9afac6 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -50,6 +50,7 @@ config NIOS2
 	select DM
 	select OF_CONTROL
 	select SUPPORT_OF_CONTROL
+	imply CMD_DM
 
 config PPC
 	bool "PowerPC architecture"
@@ -77,6 +78,7 @@ config SANDBOX
 	select LZO
 	select SPI
 	select SUPPORT_OF_CONTROL
+	imply CMD_DM
 	imply CMD_GETTIME
 	imply CMD_HASH
 	imply CMD_IO
@@ -107,6 +109,7 @@ config X86
 	select USE_PRIVATE_LIBGCC
 	select X86_TSC_TIMER
 	imply BLK
+	imply CMD_DM
 	imply CMD_FPGA_LOADMK
 	imply CMD_GETTIME
 	imply CMD_IO
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 0c43c58ef0ed..6eaaa1f14826 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -441,6 +441,7 @@ config ARCH_MVEBU
 	select OF_CONTROL
 	select OF_SEPARATE
 	select SPI
+	imply CMD_DM
 
 config TARGET_DEVKIT3250
 	bool "Support devkit3250"
@@ -499,6 +500,7 @@ config TARGET_STV0991
 	select PL01X_SERIAL
 	select SPI
 	select SPI_FLASH
+	imply CMD_DM
 
 config TARGET_X600
 	bool "Support x600"
@@ -533,6 +535,7 @@ config ARCH_BCM283X
 	select OF_CONTROL
 	select PL01X_SERIAL
 	select SERIAL_SEARCH_ALL
+	imply CMD_DM
 	imply FAT_WRITE
 
 config TARGET_VEXPRESS_CA15_TC2
@@ -548,6 +551,7 @@ config ARCH_BCMSTB
 	select DM
 	select OF_CONTROL
 	select OF_PRIOR_STAGE
+	imply CMD_DM
 	help
 	  This enables support for Broadcom ARM-based set-top box
 	  chipsets, including the 7445 family of chips.
@@ -607,6 +611,7 @@ config ARCH_EXYNOS
 	select DM_SPI
 	select DM_SPI_FLASH
 	select SPI
+	imply CMD_DM
 	imply FAT_WRITE
 
 config ARCH_S5PC1XX
@@ -616,6 +621,7 @@ config ARCH_S5PC1XX
 	select DM_GPIO
 	select DM_I2C
 	select DM_SERIAL
+	imply CMD_DM
 
 config ARCH_HIGHBANK
 	bool "Calxeda Highbank"
@@ -627,6 +633,7 @@ config ARCH_INTEGRATOR
 	select DM
 	select DM_SERIAL
 	select PL01X_SERIAL
+	imply CMD_DM
 
 config ARCH_KEYSTONE
 	bool "TI Keystone"
@@ -660,6 +667,7 @@ config ARCH_MX8M
 	select ARM64
 	select DM
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config ARCH_MX23
 	bool "NXP i.MX23 family"
@@ -724,6 +732,7 @@ config ARCH_OWL
 	select DM
 	select DM_SERIAL
 	select OF_CONTROL
+	imply CMD_DM
 
 config ARCH_QEMU
 	bool "QEMU Virtual Platform"
@@ -731,12 +740,14 @@ config ARCH_QEMU
 	select DM_SERIAL
 	select OF_CONTROL
 	select PL01X_SERIAL
+	imply CMD_DM
 
 config ARCH_RMOBILE
 	bool "Renesas ARM SoCs"
 	select BOARD_EARLY_INIT_F
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 	imply FAT_WRITE
 	imply SYS_THUMB_BUILD
 
@@ -756,6 +767,7 @@ config ARCH_SNAPDRAGON
 	select OF_SEPARATE
 	select SMEM
 	select SPMI
+	imply CMD_DM
 
 config ARCH_SOCFPGA
 	bool "Altera SOCFPGA family"
@@ -784,6 +796,7 @@ config ARCH_SOCFPGA
 	select SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE
 	select SYS_NS16550
 	select SYS_THUMB_BUILD if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
+	imply CMD_DM
 	imply CMD_MTDPARTS
 	imply CRC32_VERIFY
 	imply DM_SPI
@@ -816,6 +829,7 @@ config ARCH_SUNXI
 	select USB_KEYBOARD if DISTRO_DEFAULTS
 	select USB_STORAGE if DISTRO_DEFAULTS
 	select USE_TINY_PRINTF
+	imply CMD_DM
 	imply CMD_GPT
 	imply DISTRO_DEFAULTS
 	imply FAT_WRITE
@@ -861,6 +875,7 @@ config ARCH_ZYNQ
 	select SUPPORT_SPL
 	imply ARCH_EARLY_INIT_R
 	imply CMD_CLK
+	imply CMD_DM
 	imply CMD_SPL
 	imply FAT_WRITE
 
@@ -871,6 +886,7 @@ config ARCH_ZYNQMP_R5
 	select DM
 	select DM_SERIAL
 	select OF_CONTROL
+	imply CMD_DM
 
 config ARCH_ZYNQMP
 	bool "Xilinx ZynqMP based platform"
@@ -884,6 +900,7 @@ config ARCH_ZYNQMP
 	select SPL_BOARD_INIT if SPL
 	select SPL_CLK if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 	imply FAT_WRITE
 
 config TEGRA
@@ -1010,6 +1027,7 @@ config TARGET_HIKEY
 	select OF_CONTROL
 	select PL01X_SERIAL
 	select SPECIFY_CONSOLE_INDEX
+	imply CMD_DM
 	  help
 	  Support for HiKey 96boards platform. It features a HI6220
 	  SoC, with 8xA53 CPU, mali450 gpu, and 1GB RAM.
@@ -1022,6 +1040,7 @@ config TARGET_POPLAR
 	select DM_USB
 	select OF_CONTROL
 	select PL01X_SERIAL
+	imply CMD_DM
 	  help
 	  Support for Poplar 96boards EE platform. It features a HI3798cv200
 	  SoC, with 4xA53 CPU, 1GB RAM and the high performance Mali T720 GPU
@@ -1233,6 +1252,7 @@ config ARCH_UNIPHIER
 	select SPL_OF_CONTROL if SPL
 	select SPL_PINCTRL if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 	imply FAT_WRITE
 	help
 	  Support for UniPhier SoC family developed by Socionext Inc.
@@ -1244,6 +1264,7 @@ config STM32
 	select DM
 	select DM_SERIAL
 	select SYS_THUMB_BUILD
+	imply CMD_DM
 
 config ARCH_STI
 	bool "Support STMicrolectronics SoCs"
@@ -1253,6 +1274,7 @@ config ARCH_STI
 	select DM_MMC
 	select DM_RESET
 	select DM_SERIAL
+	imply CMD_DM
 	help
 	  Support for STMicroelectronics STiH407/10 SoC family.
 	  This SoC is used on Linaro 96Board STiH410-B2260
@@ -1275,6 +1297,7 @@ config ARCH_STM32MP
 	select SYSCON
 	select SYSRESET
 	select SYS_THUMB_BUILD
+	imply CMD_DM
 	help
 	  Support for STM32MP SoC family developed by STMicroelectronics,
 	  MPUs based on ARM cortex A core
@@ -1302,6 +1325,7 @@ config ARCH_ROCKCHIP
 	select SYS_MALLOC_F
 	select SYS_THUMB_BUILD if !ARM64
 	imply ADC
+	imply CMD_DM
 	imply DISTRO_DEFAULTS
 	imply FAT_WRITE
 	imply SARADC_ROCKCHIP
@@ -1321,6 +1345,7 @@ config ARCH_ASPEED
 	bool "Support Aspeed SoCs"
 	select DM
 	select OF_CONTROL
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 1a56957cf9d1..69856c894285 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -78,6 +78,7 @@ config TARGET_SNAPPER9260
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_GURNARD
 	bool "Support gurnard"
@@ -89,6 +90,7 @@ config TARGET_GURNARD
 	select DM_SERIAL
 	select DM_SPI
 	select SPI
+	imply CMD_DM
 
 config TARGET_AT91SAM9261EK
 	bool "Atmel at91sam9261 reference board"
@@ -209,6 +211,7 @@ config TARGET_CORVUS
 	select DM_GPIO
 	select DM_SERIAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_TAURUS
 	bool "Support taurus"
@@ -220,6 +223,7 @@ config TARGET_TAURUS
 	select DM_SPI
 	select SPI
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_SMARTWEB
 	bool "Support smartweb"
@@ -229,6 +233,7 @@ config TARGET_SMARTWEB
 	select DM_GPIO
 	select DM_SERIAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_VINCO
 	bool "Support VINCO"
@@ -237,6 +242,7 @@ config TARGET_VINCO
 	select SAMA5D4
 	select SPI
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_WB45N
 	bool "Support Laird WB45N"
diff --git a/arch/arm/mach-imx/mx5/Kconfig b/arch/arm/mach-imx/mx5/Kconfig
index 1bb373bf2d1c..051b15dbff1c 100644
--- a/arch/arm/mach-imx/mx5/Kconfig
+++ b/arch/arm/mach-imx/mx5/Kconfig
@@ -28,6 +28,7 @@ config TARGET_KP_IMX53
 	select DM_PMIC
 	select DM_SERIAL
 	select MX53
+	imply CMD_DM
 
 config TARGET_MX51EVK
 	bool "Support mx51evk"
@@ -44,6 +45,7 @@ config TARGET_MX53CX9020
 	select DM
 	select DM_SERIAL
 	select MX53
+	imply CMD_DM
 
 config TARGET_MX53EVK
 	bool "Support mx53evk"
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
index 5cce9ce23c0e..6009a96531ac 100644
--- a/arch/arm/mach-imx/mx6/Kconfig
+++ b/arch/arm/mach-imx/mx6/Kconfig
@@ -64,6 +64,7 @@ config MX6UL_LITESOM
 	select DM_THERMAL
 	select MX6UL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config MX6UL_OPOS6UL
 	bool
@@ -78,6 +79,7 @@ config MX6UL_OPOS6UL
 	select SPL_PINCTRL if SPL
 	select SPL_SEPARATE_BSS if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config MX6ULL
 	bool
@@ -110,6 +112,7 @@ config TARGET_APALIS_IMX6
 	select DM_SERIAL
 	select DM_THERMAL
 	select SUPPORT_SPL
+	imply CMD_DM
 	imply CMD_SATA
 
 config TARGET_ARISTAINETOS
@@ -130,6 +133,7 @@ config TARGET_CGTQMX6EVAL
 	select DM_THERMAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_CM_FX6
 	bool "CM-FX6"
@@ -139,6 +143,7 @@ config TARGET_CM_FX6
 	select DM_SERIAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_COLIBRI_IMX6
 	bool "Toradex Colibri iMX6 board"
@@ -147,6 +152,7 @@ config TARGET_COLIBRI_IMX6
 	select DM_SERIAL
 	select DM_THERMAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_DHCOMIMX6
 	bool "dh_imx6"
@@ -156,6 +162,7 @@ config TARGET_DHCOMIMX6
 	select DM_THERMAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 	imply CMD_SPL
 
 config TARGET_DISPLAY5
@@ -163,6 +170,7 @@ config TARGET_DISPLAY5
 	select DM
 	select DM_SERIAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_EMBESTMX6BOARDS
 	bool "embestmx6boards"
@@ -208,6 +216,7 @@ config TARGET_MX6LOGICPD
 	select DM_PMIC
 	select DM_REGULATOR
 	select OF_CONTROL
+	imply CMD_DM
 
 config TARGET_MX6MEMCAL
 	bool "mx6memcal"
@@ -250,6 +259,7 @@ config TARGET_MX6DL_MAMOJ
 	select SPL_USB_SDP_SUPPORT if SPL
 	select SPL_WATCHDOG_SUPPORT if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6Q_ENGICAM
 	bool "Support Engicam i.Core(RQS)"
@@ -268,6 +278,7 @@ config TARGET_MX6Q_ENGICAM
 	select SPL_PINCTRL if SPL
 	select SPL_SEPARATE_BSS if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6SABREAUTO
 	bool "mx6sabreauto"
@@ -277,6 +288,7 @@ config TARGET_MX6SABREAUTO
 	select DM_THERMAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6SABRESD
 	bool "mx6sabresd"
@@ -286,6 +298,7 @@ config TARGET_MX6SABRESD
 	select DM_THERMAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6SLEVK
 	bool "mx6slevk"
@@ -298,6 +311,7 @@ config TARGET_MX6SLLEVK
 	select DM
 	select DM_THERMAL
 	select MX6SLL
+	imply CMD_DM
 
 config TARGET_MX6SXSABRESD
 	bool "mx6sxsabresd"
@@ -315,6 +329,7 @@ config TARGET_MX6SXSABREAUTO
 	select DM
 	select DM_THERMAL
 	select MX6SX
+	imply CMD_DM
 
 config TARGET_MX6UL_9X9_EVK
 	bool "mx6ul_9x9_evk"
@@ -323,6 +338,7 @@ config TARGET_MX6UL_9X9_EVK
 	select DM_THERMAL
 	select MX6UL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6UL_14X14_EVK
 	bool "mx6ul_14x14_evk"
@@ -331,6 +347,7 @@ config TARGET_MX6UL_14X14_EVK
 	select DM_THERMAL
 	select MX6UL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6UL_ENGICAM
 	bool "Support Engicam GEAM6UL/Is.IoT"
@@ -348,6 +365,7 @@ config TARGET_MX6UL_ENGICAM
 	select SPL_PINCTRL if SPL
 	select SPL_SEPARATE_BSS if SPL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX6ULL_14X14_EVK
 	bool "Support mx6ull_14x14_evk"
@@ -355,6 +373,7 @@ config TARGET_MX6ULL_14X14_EVK
 	select DM
 	select DM_THERMAL
 	select MX6ULL
+	imply CMD_DM
 
 config TARGET_NITROGEN6X
 	bool "nitrogen6x"
@@ -421,6 +440,7 @@ config TARGET_KP_IMX6Q_TPC
 	select DM_THERMAL
 	select MX6QDL
 	select SUPPORT_SPL
+	imply CMD_DM
 	imply CMD_SPL
 
 config TARGET_TQMA6
@@ -440,6 +460,7 @@ config TARGET_UDOO_NEO
 	select DM_THERMAL
 	select MX6SX
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_SAMTEC_VINING_2000
 	bool "samtec VIN|ING 2000"
@@ -447,6 +468,7 @@ config TARGET_SAMTEC_VINING_2000
 	select DM
 	select DM_THERMAL
 	select MX6SX
+	imply CMD_DM
 
 config TARGET_WANDBOARD
 	bool "wandboard"
@@ -466,6 +488,7 @@ config TARGET_XPRESS
 	select DM_THERMAL
 	select MX6UL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_ZC5202
 	bool "zc5202"
@@ -473,6 +496,7 @@ config TARGET_ZC5202
 	select DM
 	select DM_THERMAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_ZC5601
 	bool "zc5601"
@@ -480,6 +504,7 @@ config TARGET_ZC5601
 	select DM
 	select DM_THERMAL
 	select SUPPORT_SPL
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-imx/mx7/Kconfig b/arch/arm/mach-imx/mx7/Kconfig
index f618a7bb9d1f..e75e43dc8ffc 100644
--- a/arch/arm/mach-imx/mx7/Kconfig
+++ b/arch/arm/mach-imx/mx7/Kconfig
@@ -26,6 +26,7 @@ config TARGET_CL_SOM_IMX7
 	select DM_THERMAL
 	select MX7D
 	select SUPPORT_SPL
+	imply CMD_DM
 
 config TARGET_MX7DSABRESD
 	bool "mx7dsabresd"
@@ -33,6 +34,7 @@ config TARGET_MX7DSABRESD
 	select DM
 	select DM_THERMAL
 	select MX7D
+	imply CMD_DM
 
 config TARGET_PICO_IMX7D
 	bool "pico-imx7d"
@@ -40,6 +42,7 @@ config TARGET_PICO_IMX7D
 	select DM
 	select DM_THERMAL
 	select MX7D
+	imply CMD_DM
 
 config TARGET_WARP7
 	bool "warp7"
@@ -47,6 +50,7 @@ config TARGET_WARP7
 	select DM
 	select DM_THERMAL
 	select MX7D
+	imply CMD_DM
 
 config TARGET_COLIBRI_IMX7
 	bool "Support Colibri iMX7S/iMX7D modules"
@@ -54,6 +58,7 @@ config TARGET_COLIBRI_IMX7
 	select DM
 	select DM_SERIAL
 	select DM_THERMAL
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
index 76622567907b..ee8b1cdcf674 100644
--- a/arch/arm/mach-meson/Kconfig
+++ b/arch/arm/mach-meson/Kconfig
@@ -6,6 +6,7 @@ config MESON_GXBB
 	select CLK
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 	help
 	  The Amlogic Meson GXBaby (S905) is an ARM SoC with a
 	  quad-core Cortex-A53 CPU and a Mali-450 GPU.
@@ -16,6 +17,7 @@ config MESON_GXL
 	select CLK
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 	help
 	  The Amlogic Meson GXL (S905X and S905D) is an ARM SoC with a
 	  quad-core Cortex-A53 CPU and a Mali-450 GPU.
diff --git a/arch/arm/mach-omap2/am33xx/Kconfig b/arch/arm/mach-omap2/am33xx/Kconfig
index 94d9d868f893..3529607479d2 100644
--- a/arch/arm/mach-omap2/am33xx/Kconfig
+++ b/arch/arm/mach-omap2/am33xx/Kconfig
@@ -34,6 +34,7 @@ config TARGET_AM335X_EVM
 	select DM_GPIO
 	select DM_SERIAL
 	select TI_I2C_BOARD_DETECT
+	imply CMD_DM
 	imply SPL_DM
 	imply SPL_DM_SEQ_ALIAS
 	imply SPL_ENV_SUPPORT
@@ -67,6 +68,7 @@ config TARGET_AM335X_BALTOS
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_AM335X_IGEP003X
 	bool "Support am335x_igep003x"
@@ -74,6 +76,7 @@ config TARGET_AM335X_IGEP003X
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_AM335X_SHC
 	bool "Support am335x based shc board from bosch"
@@ -81,6 +84,7 @@ config TARGET_AM335X_SHC
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 	imply CMD_SPL
 
 config TARGET_AM335X_SL50
@@ -89,12 +93,14 @@ config TARGET_AM335X_SL50
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_BAV335X
 	bool "Support bav335x"
 	select BOARD_LATE_INIT
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 	help
 	  The BAV335x OEM Network Processor integrates all the functions of an
 	  embedded network computer in a small, easy to use SODIMM module which
@@ -118,12 +124,14 @@ config TARGET_CHILIBOARD
 	select BOARD_LATE_INIT
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_CM_T335
 	bool "Support cm_t335"
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_DRACO
 	bool "Support draco"
@@ -131,6 +139,7 @@ config TARGET_DRACO
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_ETAMIN
 	bool "Support etamin"
@@ -138,24 +147,28 @@ config TARGET_ETAMIN
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_PCM051
 	bool "Support pcm051"
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_PENGWYN
 	bool "Support pengwyn"
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_PEPPER
 	bool "Support pepper"
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_PXM2
 	bool "Support pxm2"
@@ -163,6 +176,7 @@ config TARGET_PXM2
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_RASTABAN
 	bool "Support rastaban"
@@ -170,6 +184,7 @@ config TARGET_RASTABAN
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_RUT
 	bool "Support rut"
@@ -177,6 +192,7 @@ config TARGET_RUT
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_THUBAN
 	bool "Support thuban"
@@ -184,11 +200,13 @@ config TARGET_THUBAN
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_PDU001
 	bool "Support PDU001"
 	select DM
 	select DM_SERIAL
+	imply CMD_DM
 	help
 	  Support for PDU001 platform developed by EETS GmbH.
 	  The PDU001 is a processor and display unit developed around
diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/omap3/Kconfig
index 9e4227d8266b..e0d02fb4e59a 100644
--- a/arch/arm/mach-omap2/omap3/Kconfig
+++ b/arch/arm/mach-omap2/omap3/Kconfig
@@ -27,6 +27,7 @@ config TARGET_AM3517_EVM
 	select DM_I2C
 	select DM_MMC
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_MT_VENTOUX
 	bool "TeeJet Mt.Ventoux"
@@ -40,6 +41,7 @@ config TARGET_OMAP3_BEAGLE
 	select DM_SERIAL
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
+	imply CMD_DM
 
 config TARGET_CM_T35
 	bool "CompuLab CM-T3530 and CM-T3730 boards"
@@ -58,6 +60,7 @@ config TARGET_DEVKIT8000
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_OMAP3_EVM
 	bool "TI OMAP3 EVM"
@@ -65,6 +68,7 @@ config TARGET_OMAP3_EVM
 	select DM_GPIO
 	select DM_SERIAL
 	select OMAP3_GPIO_3
+	imply CMD_DM
 
 config TARGET_OMAP3_IGEP00X0
 	bool "IGEP"
@@ -74,6 +78,7 @@ config TARGET_OMAP3_IGEP00X0
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
+	imply CMD_DM
 
 config TARGET_OMAP3_OVERO
 	bool "OMAP35xx Gumstix Overo"
@@ -85,12 +90,14 @@ config TARGET_OMAP3_OVERO
 	select OMAP3_GPIO_4
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
+	imply CMD_DM
 
 config TARGET_OMAP3_ZOOM1
 	bool "TI Zoom1"
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_AM3517_CRANE
 	bool "am3517_crane"
@@ -123,6 +130,7 @@ config TARGET_OMAP3_LOGIC
 	select OMAP3_GPIO_3
 	select OMAP3_GPIO_4
 	select OMAP3_GPIO_6
+	imply CMD_DM
 
 config TARGET_NOKIA_RX51
 	bool "Nokia RX51"
@@ -145,6 +153,7 @@ config TARGET_OMAP3_CAIRO
 	select DM
 	select DM_GPIO
 	select DM_SERIAL
+	imply CMD_DM
 
 config TARGET_SNIPER
 	bool "LG Optimus Black"
@@ -156,6 +165,7 @@ config TARGET_SNIPER
 	select OMAP3_GPIO_4
 	select OMAP3_GPIO_5
 	select OMAP3_GPIO_6
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-rmobile/Kconfig.32 b/arch/arm/mach-rmobile/Kconfig.32
index dc517350ee19..c005ce2a286b 100644
--- a/arch/arm/mach-rmobile/Kconfig.32
+++ b/arch/arm/mach-rmobile/Kconfig.32
@@ -42,6 +42,7 @@ config TARGET_BLANCHE
 	select DM
 	select DM_SERIAL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_GOSE
 	bool "Gose board"
@@ -50,6 +51,7 @@ config TARGET_GOSE
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_KOELSCH
 	bool "Koelsch board"
@@ -58,6 +60,7 @@ config TARGET_KOELSCH
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_LAGER
 	bool "Lager board"
@@ -66,6 +69,7 @@ config TARGET_LAGER
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_KZM9G
 	bool "KZM9D board"
@@ -77,6 +81,7 @@ config TARGET_ALT
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_SILK
 	bool "Silk board"
@@ -85,6 +90,7 @@ config TARGET_SILK
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_PORTER
 	bool "Porter board"
@@ -93,6 +99,7 @@ config TARGET_PORTER
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 config TARGET_STOUT
 	bool "Stout board"
@@ -101,6 +108,7 @@ config TARGET_STOUT
 	select SPL_TINY_MEMSET
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index cd03705b64c0..86b1cd11f752 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -40,6 +40,7 @@ config TEGRA_COMMON
 	select OF_CONTROL
 	select SPI
 	select VIDCONSOLE_AS_LCD if DM_VIDEO
+	imply CMD_DM
 	imply CRC32_VERIFY
 
 config TEGRA_NO_BPMP
diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
index 1df1ecf72d19..5cc68d63c4f7 100644
--- a/arch/microblaze/Kconfig
+++ b/arch/microblaze/Kconfig
@@ -16,6 +16,7 @@ config TARGET_MICROBLAZE_GENERIC
 	select OF_CONTROL
 	select SUPPORT_SPL
 	select SYSRESET
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 315d89dbeb3f..31b622ff5108 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -42,6 +42,7 @@ config TARGET_MALTA
 	select SUPPORTS_CPU_MIPS64_R6
 	select SUPPORTS_LITTLE_ENDIAN
 	select SWAP_IO_SPACE
+	imply CMD_DM
 
 config TARGET_VCT
 	bool "Support vct"
@@ -74,6 +75,7 @@ config ARCH_ATH79
 	bool "Support QCA/Atheros ath79"
 	select DM
 	select OF_CONTROL
+	imply CMD_DM
 
 config ARCH_BMIPS
 	bool "Support BMIPS SoCs"
@@ -83,11 +85,13 @@ config ARCH_BMIPS
 	select OF_CONTROL
 	select RAM
 	select SYSRESET
+	imply CMD_DM
 
 config MACH_PIC32
 	bool "Support Microchip PIC32"
 	select DM
 	select OF_CONTROL
+	imply CMD_DM
 
 config TARGET_BOSTON
 	bool "Support Boston"
@@ -107,6 +111,7 @@ config TARGET_BOSTON
 	select SUPPORTS_CPU_MIPS64_R2
 	select SUPPORTS_CPU_MIPS64_R6
 	select SUPPORTS_LITTLE_ENDIAN
+	imply CMD_DM
 
 config TARGET_XILFPGA
 	bool "Support Imagination Xilfpga"
@@ -120,6 +125,7 @@ config TARGET_XILFPGA
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SUPPORTS_LITTLE_ENDIAN
+	imply CMD_DM
 	help
 	  This supports IMGTEC MIPSfpga platform
 
diff --git a/arch/powerpc/cpu/mpc83xx/Kconfig b/arch/powerpc/cpu/mpc83xx/Kconfig
index 385a7a6e2172..571cf8fc2ef8 100644
--- a/arch/powerpc/cpu/mpc83xx/Kconfig
+++ b/arch/powerpc/cpu/mpc83xx/Kconfig
@@ -64,6 +64,7 @@ config TARGET_MPC837XERDB
 config TARGET_IDS8313
 	bool "Support ids8313"
 	select DM
+	imply CMD_DM
 
 config TARGET_KM8360
 	bool "Support km8360"
diff --git a/cmd/Kconfig b/cmd/Kconfig
index e1c45eeb5ce4..6394c3c8e179 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -640,7 +640,6 @@ config CMD_DFU
 config CMD_DM
 	bool "dm - Access to driver model information"
 	depends on DM
-	default y
 	help
 	  Provides access to driver model data structures and information,
 	  such as a list of devices, list of uclasses and the state of each
-- 
1.9.1

^ permalink raw reply related

* [U-Boot] [PATCH v2 5/5] Kconfig: Sort bool, default, select and imply options
From: Michal Simek @ 2018-07-23 13:55 UTC (permalink / raw)
  To: u-boot
In-Reply-To: <c066c7007bdf6864e8695477fb28c091f1f6e9bf.1532354106.git.michal.simek@xilinx.com>

Another round of sorting Kconfig entries aplhabetically.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Changes in v2: None

 Kconfig                               | 22 ++++++++++-----------
 arch/arc/Kconfig                      | 10 +++++-----
 arch/arm/cpu/armv7/ls102xa/Kconfig    | 10 +++++-----
 arch/arm/cpu/armv8/Kconfig            |  4 ++--
 arch/arm/mach-davinci/Kconfig         |  4 ++--
 arch/arm/mach-exynos/Kconfig          | 30 ++++++++++++++---------------
 arch/arm/mach-imx/mx3/Kconfig         |  2 +-
 arch/arm/mach-mvebu/Kconfig           |  6 +++---
 arch/arm/mach-omap2/Kconfig           |  6 +++---
 arch/arm/mach-omap2/omap5/Kconfig     | 12 ++++++------
 arch/arm/mach-qemu/Kconfig            |  2 +-
 arch/arm/mach-rockchip/rk3288/Kconfig | 20 +++++++++----------
 arch/arm/mach-socfpga/Kconfig         |  4 ++--
 arch/arm/mach-stm32/Kconfig           | 20 +++++++++----------
 arch/arm/mach-tegra/tegra124/Kconfig  |  4 ++--
 arch/arm/mach-uniphier/Kconfig        |  8 ++++----
 arch/mips/mach-ath79/Kconfig          | 10 +++++-----
 arch/mips/mach-bmips/Kconfig          | 36 +++++++++++++++++------------------
 arch/mips/mach-pic32/Kconfig          |  6 +++---
 arch/powerpc/Kconfig                  |  2 +-
 20 files changed, 109 insertions(+), 109 deletions(-)

diff --git a/Kconfig b/Kconfig
index c8b86cd3843d..62235cae96cf 100644
--- a/Kconfig
+++ b/Kconfig
@@ -68,25 +68,25 @@ config CC_COVERAGE
 
 config DISTRO_DEFAULTS
 	bool "Select defaults suitable for booting general purpose Linux distributions"
-	imply USE_BOOTCOMMAND
-	select CMD_BOOTZ if ARM && !ARM64
+	select AUTO_COMPLETE
+	select CMDLINE_EDITING
 	select CMD_BOOTI if ARM64
+	select CMD_BOOTZ if ARM && !ARM64
 	select CMD_DHCP if CMD_NET
-	select CMD_PING if CMD_NET
-	select CMD_PXE if NET
 	select CMD_ENV_EXISTS
 	select CMD_EXT2
 	select CMD_EXT4
 	select CMD_FAT
 	select CMD_FS_GENERIC
-	imply CMD_MII if NET
 	select CMD_PART if PARTITIONS
+	select CMD_PING if CMD_NET
+	select CMD_PXE if NET
+	select ENV_VARS_UBOOT_CONFIG
 	select HUSH_PARSER
-	select CMDLINE_EDITING
-	select AUTO_COMPLETE
-	select SYS_LONGHELP
 	select SUPPORT_RAW_INITRD
-	select ENV_VARS_UBOOT_CONFIG
+	select SYS_LONGHELP
+	imply CMD_MII if NET
+	imply USE_BOOTCOMMAND
 	help
 	  Select this to enable various options and commands which are suitable
 	  for building u-boot for booting general purpose Linux distributions.
@@ -237,8 +237,8 @@ if FIT
 
 config FIT_ENABLE_SHA256_SUPPORT
 	bool "Support SHA256 checksum of FIT image contents"
-	select SHA256
 	default y
+	select SHA256
 	help
 	  Enable this to support SHA256 checksum of FIT image contents. A
 	  SHA256 checksum is a 256-bit (32-byte) hash value used to check that
@@ -252,8 +252,8 @@ config FIT_ENABLE_SHA256_SUPPORT
 config FIT_SIGNATURE
 	bool "Enable signature verification of FIT uImages"
 	depends on DM
-	select RSA
 	select HASH
+	select RSA
 	help
 	  This option enables signature verification of FIT uImages,
 	  using a hash signed and verified using RSA. If
diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
index 6f139d5bdc52..d59aa3ae291e 100644
--- a/arch/arc/Kconfig
+++ b/arch/arc/Kconfig
@@ -31,36 +31,36 @@ choice
 
 config CPU_ARC750D
 	bool "ARC 750D"
-	select ARC_MMU_V2
 	depends on ISA_ARCOMPACT
+	select ARC_MMU_V2
 	help
 	  Choose this option to build an U-Boot for ARC750D CPU.
 
 config CPU_ARC770D
 	bool "ARC 770D"
-	select ARC_MMU_V3
 	depends on ISA_ARCOMPACT
+	select ARC_MMU_V3
 	help
 	  Choose this option to build an U-Boot for ARC770D CPU.
 
 config CPU_ARCEM6
 	bool "ARC EM6"
-	select ARC_MMU_ABSENT
 	depends on ISA_ARCV2
+	select ARC_MMU_ABSENT
 	help
 	  Next Generation ARC Core based on ISA-v2 ISA without MMU.
 
 config CPU_ARCHS36
 	bool "ARC HS36"
-	select ARC_MMU_ABSENT
 	depends on ISA_ARCV2
+	select ARC_MMU_ABSENT
 	help
 	  Next Generation ARC Core based on ISA-v2 ISA without MMU.
 
 config CPU_ARCHS38
 	bool "ARC HS38"
-	select ARC_MMU_V4
 	depends on ISA_ARCV2
+	select ARC_MMU_V4
 	help
 	  Next Generation ARC Core based on ISA-v2 ISA with MMU.
 
diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig b/arch/arm/cpu/armv7/ls102xa/Kconfig
index 635358e32838..5d6a711c140c 100644
--- a/arch/arm/cpu/armv7/ls102xa/Kconfig
+++ b/arch/arm/cpu/armv7/ls102xa/Kconfig
@@ -1,5 +1,7 @@
 config ARCH_LS1021A
 	bool
+	select SYS_FSL_DDR_BE if SYS_FSL_DDR
+	select SYS_FSL_DDR_VER_50 if SYS_FSL_DDR
 	select SYS_FSL_ERRATUM_A008378
 	select SYS_FSL_ERRATUM_A008407
 	select SYS_FSL_ERRATUM_A008997
@@ -10,18 +12,16 @@ config ARCH_LS1021A
 	select SYS_FSL_ERRATUM_A009942
 	select SYS_FSL_ERRATUM_A010315
 	select SYS_FSL_HAS_CCI400
-	select SYS_FSL_SRDS_1
-	select SYS_HAS_SERDES
-	select SYS_FSL_DDR_BE if SYS_FSL_DDR
-	select SYS_FSL_DDR_VER_50 if SYS_FSL_DDR
 	select SYS_FSL_HAS_DDR3 if SYS_FSL_DDR
 	select SYS_FSL_HAS_DDR4 if SYS_FSL_DDR
 	select SYS_FSL_HAS_SEC
 	select SYS_FSL_SEC_COMPAT_5
 	select SYS_FSL_SEC_LE
+	select SYS_FSL_SRDS_1
+	select SYS_HAS_SERDES
+	imply CMD_PCI
 	imply SCSI
 	imply SCSI_AHCI
-	imply CMD_PCI
 
 menu "LS102xA architecture"
 	depends on ARCH_LS1021A
diff --git a/arch/arm/cpu/armv8/Kconfig b/arch/arm/cpu/armv8/Kconfig
index 22d2f295487c..741e15c77378 100644
--- a/arch/arm/cpu/armv8/Kconfig
+++ b/arch/arm/cpu/armv8/Kconfig
@@ -44,8 +44,8 @@ config ARMV8_SPIN_TABLE
 menu "ARMv8 secure monitor firmware"
 config ARMV8_SEC_FIRMWARE_SUPPORT
 	bool "Enable ARMv8 secure monitor firmware framework support"
-	select OF_LIBFDT
 	select FIT
+	select OF_LIBFDT
 	help
 	  This framework is aimed at making secure monitor firmware load
 	  process brief.
@@ -60,8 +60,8 @@ config ARMV8_SEC_FIRMWARE_SUPPORT
 
 config SPL_ARMV8_SEC_FIRMWARE_SUPPORT
 	bool "Enable ARMv8 secure monitor firmware framework support for SPL"
-	select SPL_OF_LIBFDT
 	select SPL_FIT
+	select SPL_OF_LIBFDT
 	help
 	  Say Y here to support this framework in SPL phase.
 
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 5e7baba3fe49..12b1e682e6a2 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -18,9 +18,9 @@ config TARGET_DA850EVM
 
 config TARGET_EA20
 	bool "EA20 board"
+	select BOARD_LATE_INIT
 	select MACH_DAVINCI_DA850_EVM
 	select SOC_DA850
-	select BOARD_LATE_INIT
 
 config TARGET_OMAPL138_LCDK
 	bool "OMAPL138 LCDK"
@@ -57,8 +57,8 @@ config SOC_DA850
 
 config SOC_DA8XX
 	bool
-	select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
 	select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
+	select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
 
 config MACH_DAVINCI_DA850_EVM
 	bool
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 65d9168ae2f3..ed04369cfae3 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -6,8 +6,8 @@ choice
 
 config ARCH_EXYNOS4
 	bool "Exynos4 SoC family"
-	select CPU_V7A
 	select BOARD_EARLY_INIT_F
+	select CPU_V7A
 	help
 	  Samsung Exynos4 SoC family are based on ARM Cortex-A9 CPU. There
 	  are multiple SoCs in this family including Exynos4210, Exynos4412,
@@ -15,14 +15,14 @@ config ARCH_EXYNOS4
 
 config ARCH_EXYNOS5
 	bool "Exynos5 SoC family"
-	select CPU_V7A
 	select BOARD_EARLY_INIT_F
+	select CPU_V7A
 	select SHA_HW_ACCEL
-	imply CRC32_VERIFY
 	imply CMD_HASH
+	imply CRC32_VERIFY
 	imply HASH_VERIFY
-	imply USB_ETHER_RTL8152
 	imply USB_ETHER_ASIX
+	imply USB_ETHER_RTL8152
 	imply USB_ETHER_SMSC95XX
 	help
 	  Samsung Exynos5 SoC family are based on ARM Cortex-A15 CPU (and
@@ -46,9 +46,9 @@ choice
 	prompt "EXYNOS4 board select"
 
 config TARGET_SMDKV310
-	select SUPPORT_SPL
 	bool "Exynos4210 SMDKV310 board"
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_TRATS
 	bool "Exynos4210 Trats board"
@@ -93,39 +93,39 @@ config TARGET_ARNDALE
 	select ARM_ERRATA_774769
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_SMDK5250
 	bool "SMDK5250 board"
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_SNOW
 	bool "Snow board"
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_SPRING
 	bool "Spring board"
-	select SUPPORT_SPL
 	select OF_CONTROL
 	select SPL_DISABLE_OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_SMDK5420
 	bool "SMDK5420 board"
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_PEACH_PI
 	bool "Peach Pi board"
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 config TARGET_PEACH_PIT
 	bool "Peach Pit board"
-	select SUPPORT_SPL
 	select OF_CONTROL
+	select SUPPORT_SPL
 
 endchoice
 endif
@@ -139,12 +139,12 @@ config  TARGET_ESPRESSO7420
 	bool "ESPRESSO7420 board"
 	select ARM64
 	select ARMV8_MULTIENTRY
-	select SUPPORT_SPL
+	select CLK_EXYNOS
 	select OF_CONTROL
-	select SPL_DISABLE_OF_CONTROL
 	select PINCTRL
 	select PINCTRL_EXYNOS7420
-	select CLK_EXYNOS
+	select SPL_DISABLE_OF_CONTROL
+	select SUPPORT_SPL
 
 endchoice
 endif
diff --git a/arch/arm/mach-imx/mx3/Kconfig b/arch/arm/mach-imx/mx3/Kconfig
index 6cc970fc4992..5028d5ea568a 100644
--- a/arch/arm/mach-imx/mx3/Kconfig
+++ b/arch/arm/mach-imx/mx3/Kconfig
@@ -9,9 +9,9 @@ choice
 
 config TARGET_MX31PDK
 	bool "Support the i.MX31 PDK board from Freescale/NXP"
+	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
-	select BOARD_EARLY_INIT_F
 
 endchoice
 
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 5415b5a7bfe2..3df124c6a8ad 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -6,14 +6,14 @@ config HAVE_MVEBU_EFUSE
 
 config ARMADA_32BIT
 	bool
+	select ARCH_MISC_INIT
+	select BOARD_EARLY_INIT_F
 	select CPU_V7A
-	select SUPPORT_SPL
 	select SPL_DM
 	select SPL_DM_SEQ_ALIAS
 	select SPL_OF_CONTROL
 	select SPL_SIMPLE_BUS
-	select BOARD_EARLY_INIT_F
-	select ARCH_MISC_INIT
+	select SUPPORT_SPL
 
 config ARMADA_64BIT
 	bool
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index f4babc8d2600..76a19064c9b1 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -6,11 +6,11 @@ choice
 
 config OMAP34XX
 	bool "OMAP34XX SoC"
+	select ARM_CORTEX_A8_CVE_2017_5715
 	select ARM_ERRATA_430973
 	select ARM_ERRATA_454179
 	select ARM_ERRATA_621766
 	select ARM_ERRATA_725233
-	select ARM_CORTEX_A8_CVE_2017_5715
 	select USE_TINY_PRINTF
 	imply NAND_OMAP_GPMC
 	imply SPL_EXT_SUPPORT
@@ -52,9 +52,9 @@ config OMAP44XX
 
 config OMAP54XX
 	bool "OMAP54XX SoC"
+	select ARM_CORTEX_A15_CVE_2017_5715
 	select ARM_ERRATA_798870
 	select SYS_THUMB_BUILD
-	select ARM_CORTEX_A15_CVE_2017_5715
 	imply NAND_OMAP_ELM
 	imply NAND_OMAP_GPMC
 	imply SPL_DISPLAY_PRINT
@@ -116,8 +116,8 @@ config AM43XX
 
 config AM33XX
 	bool "AM33XX SoC"
-	select SPECIFY_CONSOLE_INDEX
 	select ARM_CORTEX_A8_CVE_2017_5715
+	select SPECIFY_CONSOLE_INDEX
 	imply NAND_OMAP_ELM
 	imply NAND_OMAP_GPMC
 	imply SPL_NAND_AM33XX_BCH
diff --git a/arch/arm/mach-omap2/omap5/Kconfig b/arch/arm/mach-omap2/omap5/Kconfig
index deb9873cc537..f083a4a385c5 100644
--- a/arch/arm/mach-omap2/omap5/Kconfig
+++ b/arch/arm/mach-omap2/omap5/Kconfig
@@ -23,26 +23,26 @@ config TARGET_DRA7XX_EVM
 	bool "TI DRA7XX"
 	select BOARD_LATE_INIT
 	select DRA7XX
-	select TI_I2C_BOARD_DETECT
 	select PHYS_64BIT
-	imply SCSI
+	select TI_I2C_BOARD_DETECT
 	imply DM_PMIC
-	imply PMIC_LP87565
 	imply DM_REGULATOR
 	imply DM_REGULATOR_LP87565
-	imply SPL_THERMAL
 	imply DM_THERMAL
+	imply PMIC_LP87565
+	imply SCSI
+	imply SPL_THERMAL
 	imply TI_DRA7_THERMAL
 
 config TARGET_AM57XX_EVM
 	bool "AM57XX"
 	select BOARD_LATE_INIT
+	select CMD_DDR3
 	select DRA7XX
 	select TI_I2C_BOARD_DETECT
-	select CMD_DDR3
+	imply DM_THERMAL
 	imply SCSI
 	imply SPL_THERMAL
-	imply DM_THERMAL
 	imply TI_DRA7_THERMAL
 
 endchoice
diff --git a/arch/arm/mach-qemu/Kconfig b/arch/arm/mach-qemu/Kconfig
index 726f8a7d3140..a2e4b98b8887 100644
--- a/arch/arm/mach-qemu/Kconfig
+++ b/arch/arm/mach-qemu/Kconfig
@@ -14,8 +14,8 @@ endif
 config TARGET_QEMU_ARM_32BIT
 	bool "Support qemu_arm"
 	depends on ARCH_QEMU
-	select CPU_V7A
 	select ARCH_SUPPORT_PSCI
+	select CPU_V7A
 	select SYS_ARCH_TIMER
 
 config TARGET_QEMU_ARM_64BIT
diff --git a/arch/arm/mach-rockchip/rk3288/Kconfig b/arch/arm/mach-rockchip/rk3288/Kconfig
index 6beb26fd7a68..b5447e5b6587 100644
--- a/arch/arm/mach-rockchip/rk3288/Kconfig
+++ b/arch/arm/mach-rockchip/rk3288/Kconfig
@@ -87,22 +87,22 @@ config TARGET_POPMETAL_RK3288
 config TARGET_VYASA_RK3288
 	bool "Vyasa-RK3288"
 	select BOARD_LATE_INIT
-	select TPL
+	select ROCKCHIP_BROM_HELPER
 	select SUPPORT_TPL
-	select TPL_DM
-	select TPL_REGMAP
-	select TPL_SYSCON
-	select TPL_CLK
-	select TPL_RAM
-	select TPL_OF_PLATDATA
-	select TPL_OF_CONTROL
+	select TPL
 	select TPL_BOOTROM_SUPPORT
-	select TPL_NEEDS_SEPARATE_TEXT_BASE if SPL
-	select ROCKCHIP_BROM_HELPER
+	select TPL_CLK
+	select TPL_DM
 	select TPL_DRIVERS_MISC_SUPPORT
 	select TPL_LIBCOMMON_SUPPORT
 	select TPL_LIBGENERIC_SUPPORT
+	select TPL_NEEDS_SEPARATE_TEXT_BASE if SPL
+	select TPL_OF_CONTROL
+	select TPL_OF_PLATDATA
+	select TPL_RAM
+	select TPL_REGMAP
 	select TPL_SERIAL_SUPPORT
+	select TPL_SYSCON
 	help
 	  Vyasa is a RK3288-based development board with 2 USB ports,
 	  HDMI, VGA, micro-SD card, audio, WiFi  and Gigabit Ethernet, It
diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
index 91ea742f3b10..5c1df2cf1f81 100644
--- a/arch/arm/mach-socfpga/Kconfig
+++ b/arch/arm/mach-socfpga/Kconfig
@@ -9,8 +9,8 @@ config TARGET_SOCFPGA_ARRIA5
 
 config TARGET_SOCFPGA_ARRIA10
 	bool
-	select SPL_BOARD_INIT if SPL
 	select ALTERA_SDRAM
+	select SPL_BOARD_INIT if SPL
 
 config TARGET_SOCFPGA_CYCLONE5
 	bool
@@ -23,8 +23,8 @@ config TARGET_SOCFPGA_GEN5
 config TARGET_SOCFPGA_STRATIX10
 	bool
 	select ARMV8_MULTIENTRY
-	select ARMV8_SPIN_TABLE
 	select ARMV8_SET_SMPEN
+	select ARMV8_SPIN_TABLE
 
 choice
 	prompt "Altera SOCFPGA board select"
diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
index a45f3fd77a75..cea5ee2ce54a 100644
--- a/arch/arm/mach-stm32/Kconfig
+++ b/arch/arm/mach-stm32/Kconfig
@@ -9,9 +9,9 @@ config STM32F4
 	select PINCTRL
 	select PINCTRL_STM32
 	select RAM
-	select STM32_SDRAM
 	select STM32_RCC
 	select STM32_RESET
+	select STM32_SDRAM
 	select STM32_SERIAL
 	select STM32_TIMER
 	select TIMER
@@ -25,13 +25,6 @@ config STM32F7
 	select PINCTRL
 	select PINCTRL_STM32
 	select RAM
-	select STM32_SDRAM
-	select STM32_RCC
-	select STM32_RESET
-	select STM32_SERIAL
-	select STM32_TIMER
-	select TIMER
-	select SUPPORT_SPL
 	select SPL
 	select SPL_BOARD_INIT
 	select SPL_CLK
@@ -46,13 +39,20 @@ config STM32F7
 	select SPL_OF_CONTROL
 	select SPL_OF_LIBFDT
 	select SPL_OF_TRANSLATE
-	imply SPL_OS_BOOT
 	select SPL_PINCTRL
 	select SPL_RAM
 	select SPL_SERIAL_SUPPORT
 	select SPL_SYS_MALLOC_SIMPLE
 	select SPL_TIMER
 	select SPL_XIP_SUPPORT
+	select STM32_RCC
+	select STM32_RESET
+	select STM32_SDRAM
+	select STM32_SERIAL
+	select STM32_TIMER
+	select SUPPORT_SPL
+	select TIMER
+	imply SPL_OS_BOOT
 
 config STM32H7
 	bool "stm32h7 family"
@@ -64,9 +64,9 @@ config STM32H7
 	select PINCTRL_STM32
 	select RAM
 	select REGMAP
-	select STM32_SDRAM
 	select STM32_RCC
 	select STM32_RESET
+	select STM32_SDRAM
 	select STM32_SERIAL
 	select STM32_TIMER
 	select SYSCON
diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig
index a07add68fd20..6fa31ea0a16c 100644
--- a/arch/arm/mach-tegra/tegra124/Kconfig
+++ b/arch/arm/mach-tegra/tegra124/Kconfig
@@ -6,16 +6,16 @@ choice
 
 config TARGET_APALIS_TK1
 	bool "Toradex Apalis TK1 module"
+	select ARCH_SUPPORT_PSCI
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
-	select ARCH_SUPPORT_PSCI
 
 config TARGET_JETSON_TK1
 	bool "NVIDIA Tegra124 Jetson TK1 board"
+	select ARCH_SUPPORT_PSCI
 	select BOARD_LATE_INIT
 	select CPU_V7_HAS_NONSEC
 	select CPU_V7_HAS_VIRT
-	select ARCH_SUPPORT_PSCI
 
 config TARGET_CEI_TK1_SOM
 	bool "Colorado Engineering Inc Tegra124 TK1-som board"
diff --git a/arch/arm/mach-uniphier/Kconfig b/arch/arm/mach-uniphier/Kconfig
index 91bea776e6cb..bfb445a60296 100644
--- a/arch/arm/mach-uniphier/Kconfig
+++ b/arch/arm/mach-uniphier/Kconfig
@@ -5,10 +5,10 @@ config SYS_CONFIG_NAME
 
 config ARCH_UNIPHIER_32BIT
 	bool
+	select ARCH_SUPPORT_PSCI
+	select ARMV7_NONSEC
 	select CPU_V7A
 	select CPU_V7_HAS_NONSEC
-	select ARMV7_NONSEC
-	select ARCH_SUPPORT_PSCI
 
 choice
         prompt "UniPhier SoC select"
@@ -68,8 +68,8 @@ config ARCH_UNIPHIER_LD11
 config ARCH_UNIPHIER_LD20
 	bool "Enable UniPhier LD20 SoC support"
 	depends on ARCH_UNIPHIER_V8_MULTI
-	select OF_BOARD_SETUP
 	default y
+	select OF_BOARD_SETUP
 
 config ARCH_UNIPHIER_PXS3
 	bool "Enable UniPhier PXs3 SoC support"
@@ -79,8 +79,8 @@ config ARCH_UNIPHIER_PXS3
 config CACHE_UNIPHIER
 	bool "Enable the UniPhier L2 cache controller"
 	depends on ARCH_UNIPHIER_32BIT
-	select SYS_CACHE_SHIFT_7
 	default y
+	select SYS_CACHE_SHIFT_7
 	help
 	  This option allows to use the UniPhier System Cache as L2 cache.
 
diff --git a/arch/mips/mach-ath79/Kconfig b/arch/mips/mach-ath79/Kconfig
index d982b0f8e697..bc86f591df83 100644
--- a/arch/mips/mach-ath79/Kconfig
+++ b/arch/mips/mach-ath79/Kconfig
@@ -6,30 +6,30 @@ config SYS_SOC
 
 config SOC_AR933X
 	bool
+	select MIPS_TUNE_24KC
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
-	select ROM_EXCEPTION_VECTORS
-	select MIPS_TUNE_24KC
 	help
 	  This supports QCA/Atheros ar933x family SOCs.
 
 config SOC_AR934X
 	bool
+	select MIPS_TUNE_74KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
-	select MIPS_TUNE_74KC
 	help
 	  This supports QCA/Atheros ar934x family SOCs.
 
 config SOC_QCA953X
 	bool
+	select MIPS_TUNE_24KC
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
-	select ROM_EXCEPTION_VECTORS
-	select MIPS_TUNE_24KC
 	help
 	  This supports QCA/Atheros qca953x family SOCs.
 
diff --git a/arch/mips/mach-bmips/Kconfig b/arch/mips/mach-bmips/Kconfig
index 10900bf6045a..5968d5345ed7 100644
--- a/arch/mips/mach-bmips/Kconfig
+++ b/arch/mips/mach-bmips/Kconfig
@@ -20,10 +20,10 @@ choice
 
 config SOC_BMIPS_BCM3380
 	bool "BMIPS BCM3380 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
@@ -31,10 +31,10 @@ config SOC_BMIPS_BCM3380
 
 config SOC_BMIPS_BCM6318
 	bool "BMIPS BCM6318 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -42,10 +42,10 @@ config SOC_BMIPS_BCM6318
 
 config SOC_BMIPS_BCM6328
 	bool "BMIPS BCM6328 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -53,10 +53,10 @@ config SOC_BMIPS_BCM6328
 
 config SOC_BMIPS_BCM6338
 	bool "BMIPS BCM6338 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -64,10 +64,10 @@ config SOC_BMIPS_BCM6338
 
 config SOC_BMIPS_BCM6348
 	bool "BMIPS BCM6348 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_WATCHDOG
 	help
@@ -75,10 +75,10 @@ config SOC_BMIPS_BCM6348
 
 config SOC_BMIPS_BCM6358
 	bool "BMIPS BCM6358 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -86,10 +86,10 @@ config SOC_BMIPS_BCM6358
 
 config SOC_BMIPS_BCM6368
 	bool "BMIPS BCM6368 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -97,10 +97,10 @@ config SOC_BMIPS_BCM6368
 
 config SOC_BMIPS_BCM6362
 	bool "BMIPS BCM6362 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
@@ -108,10 +108,10 @@ config SOC_BMIPS_BCM6362
 
 config SOC_BMIPS_BCM63268
 	bool "BMIPS BCM63268 family"
+	select MIPS_L1_CACHE_SHIFT_4
+	select MIPS_TUNE_4KC
 	select SUPPORTS_BIG_ENDIAN
 	select SUPPORTS_CPU_MIPS32_R1
-	select MIPS_TUNE_4KC
-	select MIPS_L1_CACHE_SHIFT_4
 	select SWAP_IO_SPACE
 	select SYSRESET_SYSCON
 	help
diff --git a/arch/mips/mach-pic32/Kconfig b/arch/mips/mach-pic32/Kconfig
index 8fad4cff9126..5f13bf14ed6b 100644
--- a/arch/mips/mach-pic32/Kconfig
+++ b/arch/mips/mach-pic32/Kconfig
@@ -9,12 +9,12 @@ choice
 
 config SOC_PIC32MZDA
 	bool "Microchip PIC32MZ[DA] family"
-	select SUPPORTS_LITTLE_ENDIAN
+	select MIPS_L1_CACHE_SHIFT_4
+	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
-	select MIPS_L1_CACHE_SHIFT_4
+	select SUPPORTS_LITTLE_ENDIAN
 	select SYS_MIPS_CACHE_INIT_RAM_LOAD
-	select ROM_EXCEPTION_VECTORS
 	help
 	  This supports Microchip PIC32MZ[DA] family of microcontrollers.
 
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 13a79560b24b..8faef0ba9fc3 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -20,9 +20,9 @@ config MPC85xx
 	select CREATE_ARCH_SYMLINK
 	select SYS_FSL_DDR
 	select SYS_FSL_DDR_BE
-	imply USB_EHCI_HCD if USB
 	imply CMD_HASH
 	imply CMD_IRQ
+	imply USB_EHCI_HCD if USB
 
 config MPC86xx
 	bool "MPC86xx"
-- 
1.9.1

^ permalink raw reply related

* Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149
From: Daniel P. Berrangé @ 2018-07-23 13:55 UTC (permalink / raw)
  To: Kevin Wolf; +Cc: John Snow, qemu-block, qemu-devel, mreitz
In-Reply-To: <20180723135345.GF8817@localhost.localdomain>

On Mon, Jul 23, 2018 at 03:53:45PM +0200, Kevin Wolf wrote:
> Am 13.07.2018 um 20:12 hat John Snow geschrieben:
> > 
> > 
> > On 07/13/2018 03:10 AM, Kevin Wolf wrote:
> > > The test case uses block devices with driver=file, which causes the test
> > > to fail after commit 230ff73904 added a deprecation warning for this.
> > > Fix the test case to use driver=host_device and update the reference
> > > output accordingly.
> > > 
> > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > 
> > 149         [not run] requires password-less sudo access: sudo: a
> > password is required
> > 
> > Ah, this one hides from regression scripts quite well...
> > 
> > This test fails both before and after this patch for me, with
> > 
> > +Traceback (most recent call last):
> > +  File "149", line 525, in <module>
> > +    test_once(config, qemu_img=False)
> > +  File "149", line 336, in test_once
> > +    cryptsetup_open(config)
> > +  File "149", line 200, in cryptsetup_open
> > +    cryptsetup(args, password)
> > +  File "149", line 124, in cryptsetup
> > +    raise Exception(msg)
> > +Exception: Device qiotest-145-twofish-128-xts-plain64-sha1 already exists.
> > +Command failed with code 17: File exists
> > 
> > Am I missing some prerequisite, maybe?
> 
> Hm, sounds a bit like a failed first attempt that didn't clean up behind
> itself properly? Just guessing though.

Yeah, sounds like it failed badly enough that cleanup broke.

Can probably fix it by either rebooting, or the more nuanced:

  cryptsetup luksClose qiotest-145-twofish-128-xts-plain64-sha1

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply

* [v3,3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer
From: Robin Gong @ 2018-07-23 13:55 UTC (permalink / raw)
  To: Lucas Stach, vkoul@kernel.org, dan.j.williams@intel.com,
	s.hauer@pengutronix.de, linux@armlinux.org.uk
  Cc: dmaengine@vger.kernel.org, dl-linux-imx, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMdWNhcyBTdGFjaCBbbWFpbHRv
Omwuc3RhY2hAcGVuZ3V0cm9uaXguZGVdDQo+IFNlbnQ6IDIwMTjlubQ35pyIMjPml6UgMTg6NTQN
Cj4gVG86IFJvYmluIEdvbmcgPHlpYmluLmdvbmdAbnhwLmNvbT47IHZrb3VsQGtlcm5lbC5vcmc7
DQo+IGRhbi5qLndpbGxpYW1zQGludGVsLmNvbTsgcy5oYXVlckBwZW5ndXRyb25peC5kZTsgbGlu
dXhAYXJtbGludXgub3JnLnVrDQo+IENjOiBkbWFlbmdpbmVAdmdlci5rZXJuZWwub3JnOyBkbC1s
aW51eC1pbXggPGxpbnV4LWlteEBueHAuY29tPjsNCj4ga2VybmVsQHBlbmd1dHJvbml4LmRlOyBs
aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7DQo+IGxpbnV4LWtlcm5lbEB2Z2Vy
Lmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MyAzLzNdIGRtYWVuZ2luZTogaW14
LXNkbWE6IGFsbG9jYXRlIG1heCAyMCBiZHMgZm9yIG9uZQ0KPiB0cmFuc2Zlcg0KPiANCj4gQW0g
RGllbnN0YWcsIGRlbiAyNC4wNy4yMDE4LCAwMTo0NiArMDgwMCBzY2hyaWViIFJvYmluIEdvbmc6
DQo+ID4gSWYgbXVsdGktYmRzIHVzZWQgaW4gb25lIHRyYW5zZmVyLCBhbGwgYmRzIHNob3VsZCBi
ZSBjb25zaXN0ZW4NCj4gPiBtZW1vcnkuVG8gZWFzaWx5IGZvbGxvdyBpdCwgZW5sYXJnZSB0aGUg
ZG1hIHBvb2wgc2l6ZSBpbnRvIDIwIGJkcywgYW5kDQo+ID4gaXQgd2lsbCByZXBvcnQgZXJyb3Ig
aWYgdGhlIG51bWJlciBvZiBiZHMgaXMgb3ZlciB0aGFuIDIwLiBGb3INCj4gPiBkbWF0ZXN0LCB0
aGUgbWF4IGNvdW50IGZvciBzaW5nbGUgdHJhbnNmZXIgaXMgTlVNX0JEICoNCj4gU0RNQV9CRF9N
QVhfQ05UDQo+ID4gPSAyMCAqIDY1NTM1ID0gfjEuMjhNQi4NCj4gDQo+IEJvdGggdGhlIGNvbW1p
dCBtZXNzYWdlIGFuZCB0aGUgY29tbWVudCBuZWVkIGEgbG90IG1vcmUgY2FyZSB0byBhY3R1YWxs
eQ0KPiB0ZWxsIHdoYXQgdGhpcyBjb21taXQgaXMgdHJ5aW5nIHRvIGFjaGlldmUuIEN1cnJlbnRs
eSBJIGRvbid0IGZvbGxvdyBhdCBhbGwuIFdoYXQNCj4gZG9lcyAiY29uc2lzdGVuIiBtZWFuPyBE
byB5b3UgbWVhbiBCRHMgc2hvdWxkIGJlIGNvbnRpZ3VvdXMgaW4gbWVtb3J5Pw0KWWVzLCBCRHMg
c2hvdWxkIGJlIGNvbnRpZ3VvdXMgIG9uZSBieSBvbmUgaW4gbWVtb3J5Lg0KPiANCj4gV2hhdCBk
byB5b3UgZ2FpbiBieSBvdmVyLWFsbG9jYXRpbmcgZWFjaCBCRCBieSBhIGZhY3RvciBvZiAyMD8N
CkkgZ3Vlc3MgZG1hX3Bvb2xfYWxsb2Mgd2lsbCByZXR1cm4gZXJyb3IgaW4gc3VjaCBjYXNlLCBh
bmQgdGhlbiBjYXVzZSBkbWEgc2V0dXANCnRyYW5zZmVyIGZhaWx1cmUuDQo+IA0KPiBSZWdhcmRz
LA0KPiBMdWNhcw0KPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBSb2JpbiBHb25nIDx5aWJpbi5nb25n
QG54cC5jb20+DQo+ID4gLS0tDQo+ID4gwqBkcml2ZXJzL2RtYS9pbXgtc2RtYS5jIHwgMTcgKysr
KysrKysrKysrKysrKy0NCj4gPiDCoDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAx
IGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvaW14LXNkbWEu
YyBiL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMgaW5kZXgNCj4gPiBiNGVjMmQyLi41OTczNDg5IDEw
MDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMNCj4gPiArKysgYi9kcml2ZXJz
L2RtYS9pbXgtc2RtYS5jDQo+ID4gQEAgLTI5OCw2ICsyOTgsMTUgQEAgc3RydWN0IHNkbWFfY29u
dGV4dF9kYXRhIHsNCj4gPiA+IMKgCXUzMsKgwqBzY3JhdGNoNzsNCj4gPiDCoH0gX19hdHRyaWJ1
dGVfXyAoKHBhY2tlZCkpOw0KPiA+DQo+ID4gKy8qDQo+ID4gKyAqIEFsbCBiZHMgaW4gb25lIHRy
YW5zZmVyIHNob3VsZCBiZSBjb25zaXRlbnQgb24gU0RNQS4gVG8gZWFzaWx5DQo+ID4gK2ZvbGxv
dyBpdCxqdXN0DQo+ID4gKyAqIHNldCB0aGUgZG1hIHBvb2wgc2l6ZSBhcyB0aGUgZW5vdWdoIGJk
cy4gRm9yIGV4YW1wbGUsIGluIGRtYXRlc3QNCj4gPiArY2FzZSwgdGhlDQo+ID4gKyAqIG1heCAy
MCBiZHMgbWVhbnMgdGhlIG1heCBmb3Igc2luZ2xlIHRyYW5zZmVyIGlzIE5VTV9CRCAqDQo+ID4g
K1NETUFfQkRfTUFYX0NOVCA9IDIwDQo+ID4gKyAqICogNjU1MzUgPSB+MS4yOE1CLiAyMCBiZHMg
c3VwcG9zZWQgdG8gYmUgZW5vdWdoIGJhc2ljYWxseS5JZiBpdCdzDQo+ID4gK3N0aWxsIG5vdA0K
PiA+ICsgKiBlbm91Z2ggaW4gc29tZSBzcGVjaWZpYyBjYXNlcywgZW5sYXJnZSBpdCBoZXJlLldh
cm5pbmcgbWVzc2FnZQ0KPiA+ICt3b3VsZCBhbHNvDQo+ID4gKyAqIGFwcGVhciBpZiB0aGUgYmQg
bnVtYmVycyBpcyBvdmVyIHRoYW4gMjAuDQo+ID4gKyAqLw0KPiA+ICsjZGVmaW5lIE5VTV9CRCAy
MA0KPiA+DQo+ID4gwqBzdHJ1Y3Qgc2RtYV9lbmdpbmU7DQo+ID4NCj4gPiBAQCAtMTI3Myw3ICsx
MjgyLDcgQEAgc3RhdGljIGludCBzZG1hX2FsbG9jX2NoYW5fcmVzb3VyY2VzKHN0cnVjdA0KPiA+
IGRtYV9jaGFuICpjaGFuKQ0KPiA+ID4gwqAJCWdvdG8gZGlzYWJsZV9jbGtfYWhiOw0KPiA+DQo+
ID4gPiDCoAlzZG1hYy0+YmRfcG9vbCA9IGRtYV9wb29sX2NyZWF0ZSgiYmRfcG9vbCIsIGNoYW4t
PmRldmljZS0+ZGV2LA0KPiA+ID4gLQkJCQlzaXplb2Yoc3RydWN0IHNkbWFfYnVmZmVyX2Rlc2Ny
aXB0b3IpLA0KPiA+ID4gKwkJCQlOVU1fQkQgKiBzaXplb2Yoc3RydWN0IHNkbWFfYnVmZmVyX2Rl
c2NyaXB0b3IpLA0KPiA+ID4gwqAJCQkJMzIsIDApOw0KPiA+DQo+ID4gPiDCoAlyZXR1cm4gMDsN
Cj4gPiBAQCAtMTMxNCw2ICsxMzIzLDEyIEBAIHN0YXRpYyBzdHJ1Y3Qgc2RtYV9kZXNjDQo+ID4g
KnNkbWFfdHJhbnNmZXJfaW5pdChzdHJ1Y3Qgc2RtYV9jaGFubmVsICpzZG1hYywNCj4gPiDCoHsN
Cj4gPiA+IMKgCXN0cnVjdCBzZG1hX2Rlc2MgKmRlc2M7DQo+ID4NCj4gPiA+ICsJaWYgKGJkcyA+
IE5VTV9CRCkgew0KPiA+ID4gKwkJZGV2X2VycihzZG1hYy0+c2RtYS0+ZGV2LCAiJWQgYmRzIGV4
Y2VlZCB0aGUgbWF4ICVkXG4iLA0KPiA+ID4gKwkJCWJkcywgTlVNX0JEKTsNCj4gPiA+ICsJCWdv
dG8gZXJyX291dDsNCj4gPiA+ICsJfQ0KPiA+ICsNCj4gPiA+IMKgCWRlc2MgPSBremFsbG9jKChz
aXplb2YoKmRlc2MpKSwgR0ZQX05PV0FJVCk7DQo+ID4gPiDCoAlpZiAoIWRlc2MpDQo+ID4gPiDC
oAkJZ290byBlcnJfb3V0Ow0K
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply

* [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer
From: Robin Gong @ 2018-07-23 13:55 UTC (permalink / raw)
  To: linux-arm-kernel
In-Reply-To: <1532343252.3163.99.camel@pengutronix.de>

> -----Original Message-----
> From: Lucas Stach [mailto:l.stach at pengutronix.de]
> Sent: 2018?7?23? 18:54
> To: Robin Gong <yibin.gong@nxp.com>; vkoul at kernel.org;
> dan.j.williams at intel.com; s.hauer at pengutronix.de; linux at armlinux.org.uk
> Cc: dmaengine at vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> kernel at pengutronix.de; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org
> Subject: Re: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one
> transfer
> 
> Am Dienstag, den 24.07.2018, 01:46 +0800 schrieb Robin Gong:
> > If multi-bds used in one transfer, all bds should be consisten
> > memory.To easily follow it, enlarge the dma pool size into 20 bds, and
> > it will report error if the number of bds is over than 20. For
> > dmatest, the max count for single transfer is NUM_BD *
> SDMA_BD_MAX_CNT
> > = 20 * 65535 = ~1.28MB.
> 
> Both the commit message and the comment need a lot more care to actually
> tell what this commit is trying to achieve. Currently I don't follow at all. What
> does "consisten" mean? Do you mean BDs should be contiguous in memory?
Yes, BDs should be contiguous  one by one in memory.
> 
> What do you gain by over-allocating each BD by a factor of 20?
I guess dma_pool_alloc will return error in such case, and then cause dma setup
transfer failure.
> 
> Regards,
> Lucas
> 
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > ---
> > ?drivers/dma/imx-sdma.c | 17 ++++++++++++++++-
> > ?1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index
> > b4ec2d2..5973489 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -298,6 +298,15 @@ struct sdma_context_data {
> > > ?	u32??scratch7;
> > ?} __attribute__ ((packed));
> >
> > +/*
> > + * All bds in one transfer should be consitent on SDMA. To easily
> > +follow it,just
> > + * set the dma pool size as the enough bds. For example, in dmatest
> > +case, the
> > + * max 20 bds means the max for single transfer is NUM_BD *
> > +SDMA_BD_MAX_CNT = 20
> > + * * 65535 = ~1.28MB. 20 bds supposed to be enough basically.If it's
> > +still not
> > + * enough in some specific cases, enlarge it here.Warning message
> > +would also
> > + * appear if the bd numbers is over than 20.
> > + */
> > +#define NUM_BD 20
> >
> > ?struct sdma_engine;
> >
> > @@ -1273,7 +1282,7 @@ static int sdma_alloc_chan_resources(struct
> > dma_chan *chan)
> > > ?		goto disable_clk_ahb;
> >
> > > ?	sdmac->bd_pool = dma_pool_create("bd_pool", chan->device->dev,
> > > -				sizeof(struct sdma_buffer_descriptor),
> > > +				NUM_BD * sizeof(struct sdma_buffer_descriptor),
> > > ?				32, 0);
> >
> > > ?	return 0;
> > @@ -1314,6 +1323,12 @@ static struct sdma_desc
> > *sdma_transfer_init(struct sdma_channel *sdmac,
> > ?{
> > > ?	struct sdma_desc *desc;
> >
> > > +	if (bds > NUM_BD) {
> > > +		dev_err(sdmac->sdma->dev, "%d bds exceed the max %d\n",
> > > +			bds, NUM_BD);
> > > +		goto err_out;
> > > +	}
> > +
> > > ?	desc = kzalloc((sizeof(*desc)), GFP_NOWAIT);
> > > ?	if (!desc)
> > > ?		goto err_out;

^ permalink raw reply

* Re: [Qemu-devel] [PATCH] iotest: Fix filtering order in 226
From: Kevin Wolf @ 2018-07-23 13:55 UTC (permalink / raw)
  To: John Snow; +Cc: Max Reitz, qemu-block, qemu-devel
In-Reply-To: <4347078d-5854-ac6e-f0cd-7512cbd9f419@redhat.com>

Am 13.07.2018 um 22:14 hat John Snow geschrieben:
> 
> 
> On 07/13/2018 03:41 PM, Max Reitz wrote:
> > The test directory should be filtered before the image format, otherwise
> > the test will fail if the image format is part of the test directory,
> > like so:
> > 
> > [...]
> > -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory
> > +can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': Is a directory
> > [...]
> > 
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> 
> Too many gotchas in our test suite.
> 
> Thanks :(

Maybe we should start writing tests for our tests? ;-)

Thanks, applied to the block branch.

Kevin

^ permalink raw reply

* RE: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer
From: Robin Gong @ 2018-07-23 13:55 UTC (permalink / raw)
  To: Lucas Stach, vkoul@kernel.org, dan.j.williams@intel.com,
	s.hauer@pengutronix.de, linux@armlinux.org.uk
  Cc: dmaengine@vger.kernel.org, dl-linux-imx, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
In-Reply-To: <1532343252.3163.99.camel@pengutronix.de>

> -----Original Message-----
> From: Lucas Stach [mailto:l.stach@pengutronix.de]
> Sent: 2018年7月23日 18:54
> To: Robin Gong <yibin.gong@nxp.com>; vkoul@kernel.org;
> dan.j.williams@intel.com; s.hauer@pengutronix.de; linux@armlinux.org.uk
> Cc: dmaengine@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one
> transfer
> 
> Am Dienstag, den 24.07.2018, 01:46 +0800 schrieb Robin Gong:
> > If multi-bds used in one transfer, all bds should be consisten
> > memory.To easily follow it, enlarge the dma pool size into 20 bds, and
> > it will report error if the number of bds is over than 20. For
> > dmatest, the max count for single transfer is NUM_BD *
> SDMA_BD_MAX_CNT
> > = 20 * 65535 = ~1.28MB.
> 
> Both the commit message and the comment need a lot more care to actually
> tell what this commit is trying to achieve. Currently I don't follow at all. What
> does "consisten" mean? Do you mean BDs should be contiguous in memory?
Yes, BDs should be contiguous  one by one in memory.
> 
> What do you gain by over-allocating each BD by a factor of 20?
I guess dma_pool_alloc will return error in such case, and then cause dma setup
transfer failure.
> 
> Regards,
> Lucas
> 
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > ---
> >  drivers/dma/imx-sdma.c | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index
> > b4ec2d2..5973489 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -298,6 +298,15 @@ struct sdma_context_data {
> > >  	u32  scratch7;
> >  } __attribute__ ((packed));
> >
> > +/*
> > + * All bds in one transfer should be consitent on SDMA. To easily
> > +follow it,just
> > + * set the dma pool size as the enough bds. For example, in dmatest
> > +case, the
> > + * max 20 bds means the max for single transfer is NUM_BD *
> > +SDMA_BD_MAX_CNT = 20
> > + * * 65535 = ~1.28MB. 20 bds supposed to be enough basically.If it's
> > +still not
> > + * enough in some specific cases, enlarge it here.Warning message
> > +would also
> > + * appear if the bd numbers is over than 20.
> > + */
> > +#define NUM_BD 20
> >
> >  struct sdma_engine;
> >
> > @@ -1273,7 +1282,7 @@ static int sdma_alloc_chan_resources(struct
> > dma_chan *chan)
> > >  		goto disable_clk_ahb;
> >
> > >  	sdmac->bd_pool = dma_pool_create("bd_pool", chan->device->dev,
> > > -				sizeof(struct sdma_buffer_descriptor),
> > > +				NUM_BD * sizeof(struct sdma_buffer_descriptor),
> > >  				32, 0);
> >
> > >  	return 0;
> > @@ -1314,6 +1323,12 @@ static struct sdma_desc
> > *sdma_transfer_init(struct sdma_channel *sdmac,
> >  {
> > >  	struct sdma_desc *desc;
> >
> > > +	if (bds > NUM_BD) {
> > > +		dev_err(sdmac->sdma->dev, "%d bds exceed the max %d\n",
> > > +			bds, NUM_BD);
> > > +		goto err_out;
> > > +	}
> > +
> > >  	desc = kzalloc((sizeof(*desc)), GFP_NOWAIT);
> > >  	if (!desc)
> > >  		goto err_out;

^ permalink raw reply

* Re: [PATCH RESEND] kthread, tracing: Don't expose half-written comm when creating kthreads
From: Steven Rostedt @ 2018-07-23 13:55 UTC (permalink / raw)
  To: Snild Dolkow
  Cc: linux-kernel, Ingo Molnar, Jens Axboe, Tejun Heo,
	Greg Kroah-Hartman, Linus Torvalds, Peter Enderborg,
	Yoshitaka Seto, Oleksiy Avramchenko, KOSAKI Motohiro, John Stultz
In-Reply-To: <20180723134210.54013-1-snild@sony.com>

On Mon, 23 Jul 2018 15:42:10 +0200
Snild Dolkow <snild@sony.com> wrote:

> There was a window for racing when task->comm was being written. The
> vsnprintf function writes 16 bytes, then counts the rest, then null
> terminates. In the meantime, other threads could see the non-terminated
> comm value. In our case, it got into the trace system's saved cmdlines
> and could cause stack corruption when strcpy'd out of there.
> 
> The workaround in e09e28671 (use strlcpy in __trace_find_cmdline) was
> likely needed because of this bug.
> 
> Solved by vsnprintf:ing to a local buffer, then using set_task_comm().
> 
> Signed-off-by: Snild Dolkow <snild@sony.com>
> ---
>  kernel/kthread.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/kthread.c b/kernel/kthread.c
> index 481951bf091d..28874afbf747 100644
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -319,8 +319,10 @@ struct task_struct *__kthread_create_on_node(int (*threadfn)(void *data),
>  	task = create->result;
>  	if (!IS_ERR(task)) {
>  		static const struct sched_param param = { .sched_priority = 0 };
> +		char name[TASK_COMM_LEN];
>  
> -		vsnprintf(task->comm, sizeof(task->comm), namefmt, args);

Can you add a comment here stating something to the affect of:

		/* task is now visible to other tasks */

-- Steve

> +		vsnprintf(name, sizeof(name), namefmt, args);
> +		set_task_comm(task, name);
>  		/*
>  		 * root may have changed our (kthreadd's) priority or CPU mask.
>  		 * The kernel thread should not inherit these properties.


^ permalink raw reply

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
From: Michal Simek @ 2018-07-23 13:56 UTC (permalink / raw)
  To: u-boot
In-Reply-To: <20180723121542.GF11755@bill-the-cat>

On 23.7.2018 14:15, Tom Rini wrote:
> On Mon, Jul 23, 2018 at 08:40:51AM +0200, Michal Simek wrote:
>> On 20.7.2018 14:53, Tom Rini wrote:
>>> On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:
>>>
>>>> CMD_DM is used for debug purpose and it shouldn't be enabled by default
>>>> via Kconfig. Unfortunately this is in the tree for quite a long time
>>>> that's why solution is to use imply DM for all targets which are
>>>> enabling DM.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> Based on this discussion:
>>>> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
>>>>
>>>> Done by:
>>>> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
>>>> uniq`; do
>>>> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
>>>> done
>>>
>>> OK, I'm glad you did this, but now the (mostly) sorted lists are
>>> un-sorted.  Please update to keep them alphabetically sorted, thanks!
>>
>> How this should be sorted?
>> sorted "select" list first followed by sorted "imply" list?
> 
> Yes, that's approximately how I've been doing it.  It won't be 100%
> sorted as some arches aren't, but it should be close.  Thanks again!

Ok. Patches sent. I have done some sorting before this patch.

Thanks,
Michal

^ permalink raw reply

* [PATCH V2 0/6] mailbox: ti-msgmgr: Add support for AM654 Secure Proxy
From: Jassi Brar @ 2018-07-23 13:56 UTC (permalink / raw)
  To: linux-arm-kernel
In-Reply-To: <20180723132956.tcsuxychhlhiwz6v@kahuna>

On Mon, Jul 23, 2018 at 6:59 PM, Nishanth Menon <nm@ti.com> wrote:
> On 18:06-20180716, Nishanth Menon wrote:
>> The V2 of the series updates a minor comment in binding and picks up Rob's Reviewed-by
>>
>> Since I have'nt seen additional comments, I am assuming things are fine for v4.19.
>>
>> The following series enables support for Secure Proxy in newest addition in TI's SoC
>> portfolio - AM654 SoC (posted previously as RFC).
>>
>> The series is based on v4.18-rc1 and is available here:
>> https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-1-am6-sproxy
>>
>> There are a couple of follow on patches to be posted as well (Kconfig changes
>> for K3_ARCH and actual dts node changes).
>>
>> Changes since RFC are highlighted in each of the patches, but overall:
>> * The K3 dependency has been broken out into a seperate series independent of
>>   this.
>> * Binding has been seperated out as it's own file (even though the driver is
>>   reused).
>>
>> Consolidated all patches (including all series) are available here:
>> https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-am6-integ
>>
>> Full Boot log  on AM654 (integrated with all patch series) is available here:
>>    https://pastebin.ubuntu.com/p/bBFmnzYtCd/
>>
>> Nishanth Menon (6):
>>   mailbox: ti-msgmgr: Get rid of unused structure members
>>   mailbox: ti-msgmgr: Allocate Rx channel resources only on request
>>   mailbox: ti-msgmgr: Change message count mask to be descriptor based
>>   mailbox: ti-msgmgr: Move the memory region name to descriptor
>>   dt-bindings: mailbox: Add support for secure proxy threads
>>   mailbox: ti-msgmgr: Add support for Secure Proxy
>>
>>  .../bindings/mailbox/ti,secure-proxy.txt           |  50 +++
>>  drivers/mailbox/ti-msgmgr.c                        | 353 +++++++++++++++++----
>>  2 files changed, 336 insertions(+), 67 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt
>
>
> Jassi,
>
> I dont see this in next-20180723. You'd asked me to hold off on pings
> https://lkml.org/lkml/2017/12/16/353 -> so, held off as much as I could
> before wondering on the status.
>
I didn't ask you to not ping me. I said I didn't miss your patchset. I
still didn't.

Especially for purely platform specific changes, that I don't have
knowledge about, I leave them to cook in public as long as possible,
before pulling them in around rc7.
You submitted V2, 7days ago only and we are at rc6 today. So chill.

^ permalink raw reply

* Re: [PATCH V2 0/6] mailbox: ti-msgmgr: Add support for AM654 Secure Proxy
From: Jassi Brar @ 2018-07-23 13:56 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Mark Rutland, Rob Herring, Suman Anna, Tero Kristo,
	Linux Kernel Mailing List, Devicetree List,
	, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream
In-Reply-To: <20180723132956.tcsuxychhlhiwz6v@kahuna>

On Mon, Jul 23, 2018 at 6:59 PM, Nishanth Menon <nm@ti.com> wrote:
> On 18:06-20180716, Nishanth Menon wrote:
>> The V2 of the series updates a minor comment in binding and picks up Rob's Reviewed-by
>>
>> Since I have'nt seen additional comments, I am assuming things are fine for v4.19.
>>
>> The following series enables support for Secure Proxy in newest addition in TI's SoC
>> portfolio - AM654 SoC (posted previously as RFC).
>>
>> The series is based on v4.18-rc1 and is available here:
>> https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-1-am6-sproxy
>>
>> There are a couple of follow on patches to be posted as well (Kconfig changes
>> for K3_ARCH and actual dts node changes).
>>
>> Changes since RFC are highlighted in each of the patches, but overall:
>> * The K3 dependency has been broken out into a seperate series independent of
>>   this.
>> * Binding has been seperated out as it's own file (even though the driver is
>>   reused).
>>
>> Consolidated all patches (including all series) are available here:
>> https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-am6-integ
>>
>> Full Boot log  on AM654 (integrated with all patch series) is available here:
>>    https://pastebin.ubuntu.com/p/bBFmnzYtCd/
>>
>> Nishanth Menon (6):
>>   mailbox: ti-msgmgr: Get rid of unused structure members
>>   mailbox: ti-msgmgr: Allocate Rx channel resources only on request
>>   mailbox: ti-msgmgr: Change message count mask to be descriptor based
>>   mailbox: ti-msgmgr: Move the memory region name to descriptor
>>   dt-bindings: mailbox: Add support for secure proxy threads
>>   mailbox: ti-msgmgr: Add support for Secure Proxy
>>
>>  .../bindings/mailbox/ti,secure-proxy.txt           |  50 +++
>>  drivers/mailbox/ti-msgmgr.c                        | 353 +++++++++++++++++----
>>  2 files changed, 336 insertions(+), 67 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt
>
>
> Jassi,
>
> I dont see this in next-20180723. You'd asked me to hold off on pings
> https://lkml.org/lkml/2017/12/16/353 -> so, held off as much as I could
> before wondering on the status.
>
I didn't ask you to not ping me. I said I didn't miss your patchset. I
still didn't.

Especially for purely platform specific changes, that I don't have
knowledge about, I leave them to cook in public as long as possible,
before pulling them in around rc7.
You submitted V2, 7days ago only and we are at rc6 today. So chill.

^ permalink raw reply

* Re: [PATCH] drm/amd/powerplay: allow slow switch only if NBPState enabled v2
From: Deucher, Alexander @ 2018-07-23 13:56 UTC (permalink / raw)
  To: Quan, Evan,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
  Cc: Zhu, Rex
In-Reply-To: <20180723063746.20299-1-evan.quan-5C7GfCeVMHo@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 2701 bytes --]

Acked-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
Sent: Monday, July 23, 2018 2:37:46 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: allow slow switch only if NBPState enabled v2

Otherwise there may be potential SMU performance issues.

v2: fix commit description and coding style

Change-Id: I05a09bb05407f7b3705d79a1d2c6628385c80461
Signed-off-by: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 ++-
 drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index 002ed77a5268..a05de8e39d6a 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -3781,7 +3781,8 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(
         struct pp_display_clock_request clock_req;

         if ((hwmgr->display_config->num_display > 1) &&
-            !hwmgr->display_config->multi_monitor_in_sync)
+            !hwmgr->display_config->multi_monitor_in_sync &&
+            !hwmgr->display_config->nb_pstate_switch_disable)
                 vega10_notify_smc_display_change(hwmgr, false);
         else
                 vega10_notify_smc_display_change(hwmgr, true);
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
index 35f96dacb50a..0789d64246ca 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
@@ -1389,7 +1389,8 @@ static int vega12_notify_smc_display_config_after_ps_adjustment(
         struct pp_display_clock_request clock_req;

         if ((hwmgr->display_config->num_display > 1) &&
-               !hwmgr->display_config->multi_monitor_in_sync)
+            !hwmgr->display_config->multi_monitor_in_sync &&
+            !hwmgr->display_config->nb_pstate_switch_disable)
                 vega12_notify_smc_display_change(hwmgr, false);
         else
                 vega12_notify_smc_display_change(hwmgr, true);
--
2.18.0

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 4792 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related

* Re: Documentation for libraries
From: Karel Zak @ 2018-07-23 12:55 UTC (permalink / raw)
  To: Edward Diener; +Cc: util-linux
In-Reply-To: <c1ad48a2-46b9-c694-7610-c463ba453f4d@tropicsoft.com>

On Mon, Jul 23, 2018 at 08:33:52AM -0400, Edward Diener wrote:
> Where is there documentation for using libblkid and libfdisk, either online
> or part of the util-linux package ?

See lib*-docs dirs for generated reference manual:

https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.32/

we have also lib*/samples/ dirs with some very basic stuff in our
source tree.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply

* Re: [PATCH v2 00/19]  Fixes for sched/numa_balancing
From: Peter Zijlstra @ 2018-07-23 13:57 UTC (permalink / raw)
  To: Srikar Dronamraju
  Cc: Ingo Molnar, LKML, Mel Gorman, Rik van Riel, Thomas Gleixner
In-Reply-To: <1529514181-9842-1-git-send-email-srikar@linux.vnet.ibm.com>

On Wed, Jun 20, 2018 at 10:32:41PM +0530, Srikar Dronamraju wrote:
> Srikar Dronamraju (19):
>   sched/numa: Remove redundant field.
>   sched/numa: Evaluate move once per node
>   sched/numa: Simplify load_too_imbalanced
>   sched/numa: Set preferred_node based on best_cpu
>   sched/numa: Use task faults only if numa_group is not yet setup
>   sched/debug: Reverse the order of printing faults
>   sched/numa: Skip nodes that are at hoplimit
>   sched/numa: Remove unused task_capacity from numa_stats
>   sched/numa: Modify migrate_swap to accept additional params
>   sched/numa: Restrict migrating in parallel to the same node.
>   sched/numa: Remove numa_has_capacity
>   sched/numa: Use group_weights to identify if migration degrades locality
>   sched/numa: Move task_placement closer to numa_migrate_preferred

I took the above, but left the below for next time.

>   sched/numa: Stop multiple tasks from moving to the cpu at the same time
>   mm/migrate: Use xchg instead of spinlock
>   sched/numa: Updation of scan period need not be in lock
>   sched/numa: Detect if node actively handling migration
>   sched/numa: Pass destination cpu as a parameter to migrate_task_rq
>   sched/numa: Reset scan rate whenever task moves across nodes

^ permalink raw reply

* Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223
From: Kevin Wolf @ 2018-07-23 13:57 UTC (permalink / raw)
  To: Max Reitz; +Cc: qemu-block, qemu-devel, John Snow
In-Reply-To: <20180713191506.14484-1-mreitz@redhat.com>

Am 13.07.2018 um 21:15 hat Max Reitz geschrieben:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Thanks, applied to the block branch.

Kevin

^ permalink raw reply

* [PATCH 6/6] ARM: imx_v6_v7_defconfig: Select CONFIG_DRM_PANEL_SEIKO_43WVF1G
From: Fabio Estevam @ 2018-07-23 13:57 UTC (permalink / raw)
  To: linux-arm-kernel
In-Reply-To: <1532119161-16597-6-git-send-email-festevam@gmail.com>

Hi Shawn,

On Fri, Jul 20, 2018 at 5:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> imx6sl-evk, imx6sll-evk and imx6sx-sdb boards use a Seiko 43WVF1G panel.
>
> Now that the DRM mxsfb driver is the one selected by default, let's
> also select CONFIG_DRM_PANEL_SEIKO_43WVF1G so that these boards continue
> to have a working display by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

I understand you have already submitted the imx 4.19 material to Olof
and he has already merged it.

Without this series we will have many NXP development boards without
functional display in 4.19 by default due to the drm mxsfb conversion
in defconfig, which would not be a very good user experience.

I would like to kindly ask you to consider applying this series to 4.19 as well.

Thanks

^ permalink raw reply


This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.