Re: [PATCH v2 12/24] dt-bindings: PCI: Add ZTE ZX279128S host controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: pci: custom enable-gpios bypasses regulator framework
--

commit 4e7065d52cc5c001e2bd9b479582baa2dabea3c6
Author: Navid Ghahremani <ghahramani.navid@gmail.com>

dt-bindings: PCI: Add ZTE ZX279128S host controller

This commit adds the Device Tree binding for the DesignWare PCIe host
controller on the ZTE ZX279128S SoC. It defines the required registers,
interrupts, clocks, resets, and PHYs. It also introduces optional board-level
GPIOs for resets and enable lines.

> diff --git a/Documentation/devicetree/bindings/pci/zte,zx279128s-pcie.yaml b/Documentation/devicetree/bindings/pci/zte,zx279128s-pcie.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/zte,zx279128s-pcie.yaml
[ ... ]
> +  reset-gpios:
> +    maxItems: 1
> +    description: Optional board GPIO reset line for downstream endpoints.
> +
> +  enable-gpios:
> +    maxItems: 1
> +    description: Optional second board GPIO enable line driven together with reset-gpios.

[Severity: Low]
Does this custom enable-gpios property bypass the regulator framework?

In Device Tree, board power or enable lines should typically be modeled using
standard regulator bindings (such as vpcie-supply) linked to a regulator-fixed
node, rather than using hardcoded raw GPIO properties directly in the PCIe
controller node.

A review of existing PCI bindings shows no other uses of enable-gpios. Could
this be modeled with a standard regulator instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014072109.1759502-1-ghahramani.navid@gmail.com?part=12