Re: [PATCH 03/25] dt-bindings: reset: add Metanoia MT2824

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: reset: unused label and non-standard node name in
  example
- [Low] dt-bindings: reset: schema filename does not match compatible
  string
--

commit 3bb1ac6d86be7fa6908083c0f43ed9c390788baa
Author: Benoît Monin <benoit.monin@bootlin.com>

dt-bindings: reset: add Metanoia MT2824

This commit adds the Devicetree binding schema for the Metanoia MT2824
reset controller.

> diff --git a/Documentation/devicetree/bindings/reset/metanoia,reset.yaml b/Documentation/devicetree/bindings/reset/metanoia,reset.yaml
> new file mode 100644
> index 0000000000000..f169d1fa919cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/metanoia,reset.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/metanoia,reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Metanoia Reset Controller
> +
> +maintainers:
> +  - Jun Chang <jun.chang@metanoia-comm.com>
> +
> +description:
> +  Metanoia reset controllers provide warm-reset and system reset controls
> +  via memory-mapped registers.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - metanoia,mt2824-reset

[Severity: Low]
Should this schema file and its $id be named metanoia,mt2824-reset.yaml to
match the compatible string, as required by
Documentation/devicetree/bindings/writing-bindings.rst?  With a single
compatible string, compatible can also use const rather than enum.

[ ... ]

> +examples:
> +  - |
> +    rst: rst-controller@1000000c {
> +        compatible = "metanoia,mt2824-reset";
> +        reg = <0x1000000c 0x4>;
> +        #reset-cells = <1>;
> +    };

[Severity: Low]
Should the unreferenced rst label be dropped and the node renamed to
reset-controller@1000000c?  The unused rst label causes
scripts/dtc/dt-check-style --mode=strict to fail with an unused-labels
error, and reset-controller is the standard generic node name for reset
controllers.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-mt2824-v1-0-86087eaf5af4@bootlin.com?part=3