Re: [PATCH 05/25] dt-bindings: phy: add Metanoia USB2 PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: phy: metanoia: invalid example node name and unused
  label
- [Low] dt-bindings: phy: metanoia: reset-only node, reset-names, and
  filename
--

commit 1ecf2c434e4f801fa49e7ae94a833a554c762ead
Author: Benoît Monin <benoit.monin@bootlin.com>

dt-bindings: phy: add Metanoia USB2 PHY

This commit adds the devicetree binding schema for the USB2 PHY on the
Metanoia MT2824 SoC.

> diff --git a/Documentation/devicetree/bindings/phy/metanoia,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/metanoia,usb2-phy.yaml
> new file mode 100644
> index 0000000000000..0605e6d0f67da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/metanoia,usb2-phy.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/metanoia,usb2-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Metanoia USB2 PHY
> +
> +description: |
> +  The Metanoia MT2824 USB2 PHY is controlled solely through a reset line.
> +
> +maintainers:
> +  - Jun Chang <jun.chang@metanoia-comm.com>
> +
> +properties:
> +  compatible:
> +    const: metanoia,mt2824-usb2-phy
> +
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    const: usb2-phy

[Severity: Low]
Should this binding describe the full PHY hardware block (such as its
registers, clocks, or power supplies), or if the interface is only a single
reset line, should that reset be referenced directly by the USB controller
node rather than wrapped in a standalone virtual node?

Also, per Documentation/devicetree/bindings/example-schema.yaml,
reset-names should be omitted when there is only a single reset entry that
repeats the block name, and the schema filename and $id should match the
sole compatible string (metanoia,mt2824-usb2-phy.yaml).

> +
> +  "#phy-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - resets
> +  - reset-names
> +  - "#phy-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb2phy: usb2-phy-reset {
> +        compatible = "metanoia,mt2824-usb2-phy";
> +        #phy-cells = <0>;
> +        resets = <&rst 18>;
> +        reset-names = "usb2-phy";
> +    };

[Severity: Low]
Does the example node name usb2-phy-reset fail dt_binding_check?

Because the node defines #phy-cells, phy-provider.yaml requires $nodename
to match ^(|usb-|usb2-|usb3-|pci-|pcie-|sata-)phy(@[0-9a-f,]+)*$ (for
example, phy or usb2-phy).  In addition, the unreferenced usb2phy: label
triggers an unused-labels warning under scripts/dtc/dt-check-style
--mode=strict and should be dropped.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-mt2824-v1-0-86087eaf5af4@bootlin.com?part=5