Re: [PATCH 04/25] dt-bindings: power: reset: add Metanoia MT2824 reboot

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: power: reset: strict style errors in
  metanoia,reboot.yaml
- [Low] dt-bindings: power: reset: metanoia,reboot splits single
  register into node
--

commit 07f8018b51cb794baf4c572ad7951597d891f410
Author: Benoît Monin <benoit.monin@bootlin.com>

dt-bindings: power: reset: add Metanoia MT2824 reboot

This commit adds a Devicetree binding schema for the Metanoia MT2824 warm
reboot controller register used by machine-mode firmware.

> diff --git a/Documentation/devicetree/bindings/power/reset/metanoia,reboot.yaml b/Documentation/devicetree/bindings/power/reset/metanoia,reboot.yaml
> new file mode 100644
> index 0000000000000..2670fe7ab93f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/metanoia,reboot.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/metanoia,reboot.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Metanoia MT2824 Reboot Controller
> +
> +maintainers:
> +  - Jun Chang <jun.chang@metanoia-comm.com>
> +
> +description:
> +  The Metanoia MT2824 reboot controller provides a system warm reboot through
> +  a memory-mapped register. It is used by the firmware in machine mode.
> +
> +properties:
> +  compatible:
> +    const: metanoia,mt2824-reboot
> +
> +  reg:
> +    maxItems: 1

[Severity: Low]
Should this warm-reboot register and the adjacent reset controller
register be described as a single hardware block instead of separate
Devicetree nodes?

This binding models an 8-byte register range at 0x10000004 for
machine-mode firmware, while
Documentation/devicetree/bindings/reset/metanoia,reset.yaml models the
immediately adjacent 4-byte register at 0x1000000c for the OS reset
driver:

Documentation/devicetree/bindings/reset/metanoia,reset.yaml:
    rst: rst-controller@1000000c {
        compatible = "metanoia,mt2824-reset";
        reg = <0x1000000c 0x4>;
        #reset-cells = <1>;
    };

Carving individual registers of the same IP block into separate nodes
encodes software driver boundaries into the Devicetree ABI.

[ ... ]

> +examples:
> +  - |
> +    reboot: reboot@10000004 {
> +      compatible = "metanoia,mt2824-reboot";
> +      reg = <0x10000004 0x8>;
> +    };

[Severity: Low]
Does this example pass scripts/dtc/dt-check-style --mode=strict?

The example defines an unreferenced label (reboot:) and indents the node
properties by 2 spaces instead of 4, which triggers unused-labels and
indent-unit-strict warnings.  Also, should the schema filename and $id be
metanoia,mt2824-reboot.yaml to match the sole compatible string?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-mt2824-v1-0-86087eaf5af4@bootlin.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy