Re: [PATCH 07/10] arm64: dts: amlogic: meson-s4: add the GE2D - sashiko-bot

From: sashiko-bot@kernel.org
To: christian.koever-draxl@student.uibk.ac.at
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH 07/10] arm64: dts: amlogic: meson-s4: add the GE2D
Date: Fri, 06 Nov 2026 10:53:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-201239@kernel.org> (raw)
In-Reply-To: <20261106104659.54656-8-christian.koever-draxl@student.uibk.ac.at>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: amlogic: meson-s4: ge2d node missing
  amlogic,axg-ge2d fallback
--

commit 0db40a28ab18ba3c72a34659bd708d3e86073c70
Author: Christian Stefan Kövér-Draxl <ckoever@outlook.de>

arm64: dts: amlogic: meson-s4: add the GE2D

This commit adds the GE2D 2D graphics accelerator node to the Amlogic S4 SoC
devicetree.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 1e8b845b80c31..8bbd70e52a299 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -199,6 +199,16 @@ soc {
>  		#size-cells = <2>;
>  		ranges;
>  
> +		ge2d: ge2d@ff040000 {
> +			compatible = "amlogic,s4-ge2d";
> +			reg = <0x0 0xff040000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 217 IRQ_TYPE_EDGE_RISING>;
> +			clocks = <&clkc_periphs CLKID_GE2D>;
> +			resets = <&reset RESET_GE2D>;
> +			power-domains = <&pwrc PWRC_S4_GE2D_ID>;
> +			status = "disabled";
> +		};

[Severity: Medium]
Should the ge2d node include "amlogic,axg-ge2d" as a fallback compatible string?

meson_ge2d_match in drivers/media/platform/amlogic/meson-ge2d/ge2d.c only
matches "amlogic,axg-ge2d", so without the fallback compatible the driver will
never bind when this node is enabled.  In addition,
Documentation/devicetree/bindings/media/amlogic,axg-ge2d.yaml sets
additionalProperties: false and does not document "amlogic,s4-ge2d" or
power-domains, which causes dtbs_check to fail.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at?part=7

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic