Re: [PATCH 04/10] arm64: dts: amlogic: meson-s4: use the S4 secure monitor compatible - sashiko-bot

From: sashiko-bot@kernel.org
To: christian.koever-draxl@student.uibk.ac.at
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH 04/10] arm64: dts: amlogic: meson-s4: use the S4 secure monitor compatible
Date: Fri, 06 Nov 2026 10:54:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-201242@kernel.org> (raw)
In-Reply-To: <20261106104659.54656-5-christian.koever-draxl@student.uibk.ac.at>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: amlogic: meson-s4: undocumented and unhandled
  amlogic,meson-s4-sm compatible
--

commit 7614308a3cef6b940646583a9f25a7b443724222
Author: Christian Stefan Kövér-Draxl <ckoever@outlook.de>

arm64: dts: amlogic: meson-s4: use the S4 secure monitor compatible

This commit adds the "amlogic,meson-s4-sm" compatible string to the
secure-monitor node in the Meson S4 device tree include.

> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> index 57270fbfb4a73..793c7bb9512eb 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi
> @@ -135,7 +135,7 @@ xtal: xtal-clk {
>  
>  	firmware {
>  		sm: secure-monitor {
> -			compatible = "amlogic,meson-gxbb-sm";
> +			compatible = "amlogic,meson-s4-sm", "amlogic,meson-gxbb-sm";

[Severity: Medium]
Does adding "amlogic,meson-s4-sm" break dtbs_check on Meson S4 boards?

Documentation/devicetree/bindings/firmware/amlogic,meson-gxbb-sm.yaml only
permits "amlogic,meson-gxbb-sm" or "amlogic,meson-gx-sm" followed by
"amlogic,meson-gxbb-sm".  In addition, meson_sm_ids[] in
drivers/firmware/meson/meson_sm.c only matches "amlogic,meson-gxbb-sm" and no
driver in the tree handles "amlogic,meson-s4-sm" or implements an S4
power-off sequence.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106104659.54656-1-christian.koever-draxl@student.uibk.ac.at?part=4

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic