Re: [PATCH 2/3] perf jevents: Make the model argument optional

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf jevents: missing Fixes trailer for unreachable model
  default
--

commit b4da888ac73bbe46e6f0c875cda7b46a6a7699ff
Author: TAKANO Mitsuhiro <takano32@gmail.com>

> perf jevents: Make the model argument optional
>
> The model argument carries a default of "all", but a positional argument
> with a default and no nargs is still required: "jevents.py x86 <dir>" exits
> with "the following arguments are required: model", and so does any caller
> that only wants the tables for an architecture.
>
> Make it nargs='?' so the default is reachable and an omitted model means
> "all".  Builds pass it explicitly, so the generated tables do not change.
>
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>

[Severity: Low]
Since 5a09b1fd1b1f ("perf jevents: Add model list option") added the
positional model argument with default='all' without nargs='?', should this
include:

  Fixes: 5a09b1fd1b1f ("perf jevents: Add model list option")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110222250.1864777-1-takano32@gmail.com?part=2