Re: [PATCH v5 3/3] perf jevents: Check the JSON keys a table may carry

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf tests: jevents_check.sh truncates test description and
  omits (no_mlock)
--

commit 92181aaa26288cfbfa72d268994737820fd76f90
Author: TAKANO Mitsuhiro <takano32@gmail.com>

perf jevents: Check the JSON keys a table may carry

This commit adds a --check option to jevents.py to validate JSON keys in
pmu-events tables, along with a check-jevents make target and a shell test.

> diff --git a/tools/perf/tests/shell/jevents_check.sh b/tools/perf/tests/shell/jevents_check.sh
> new file mode 100755
> index 0000000000000..311ca5f5ab15e
> --- /dev/null
> +++ b/tools/perf/tests/shell/jevents_check.sh
> @@ -0,0 +1,62 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# perf jevents tests: --check reports a key the generator does not read, and an
> +# architecture that is not there is an error rather than a clean tree.

[Severity: Low]
Does wrapping this header comment across two lines truncate the test
description in perf test?

In tools/perf/tests/tests-scripts.c, shell_test__description() reads only
the first non-shebang, non-SPDX comment line and stops, so perf test list
displays "perf jevents tests: --check reports a key the generator does not
read, and an".

Also, append_script() and shell_test__requisites() default needs_mlock to
true unless that single-line description ends with "(no_mlock)". Since this
script only runs jevents.py on temporary JSON files and never maps perf
event ring buffers, could the first comment line be a single-line
description ending with "(no_mlock)"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111132622.2349165-1-takano32@gmail.com?part=3