Re: [PATCH v6 3/3] perf jevents: Check the JSON keys a table may carry

[sashiko-bot@kernel.org]

> jevents.py takes the fields it wants out of each JSON object by name -
> jd.get('BriefDescription'), 'EventCode' in jd, jd['ExtSel'], and the
> fourteen names in event_fields that it looks for with 'key in jd' - so a
> key spelled another way is dropped without a word and the object is built
> without whatever that field held.  Nothing in the build and nothing in the
> generated table says so.
> 
> Two of those are in the tree.  "PublicDescrition" is in 16 of the 28
> entries of arm64/ampere/ampereonex/mmu.json, where the long description
> each of them lost repeated the BriefDescription, which is why it could sit
> there unnoticed.  "BriefDescript6ion" is in one entry each of
> amdzen4/cache.json, amdzen5/load-store.json and amdzen6/load-store.json,
> and those objects carry no other description, so ls_inef_sw_pref.all is
> generated with an empty text field on Zen 4, 5 and 6.
> 
> [ ... ]
> 
> The two misspellings in the tree are fixed by separate patches; until they
> are applied the target reports them, which is what it is for.
> 
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111150920.2383157-1-takano32@gmail.com?part=3