Re: [PATCH v4 3/3] perf jevents: Check the JSON keys that jevents.py never reads

[sashiko-bot@kernel.org]

> jevents.py takes the fields it wants out of each JSON object by name:
> jd.get('BriefDescription'), 'EventCode' in jd, and the names in
> event_fields. A key spelled another way is dropped without a word, and
> the object is built without whatever that field held.
> 
> Two of those are in the tree now. "BriefDescript6ion" is in one entry
> each of amdzen4/cache.json, amdzen5/load-store.json and amdzen6/load-
> store.json, and since those objects carry no other description,
> ls_inef_sw_pref.all is generated with an empty text field.
> "PublicDescrition" was in 16 of the 28 entries of
> arm64/ampere/ampereonex/mmu.json; nothing a user saw changed there,
> because each of the 16 also had a BriefDescription with the same text,
> which is why the typo could sit there unnoticed.
> 
> Add a --check mode that reads every architecture, not just the one being
> [ ... ]
> perf with it, ran the perf test above, ran the check over the whole
> tree, compared the generated tables with those from an unpatched tree on
> x86, arm64 and all architectures at once, and ran mypy on jevents.py.
> 
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111041045.2031464-1-takano32@gmail.com?part=3