All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org,
	conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
	olteanv@gmail.com
Subject: Re: [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller
Date: Mon, 16 Nov 2026 13:31:37 +0000	[thread overview]
Message-ID: <sashiko-outbox-217082@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-2-e3d3bf0e2c49@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: msm: dp-controller: qcom,nord-dp not in
  alphabetical order
--

commit 0ec7842c5ba3651d6f0a3de03165ad9984fb8e75
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>

dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller

This commit adds the qcom,nord-dp compatible string to the qcom,sa8775p-dp
fallback group in the MSM DisplayPort controller binding.

> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 094a6383bb779..9be0288261e72 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -35,6 +35,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,qcs8300-dp
> +              - qcom,nord-dp
>            - const: qcom,sa8775p-dp

[Severity: Low]
This isn't a bug, but qcom,nord-dp should be placed before qcom,qcs8300-dp
to keep the compatible enum list sorted alphabetically like the rest of
the binding.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, robh@kernel.org,
	conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
	olteanv@gmail.com
Subject: Re: [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller
Date: Mon, 16 Nov 2026 13:31:37 +0000	[thread overview]
Message-ID: <sashiko-outbox-217082@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-2-e3d3bf0e2c49@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: msm: dp-controller: qcom,nord-dp not in
  alphabetical order
--

commit 0ec7842c5ba3651d6f0a3de03165ad9984fb8e75
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>

dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller

This commit adds the qcom,nord-dp compatible string to the qcom,sa8775p-dp
fallback group in the MSM DisplayPort controller binding.

> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 094a6383bb779..9be0288261e72 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -35,6 +35,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,qcs8300-dp
> +              - qcom,nord-dp
>            - const: qcom,sa8775p-dp

[Severity: Low]
This isn't a bug, but qcom,nord-dp should be placed before qcom,qcs8300-dp
to keep the compatible enum list sorted alphabetically like the rest of
the binding.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=2

  reply	other threads:[~2026-11-16 13:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:31   ` sashiko-bot [this message]
2026-11-16 13:31     ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:38   ` sashiko-bot
2026-11-16 13:38     ` sashiko-bot
2026-11-17 15:23   ` Rob Herring (Arm)
2026-11-17 15:23     ` Rob Herring (Arm)
2026-11-18  4:51   ` Shawn Guo
2026-11-18  4:51     ` Shawn Guo
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:47   ` sashiko-bot
2026-11-16 13:47     ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:29   ` sashiko-bot
2026-11-16 13:29     ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:30   ` sashiko-bot
2026-11-16 13:30     ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
2026-11-16 13:16   ` Nabige Aala
2026-11-16 13:44   ` sashiko-bot
2026-11-16 13:44     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217082@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=nabige.aala@oss.qualcomm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.