From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
Date: Mon, 16 Nov 2026 13:38:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-217094@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-3-e3d3bf0e2c49@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: display/msm: qcom,nord-mdss omits
qcom,sa8775p-dp fallback
- [Low] dt-bindings: display/msm: inconsistent DP1 clocks and PHY reg
sizes in example
--
commit 7e933ce5ebfd089e4cac22428484f5b572292bc8
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
dt-bindings: display/msm: Document Nord MDSS
This commit adds the devicetree binding schema for the Qualcomm Nord
display subsystem (MDSS 12.1).
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> new file mode 100644
> index 0000000000000..abd80dae4e7f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
[ ... ]
> + "^displayport-controller@[0-9a-f]+$":
> + type: object
> + additionalProperties: true
> + properties:
> + compatible:
> + const: qcom,nord-dp
[Severity: Medium]
Should the compatible constraint here allow the "qcom,sa8775p-dp" fallback,
and should both displayport-controller nodes in the example below include
it?
Documentation/devicetree/bindings/display/msm/dp-controller.yaml requires
"qcom,nord-dp" to be followed by "qcom,sa8775p-dp":
Documentation/devicetree/bindings/display/msm/dp-controller.yaml
- items:
- enum:
- qcom,qcs8300-dp
- qcom,nord-dp
- const: qcom,sa8775p-dp
Using "const: qcom,nord-dp" here rejects the required fallback, and
omitting "qcom,sa8775p-dp" from displayport-controller@af54000 and
displayport-controller@af5c000 in the example causes dt_binding_check to
fail against dp-controller.yaml. Using "contains: const: qcom,nord-dp"
(as in qcom,qcs8300-mdss.yaml) and adding "qcom,sa8775p-dp" to the example
nodes would resolve this.
[ ... ]
> + displayport-controller@af5c000 {
> + compatible = "qcom,nord-dp";
> +
> + reg = <0xaf5c000 0x200>,
> + <0xaf5c200 0x200>,
> + <0xaf5d000 0xc00>,
> + <0xaf5e000 0x400>,
> + <0xaf5f000 0x400>,
> + <0xaf60000 0x400>,
> + <0xaf61000 0x400>,
> + <0xaf62000 0x600>,
> + <0xaf63000 0x600>;
> +
> + clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_INTF_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK>;
> + clock-names = "core_iface", "core_aux",
> + "ctrl_link", "ctrl_link_iface",
> + "stream_pixel", "stream_1_pixel",
> + "stream_2_pixel", "stream_3_pixel";
> +
> + assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK_SRC>;
> + assigned-clock-parents = <&dp1_phy 0>,
> + <&dp1_phy 1>,
> + <&dp1_phy 1>;
[ ... ]
> + dp1_phy: phy@fc6a00 {
> + compatible = "qcom,nord-dp-phy";
> +
> + reg = <0xfc6a00 0x200>,
> + <0xfc6200 0xd0>,
> + <0xfc6600 0xd0>,
> + <0xfc6000 0x1c8>;
[Severity: Low]
Are the assigned-clocks on displayport-controller@af5c000 and the reg sizes
on dp1_phy in the example intended to differ from the first DP instance?
displayport-controller@af5c000 requests all four stream pixel clocks in
clocks, but assigned-clocks omits MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK_SRC
and MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK_SRC (which are present on
displayport-controller@af54000). In addition, dp1_phy uses SA8775P
register sizes (0x200, 0xd0, 0xd0, 0x1c8) instead of the qcom,nord-dp-phy
sizes used by dp0_phy (0x1d0, 0x128, 0x128, 0x200), leaving the fourth
region smaller than NORD_DP_QSERDES_COM_C_READY_STATUS at offset 0x1f8.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=3
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
Date: Mon, 16 Nov 2026 13:38:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-217094@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-3-e3d3bf0e2c49@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: display/msm: qcom,nord-mdss omits
qcom,sa8775p-dp fallback
- [Low] dt-bindings: display/msm: inconsistent DP1 clocks and PHY reg
sizes in example
--
commit 7e933ce5ebfd089e4cac22428484f5b572292bc8
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
dt-bindings: display/msm: Document Nord MDSS
This commit adds the devicetree binding schema for the Qualcomm Nord
display subsystem (MDSS 12.1).
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> new file mode 100644
> index 0000000000000..abd80dae4e7f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
[ ... ]
> + "^displayport-controller@[0-9a-f]+$":
> + type: object
> + additionalProperties: true
> + properties:
> + compatible:
> + const: qcom,nord-dp
[Severity: Medium]
Should the compatible constraint here allow the "qcom,sa8775p-dp" fallback,
and should both displayport-controller nodes in the example below include
it?
Documentation/devicetree/bindings/display/msm/dp-controller.yaml requires
"qcom,nord-dp" to be followed by "qcom,sa8775p-dp":
Documentation/devicetree/bindings/display/msm/dp-controller.yaml
- items:
- enum:
- qcom,qcs8300-dp
- qcom,nord-dp
- const: qcom,sa8775p-dp
Using "const: qcom,nord-dp" here rejects the required fallback, and
omitting "qcom,sa8775p-dp" from displayport-controller@af54000 and
displayport-controller@af5c000 in the example causes dt_binding_check to
fail against dp-controller.yaml. Using "contains: const: qcom,nord-dp"
(as in qcom,qcs8300-mdss.yaml) and adding "qcom,sa8775p-dp" to the example
nodes would resolve this.
[ ... ]
> + displayport-controller@af5c000 {
> + compatible = "qcom,nord-dp";
> +
> + reg = <0xaf5c000 0x200>,
> + <0xaf5c200 0x200>,
> + <0xaf5d000 0xc00>,
> + <0xaf5e000 0x400>,
> + <0xaf5f000 0x400>,
> + <0xaf60000 0x400>,
> + <0xaf61000 0x400>,
> + <0xaf62000 0x600>,
> + <0xaf63000 0x600>;
> +
> + clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_INTF_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK>;
> + clock-names = "core_iface", "core_aux",
> + "ctrl_link", "ctrl_link_iface",
> + "stream_pixel", "stream_1_pixel",
> + "stream_2_pixel", "stream_3_pixel";
> +
> + assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK_SRC>;
> + assigned-clock-parents = <&dp1_phy 0>,
> + <&dp1_phy 1>,
> + <&dp1_phy 1>;
[ ... ]
> + dp1_phy: phy@fc6a00 {
> + compatible = "qcom,nord-dp-phy";
> +
> + reg = <0xfc6a00 0x200>,
> + <0xfc6200 0xd0>,
> + <0xfc6600 0xd0>,
> + <0xfc6000 0x1c8>;
[Severity: Low]
Are the assigned-clocks on displayport-controller@af5c000 and the reg sizes
on dp1_phy in the example intended to differ from the first DP instance?
displayport-controller@af5c000 requests all four stream pixel clocks in
clocks, but assigned-clocks omits MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK_SRC
and MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK_SRC (which are present on
displayport-controller@af54000). In addition, dp1_phy uses SA8775P
register sizes (0x200, 0xd0, 0xd0, 0x1c8) instead of the qcom,nord-dp-phy
sizes used by dp0_phy (0x1d0, 0x128, 0x128, 0x200), leaving the fourth
region smaller than NORD_DP_QSERDES_COM_C_READY_STATUS at offset 0x1f8.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-16 13:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:38 ` sashiko-bot [this message]
2026-11-16 13:38 ` sashiko-bot
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-18 4:51 ` Shawn Guo
2026-11-18 4:51 ` Shawn Guo
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:44 ` sashiko-bot
2026-11-16 13:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217094@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-phy@lists.infradead.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.