From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord
Date: Mon, 16 Nov 2026 13:47:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-217109@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-5-e3d3bf0e2c49@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/msm/dpu: undeclared INTF_9 and INTF_10 in nord_intf break
build
- [Medium] drm/msm/dpu: wrong interrupt bit assignments for
intf_6..intf_10 on Nord
--
commit 26c8821f9a7d74ed713c34eb7d82f28a0037edd5
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
drm/msm/dpu: Add support for DPU 12.1 on Nord
This commit adds the DPU 12.1 hardware catalog configuration and device tree
match entry for the Qualcomm Nord SoC.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> new file mode 100644
> index 0000000000000..333eccb5c603a
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> @@ -0,0 +1,544 @@
[ ... ]
> +static const struct dpu_intf_cfg nord_intf[] = {
> + {
> + .name = "intf_0", .id = INTF_0,
> + .base = 0x34000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 24),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 25),
> + }, {
> + .name = "intf_3", .id = INTF_3,
> + .base = 0x37000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
> + }, {
> + .name = "intf_4", .id = INTF_4,
> + .base = 0x38000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21),
> + }, {
> + .name = "intf_6", .id = INTF_6,
> + .base = 0x3a000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23),
> + }, {
> + .name = "intf_7", .id = INTF_7,
> + .base = 0x3b000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 0),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 1),
> + }, {
> + .name = "intf_8", .id = INTF_8,
> + .base = 0x3c000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 2),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 3),
> + }, {
> + .name = "intf_9", .id = INTF_9,
> + .base = 0x3d000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 4),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 5),
> + }, {
> + .name = "intf_10", .id = INTF_10,
> + .base = 0x3e000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 6),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 7),
> + },
> +};
[Severity: High]
As reported by Dmitry Baryshkov on v1 [1], does referencing INTF_9 and INTF_10
in nord_intf break the build at this commit?
At this point in the series, enum dpu_intf only defines INTF_0 through INTF_8,
and enum dpu_hw_intr_reg and dpu_intr_set_7xxx lack MDP_INTF9_INTR and
MDP_INTF10_INTR, so MDP_INTFn_INTR(intf->id) in dpu_hw_intr_init() also
aliases MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR. These definitions are
added later in the series by commit "drm/msm/dpu: Fix DSI tear interrupts
broken by adding INTF_9 and INTF_10", which should be ordered before this
patch to keep the series bisectable.
[Severity: Medium]
Are the intr_underrun and intr_vsync bit indices for intf_6 through intf_10 in
nord_intf shifted onto the wrong interrupt bits?
On DPU 12.x (such as glymur_intf in dpu_12_2_glymur.h), MDP_SSPP_TOP0_INTR
bits 22 and 23 belong to INTF_5, while INTF_6 uses bits 16 and 17, INTF_7 uses
bits 18 and 19, and INTF_8 uses bits 12 and 13. Because INTF_5 is omitted on
Nord, intf_6 appears to have been assigned INTF_5's bits (22 and 23) and
intf_7 through intf_10 were sequentially assigned bits 0 through 7 in
MDP_SSPP_TOP0_INTR2, which will cause vblank and underrun interrupts to never
fire and dpu_encoder_phys_vid_wait_for_tx_complete() to time out when any of
these interfaces are used.
[1] https://lore.kernel.org/r/bqoezyuyrjiawudbwxybvjpdun5f3fmhhzukdeg2holuc2mykq@oa5mhoylopz7
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=5
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Nabige Aala" <nabige.aala@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, robh@kernel.org,
conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org,
olteanv@gmail.com
Subject: Re: [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord
Date: Mon, 16 Nov 2026 13:47:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-217109@kernel.org> (raw)
In-Reply-To: <20261116-nord-drv-dt-v3-5-e3d3bf0e2c49@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/msm/dpu: undeclared INTF_9 and INTF_10 in nord_intf break
build
- [Medium] drm/msm/dpu: wrong interrupt bit assignments for
intf_6..intf_10 on Nord
--
commit 26c8821f9a7d74ed713c34eb7d82f28a0037edd5
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
drm/msm/dpu: Add support for DPU 12.1 on Nord
This commit adds the DPU 12.1 hardware catalog configuration and device tree
match entry for the Qualcomm Nord SoC.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> new file mode 100644
> index 0000000000000..333eccb5c603a
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> @@ -0,0 +1,544 @@
[ ... ]
> +static const struct dpu_intf_cfg nord_intf[] = {
> + {
> + .name = "intf_0", .id = INTF_0,
> + .base = 0x34000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 24),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 25),
> + }, {
> + .name = "intf_3", .id = INTF_3,
> + .base = 0x37000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
> + }, {
> + .name = "intf_4", .id = INTF_4,
> + .base = 0x38000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21),
> + }, {
> + .name = "intf_6", .id = INTF_6,
> + .base = 0x3a000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23),
> + }, {
> + .name = "intf_7", .id = INTF_7,
> + .base = 0x3b000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 0),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 1),
> + }, {
> + .name = "intf_8", .id = INTF_8,
> + .base = 0x3c000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 2),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 3),
> + }, {
> + .name = "intf_9", .id = INTF_9,
> + .base = 0x3d000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 4),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 5),
> + }, {
> + .name = "intf_10", .id = INTF_10,
> + .base = 0x3e000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 6),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 7),
> + },
> +};
[Severity: High]
As reported by Dmitry Baryshkov on v1 [1], does referencing INTF_9 and INTF_10
in nord_intf break the build at this commit?
At this point in the series, enum dpu_intf only defines INTF_0 through INTF_8,
and enum dpu_hw_intr_reg and dpu_intr_set_7xxx lack MDP_INTF9_INTR and
MDP_INTF10_INTR, so MDP_INTFn_INTR(intf->id) in dpu_hw_intr_init() also
aliases MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR. These definitions are
added later in the series by commit "drm/msm/dpu: Fix DSI tear interrupts
broken by adding INTF_9 and INTF_10", which should be ordered before this
patch to keep the series bisectable.
[Severity: Medium]
Are the intr_underrun and intr_vsync bit indices for intf_6 through intf_10 in
nord_intf shifted onto the wrong interrupt bits?
On DPU 12.x (such as glymur_intf in dpu_12_2_glymur.h), MDP_SSPP_TOP0_INTR
bits 22 and 23 belong to INTF_5, while INTF_6 uses bits 16 and 17, INTF_7 uses
bits 18 and 19, and INTF_8 uses bits 12 and 13. Because INTF_5 is omitted on
Nord, intf_6 appears to have been assigned INTF_5's bits (22 and 23) and
intf_7 through intf_10 were sequentially assigned bits 0 through 7 in
MDP_SSPP_TOP0_INTR2, which will cause vblank and underrun interrupts to never
fire and dpu_encoder_phys_vid_wait_for_tx_complete() to time out when any of
these interfaces are used.
[1] https://lore.kernel.org/r/bqoezyuyrjiawudbwxybvjpdun5f3fmhhzukdeg2holuc2mykq@oa5mhoylopz7
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=5
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-16 13:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:38 ` sashiko-bot
2026-11-16 13:38 ` sashiko-bot
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-17 15:23 ` Rob Herring (Arm)
2026-11-18 4:51 ` Shawn Guo
2026-11-18 4:51 ` Shawn Guo
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:47 ` sashiko-bot [this message]
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:44 ` sashiko-bot
2026-11-16 13:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217109@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-phy@lists.infradead.org \
--cc=nabige.aala@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.