From: sashiko-bot@kernel.org
To: "Sidharth Saha" <ssaha2000@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion
Date: Tue, 17 Nov 2026 01:29:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-218042@kernel.org> (raw)
In-Reply-To: <20261116-rgb565-test-v1-5-27f49c1aa694@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/vkms: non-routable GitHub noreply email in Signed-off-by
trailer
--
commit ae58f1df1e3854cf85fe440504baa5b724769237
Author: Sidharth Saha <ssaha2000@gmail.com>
> drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion
>
> argb_u16_from_RGB565() and argb_u16_from_BGR565() were converted to the
> new channels_to_argb_u16() helper. Test them against hand-computed
> values; the tests pass both before and after that conversion, showing
> it didn't change behavior.
>
> Make both functions visible to KUnit so the tests can call them.
>
> Signed-off-by: Sidharth Saha <40047656+Sidharth-Saha@users.noreply.github.com>
[Severity: High]
The Signed-off-by trailer uses a non-routable GitHub noreply email address
instead of a valid, routable address matching the Author line
(ssaha2000@gmail.com).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rgb565-test-v1-0-27f49c1aa694@gmail.com?part=5
prev parent reply other threads:[~2026-11-17 1:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 1:21 [PATCH 0/5] drm/vkms: Add KUnit tests for packed RGB format conversions Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:21 ` [PATCH 1/5] drm/vkms: Add KUnit test for RGB565 writeback conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:33 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 2/5] drm/vkms: Add KUnit test for BGR565 " Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:32 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 3/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:31 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 4/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:31 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 5/5] drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:29 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218042@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ssaha2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.