From: sashiko-bot@kernel.org
To: "Sidharth Saha" <ssaha2000@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion
Date: Tue, 17 Nov 2026 01:31:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-218044@kernel.org> (raw)
In-Reply-To: <20261116-rgb565-test-v1-3-27f49c1aa694@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/vkms: duplicate RGB565/BGR565 declarations in vkms_formats.h
--
commit 9f63eb8da7a8714b37e3f9813c3cd23126f306f7
Author: Sidharth Saha <ssaha2000@gmail.com>
drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion
This commit exports argb_u16_from_RGB332() and argb_u16_from_BGR233() for
KUnit builds and adds parameterized KUnit tests covering RGB332 and BGR233
to 16-bit ARGB conversion.
[ ... ]
> diff --git a/drivers/gpu/drm/vkms/vkms_formats.h b/drivers/gpu/drm/vkms/vkms_formats.h
> index 135bb60a554b4..90006325a87ea 100644
> --- a/drivers/gpu/drm/vkms/vkms_formats.h
> +++ b/drivers/gpu/drm/vkms/vkms_formats.h
> @@ -18,6 +18,10 @@ struct pixel_argb_u16 argb_u16_from_yuv161616(const struct conversion_matrix *ma
> u16 y, u16 channel_1, u16 channel_2);
> void argb_u16_to_RGB565(u8 *out_pixel, const struct pixel_argb_u16 *in_pixel);
> void argb_u16_to_BGR565(u8 *out_pixel, const struct pixel_argb_u16 *in_pixel);
> +void argb_u16_to_RGB565(u8 *out_pixel, const struct pixel_argb_u16 *in_pixel);
> +void argb_u16_to_BGR565(u8 *out_pixel, const struct pixel_argb_u16 *in_pixel);
[Severity: Low]
Were the second declarations of argb_u16_to_RGB565() and
argb_u16_to_BGR565() added by mistake? They duplicate the prototypes
directly above and trigger -Wredundant-decls warnings under W=2 builds with
CONFIG_KUNIT enabled.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rgb565-test-v1-0-27f49c1aa694@gmail.com?part=3
next prev parent reply other threads:[~2026-11-17 1:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 1:21 [PATCH 0/5] drm/vkms: Add KUnit tests for packed RGB format conversions Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:21 ` [PATCH 1/5] drm/vkms: Add KUnit test for RGB565 writeback conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:33 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 2/5] drm/vkms: Add KUnit test for BGR565 " Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:32 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 3/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:31 ` sashiko-bot [this message]
2026-11-17 1:21 ` [PATCH 4/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:31 ` sashiko-bot
2026-11-17 1:21 ` [PATCH 5/5] drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion Sidharth Saha
2026-11-17 1:21 ` Sidharth Saha via B4 Relay
2026-11-17 1:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218044@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ssaha2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.