All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sidharth Saha" <ssaha2000@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion
Date: Tue, 17 Nov 2026 01:31:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-218043@kernel.org> (raw)
In-Reply-To: <20261116-rgb565-test-v1-4-27f49c1aa694@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/vkms: invalid noreply and mismatched email in Signed-off-by
  trailer
--

commit 029ee38d1c5f0c8b5a4e5b775f76588cc0eb383e
Author: Sidharth Saha <ssaha2000@gmail.com>

> drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion
>
> Test argb_u16_to_RGB332() and argb_u16_to_BGR233(), which reduce 16-bit
> channels to 3/3/2 bits. Cases cover the 0x8000 midpoint, inputs on
> either side of the first rounding step for both 3- and 2-bit channels,
> and a round trip using values produced by the read conversion.
>
> Make both functions visible to KUnit so the tests can call them.
>
> Signed-off-by: Sidharth Saha <40047656+Sidharth-Saha@users.noreply.github.com>

[Severity: High]
The Signed-off-by trailer uses a non-routable GitHub noreply address that
does not match the commit Author address (ssaha2000@gmail.com).  Should
the Signed-off-by line use the routable ssaha2000@gmail.com address to
satisfy DCO requirements?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rgb565-test-v1-0-27f49c1aa694@gmail.com?part=4

  reply	other threads:[~2026-11-17  1:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  1:21 [PATCH 0/5] drm/vkms: Add KUnit tests for packed RGB format conversions Sidharth Saha via B4 Relay
2026-11-17  1:21 ` Sidharth Saha
2026-11-17  1:21 ` [PATCH 1/5] drm/vkms: Add KUnit test for RGB565 writeback conversion Sidharth Saha via B4 Relay
2026-11-17  1:21   ` Sidharth Saha
2026-11-17  1:33   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 2/5] drm/vkms: Add KUnit test for BGR565 " Sidharth Saha via B4 Relay
2026-11-17  1:21   ` Sidharth Saha
2026-11-17  1:32   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 3/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion Sidharth Saha via B4 Relay
2026-11-17  1:21   ` Sidharth Saha
2026-11-17  1:31   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 4/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion Sidharth Saha via B4 Relay
2026-11-17  1:21   ` Sidharth Saha
2026-11-17  1:31   ` sashiko-bot [this message]
2026-11-17  1:21 ` [PATCH 5/5] drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion Sidharth Saha via B4 Relay
2026-11-17  1:21   ` Sidharth Saha
2026-11-17  1:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218043@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=ssaha2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.