All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sidharth Saha" <ssaha2000@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/vkms: Add KUnit test for BGR565 writeback conversion
Date: Tue, 17 Nov 2026 01:32:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-218045@kernel.org> (raw)
In-Reply-To: <20261116-rgb565-test-v1-2-27f49c1aa694@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/vkms: unroutable GitHub noreply email in Signed-off-by
  trailer
--

commit f9d2ab12880eb54ad84218efebd8fde44f4e329b
Author: Sidharth Saha <ssaha2000@gmail.com>

> drm/vkms: Add KUnit test for BGR565 writeback conversion
>
> Reuse the RGB565 writeback cases to test argb_u16_to_BGR565(), which
> packs the same 5/6/5-bit channels with red and blue swapped. The
> distinct-channel case checks that red and blue land in the right bits.
>
> Make argb_u16_to_BGR565() visible to KUnit so the test can call it.
>
> Signed-off-by: Sidharth Saha <40047656+Sidharth-Saha@users.noreply.github.com>

[Severity: High]
Should the Signed-off-by trailer use the commit author's routable email
address (ssaha2000@gmail.com) instead of an unroutable GitHub noreply
address?  The current trailer does not match the Author header and does
not satisfy the Developer's Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-rgb565-test-v1-0-27f49c1aa694@gmail.com?part=2

  reply	other threads:[~2026-11-17  1:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  1:21 [PATCH 0/5] drm/vkms: Add KUnit tests for packed RGB format conversions Sidharth Saha
2026-11-17  1:21 ` Sidharth Saha via B4 Relay
2026-11-17  1:21 ` [PATCH 1/5] drm/vkms: Add KUnit test for RGB565 writeback conversion Sidharth Saha
2026-11-17  1:21   ` Sidharth Saha via B4 Relay
2026-11-17  1:33   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 2/5] drm/vkms: Add KUnit test for BGR565 " Sidharth Saha
2026-11-17  1:21   ` Sidharth Saha via B4 Relay
2026-11-17  1:32   ` sashiko-bot [this message]
2026-11-17  1:21 ` [PATCH 3/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 read conversion Sidharth Saha
2026-11-17  1:21   ` Sidharth Saha via B4 Relay
2026-11-17  1:31   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 4/5] drm/vkms: Add KUnit tests for RGB332 and BGR233 writeback conversion Sidharth Saha
2026-11-17  1:21   ` Sidharth Saha via B4 Relay
2026-11-17  1:31   ` sashiko-bot
2026-11-17  1:21 ` [PATCH 5/5] drm/vkms: Add KUnit tests for RGB565 and BGR565 read conversion Sidharth Saha
2026-11-17  1:21   ` Sidharth Saha via B4 Relay
2026-11-17  1:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218045@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=ssaha2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.