From: sashiko-bot@kernel.org
To: "Yongxing Mou" <yongxing.mou@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present
Date: Thu, 19 Nov 2026 08:51:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-222728@kernel.org> (raw)
In-Reply-To: <20261119-msm-dp-mst-v9-25-ca61be4edfc3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/msm/dp: msm_dp_bridge_detect() sets plugged and blocks boot
MST enable
--
commit 743d14a69ac4db117bcd70993b4890a54c2ba917
Author: Abhinav Kumar <quic_abhinavk@quicinc.com>
drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present
This commit returns connector_status_disconnected from msm_dp_bridge_detect()
when a multi-stream capable controller detects an MST-capable sink before
MST is activated.
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 7f5247cbae035..6f1f9dd3660d0 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -1063,6 +1063,11 @@ enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge,
> status = connector_status_disconnected;
> }
>
> + /* Mark SST connector as disconnected in DP boot-up case */
> + if (msm_dp_ctrl_get_stream_cnt(priv->ctrl) > 1 &&
> + drm_dp_read_mst_cap(priv->aux, dpcd) == DRM_DP_MST)
> + status = connector_status_disconnected;
[Severity: High]
Does leaving priv->plugged set to true here prevent
msm_dp_hpd_plug_handle() from enabling MST when an MST-capable sink is
connected at boot?
Earlier in msm_dp_bridge_detect(), priv->plugged is set to true before this
check overrides status to connector_status_disconnected while dp->mst_active
is still false. When msm_dp_hpd_plug_handle() later runs, it returns early
without calling msm_dp_display_process_hpd_high() or
msm_dp_display_mst_enable():
drivers/gpu/drm/msm/dp/dp_display.c:msm_dp_hpd_plug_handle() {
...
if (dp->plugged)
return 0;
...
ret = msm_dp_display_process_hpd_high(dp);
...
}
As a result, the SST connector reports disconnected while MST topology
discovery is never started, leaving both SST and MST display output
non-functional. In addition, because dp->mst_active stays false while
priv->plugged is true, each later msm_dp_bridge_detect() call takes a new
runtime PM reference via pm_runtime_resume_and_get() and skips
pm_runtime_put_sync() under if (!priv->plugged), leaking a runtime PM
reference per detect call.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-msm-dp-mst-v9-0-ca61be4edfc3@oss.qualcomm.com?part=25
next prev parent reply other threads:[~2026-11-19 8:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:24 [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 01/29] drm/msm/dp: skip sink requests while the mainlink clocks are off Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 02/29] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 03/29] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 04/29] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 05/29] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 06/29] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 07/29] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 08/29] drm/msm/dp: replace power_on with active_stream_mask Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 09/29] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 10/29] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-11-19 8:36 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 12/29] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 13/29] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 14/29] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 15/29] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-11-19 8:35 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 17/29] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-11-19 8:41 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 18/29] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 20/29] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-11-19 8:45 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 21/29] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 22/29] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 23/29] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 24/29] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-11-19 9:05 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-11-19 8:51 ` sashiko-bot [this message]
2026-11-19 8:24 ` [PATCH v9 26/29] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 27/29] drm/msm/dp: ignore IRQ HPD latched together with an unplug Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 29/29] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-11-19 11:54 ` [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222728@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.