From: sashiko-bot@kernel.org
To: "Yongxing Mou" <yongxing.mou@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders
Date: Thu, 19 Nov 2026 08:51:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-222730@kernel.org> (raw)
In-Reply-To: <20261119-msm-dp-mst-v9-16-ca61be4edfc3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/msm/dpu: KMS init failure on SC8180X in
_dpu_kms_initialize_displayport()
- [Medium] drm/msm/dp: devres leak of msm_dp_panel in
msm_dp_mst_attach_encoder()
--
commit b76c85c1a18e10745adde0bb5001dc9b1e93e31a
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
drm/msm/dpu: add per-stream MST encoders
This commit creates a DRM encoder for each DP MST stream, associates it
with a stream ID and panel, and sets up MST-specific encoder helper
callbacks.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 3c3203ca32c76..92691d39dcb24 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -688,6 +688,21 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev,
> return rc;
> }
> }
> +
> + for (int stream_id = 0; stream_cnt > 1 && stream_id < stream_cnt; stream_id++) {
> + info.stream_id = stream_id;
> + encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DPMST, &info);
> + if (IS_ERR(encoder)) {
> + DPU_ERROR("encoder init failed for dp mst display\n");
> + return PTR_ERR(encoder);
> + }
[Severity: High]
Does this break KMS initialization on SC8180X?
In arch/arm64/boot/dts/qcom/sc8180x.dtsi, mdss_dp0 and mdss_dp1 both
specify stream_pixel and stream_1_pixel in clock-names, so
msm_dp_get_mst_max_stream() returns stream_cnt == 2. However, the SC8180X
DPU catalog only has one INTF_DP entry per controller because the shared
MST interface uses a dummy controller_id:
drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h:sc8180x_intf[] {
...
/* INTF_3 is for MST, wired to INTF_DP 0 and 1, use dummy index until this is supported */
{
.name = "intf_3", .id = INTF_3,
.base = 0x6b800, .len = 0x280,
.type = INTF_DP,
.controller_id = 999,
...
}
When stream_id == 1, dpu_encoder_init() -> dpu_encoder_setup_display() ->
dpu_encoder_get_intf() finds no second matching INTF_DP entry and returns
NULL, causing _dpu_kms_initialize_displayport() to fail with -ENOMEM and
aborting display initialization on SC8180X.
> diff --git a/drivers/gpu/drm/msm/dp/dp_mst_drm.c b/drivers/gpu/drm/msm/dp/dp_mst_drm.c
> index a2900ff3b0ab3..ef5fb70863b81 100644
> --- a/drivers/gpu/drm/msm/dp/dp_mst_drm.c
> +++ b/drivers/gpu/drm/msm/dp/dp_mst_drm.c
> @@ -147,6 +147,26 @@ static int msm_dp_mst_encoder_stream_id(struct msm_dp_mst *mst,
> return -1;
> }
>
> +int msm_dp_mst_attach_encoder(struct msm_dp *dp_display, unsigned int stream_id,
> + struct drm_encoder *encoder)
> +{
> + struct msm_dp_mst *mst = dp_display->msm_dp_mst;
> + struct msm_dp_panel *dp_panel;
> +
> + dp_panel = msm_dp_display_get_panel(dp_display, stream_id);
> + if (!dp_panel) {
> + drm_err(dp_display->drm_dev,
> + "[MST] failed to allocate panel for stream %d\n", stream_id);
> + return -ENOMEM;
> + }
[Severity: Medium]
Does calling msm_dp_display_get_panel() during KMS initialization leak
struct msm_dp_panel_private across DRM component master bind/unbind
cycles?
msm_dp_display_get_panel() calls msm_dp_panel_get(), which allocates the
panel with devm_kzalloc() on the subordinate DP platform device
(&dp->msm_dp_display.pdev->dev). When the DRM master unbinds (or if a
later step in msm_drm_init() fails), msm_dp_mst_unregister() frees struct
msm_dp_mst, but the devres allocations on the persistent DP platform
device remain and are reallocated on each subsequent bind.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-msm-dp-mst-v9-0-ca61be4edfc3@oss.qualcomm.com?part=16
next prev parent reply other threads:[~2026-11-19 8:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:24 [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 01/29] drm/msm/dp: skip sink requests while the mainlink clocks are off Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 02/29] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 03/29] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 04/29] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 05/29] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 06/29] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 07/29] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 08/29] drm/msm/dp: replace power_on with active_stream_mask Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 09/29] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 10/29] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-11-19 8:36 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 12/29] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 13/29] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 14/29] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 15/29] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-11-19 8:35 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-11-19 8:51 ` sashiko-bot [this message]
2026-11-19 8:24 ` [PATCH v9 17/29] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-11-19 8:41 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 18/29] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 20/29] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-11-19 8:45 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 21/29] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 22/29] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 23/29] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 24/29] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-11-19 9:05 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 26/29] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 27/29] drm/msm/dp: ignore IRQ HPD latched together with an unplug Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 29/29] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-11-19 11:54 ` [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222730@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.