From: sashiko-bot@kernel.org
To: "Yongxing Mou" <yongxing.mou@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes
Date: Thu, 19 Nov 2026 09:01:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-222771@kernel.org> (raw)
In-Reply-To: <20261119-msm-dp-mst-v9-19-ca61be4edfc3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/bridge_connector: unconditional detect() after hpd_notify()
breaks msm_dp
- [Medium] drm/bridge_connector: suppressed IRQ_HPD uevent on downstream
EDID change
--
commit 639a7eb6e945d13bc1ca0a8e003c6cf0a496e228
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes
This commit calls the bridge .detect() callback after HPD notification to
update connector->status and skips sending a hotplug event on IRQ_HPD when
the connector status has not changed.
> diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/drm/display/drm_bridge_connector.c
> index 4ade63306653f..1d4502126bff3 100644
> --- a/drivers/gpu/drm/display/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/display/drm_bridge_connector.c
> @@ -160,15 +160,25 @@ static void drm_bridge_connector_handle_hpd(struct drm_bridge_connector *drm_bri
> enum drm_connector_dp_event event)
> {
> struct drm_connector *connector = &drm_bridge_connector->base;
> + struct drm_bridge *detect = drm_bridge_connector->bridge_detect;
> struct drm_device *dev = connector->dev;
> + enum drm_connector_status old_status, new_status;
> + bool level_hpd;
> + bool changed;
>
> - mutex_lock(&dev->mode_config.mutex);
> - connector->status = status;
> - mutex_unlock(&dev->mode_config.mutex);
> + level_hpd = event == DRM_CONNECTOR_NO_EXTRA_STATUS;
>
> drm_bridge_connector_hpd_notify(connector, status, event);
>
> - drm_kms_helper_connector_hotplug_event(connector);
> + mutex_lock(&dev->mode_config.mutex);
> + old_status = connector->status;
> + new_status = detect ? detect->funcs->detect(detect, connector) : status;
[Severity: High]
Does calling detect->funcs->detect() unconditionally after
drm_bridge_connector_hpd_notify() leak a runtime PM reference on
dp->pdev->dev in msm_dp on every connect and IRQ_HPD event?
On plug and IRQ_HPD notifications, msm_dp_bridge_hpd_notify() ->
msm_dp_hpd_plug_handle() acquires a runtime PM reference and sets
dp->plugged = true. Calling msm_dp_bridge_detect() right after acquires a
second reference and skips releasing it at exit because priv->plugged is
true:
drivers/gpu/drm/msm/dp/dp_display.c:msm_dp_bridge_detect() {
...
ret = pm_runtime_resume_and_get(&dp->pdev->dev);
...
priv->plugged = true;
...
end:
if (!priv->plugged) {
if (phy_deinit) {
msm_dp_aux_enable_xfers(priv->aux, false);
msm_dp_display_host_phy_exit(priv);
}
pm_runtime_put_sync(&dp->pdev->dev);
}
}
msm_dp_hpd_unplug_handle() only drops one reference when clearing
dp->plugged, so the extra reference is never released and the DP controller
cannot runtime suspend. If a DPCD read in msm_dp_bridge_detect() fails
instead, it clears priv->plugged = false while releasing only its own
reference, causing a later msm_dp_hpd_unplug_handle() to return early and
skip unplug cleanup and the initial reference release.
On disconnect notifications, running msm_dp_bridge_detect() after
msm_dp_hpd_unplug_handle() also re-enables AUX transfers or re-initializes
the PHY after unplug, and bridges whose .detect() callback does not sense
HPD (such as lt9611uxc_bridge_detect() when hpd_supported is false) will
overwrite connector_status_disconnected with connector_status_connected.
> + connector->status = new_status;
> + changed = new_status != old_status;
> + mutex_unlock(&dev->mode_config.mutex);
> +
> + if (changed || level_hpd)
> + drm_kms_helper_connector_hotplug_event(connector);
> }
[Severity: Medium]
Can checking only new_status != old_status suppress hotplug events when a
downstream DP branch device changes EDID over IRQ_HPD while remaining
connected?
When a branch device signals DP_DOWNSTREAM_PORT_STATUS_CHANGED while
connector->status is already connector_status_connected,
msm_dp_irq_hpd_handle() -> msm_dp_display_process_hpd_high() reads the new
EDID and calls drm_edid_connector_update(), which increments
connector->epoch_counter. Because new_status and old_status are both
connector_status_connected and level_hpd is false, changed is false and
userspace never receives the hotplug notification.
When new_status != old_status, updating connector->status directly here
without incrementing connector->epoch_counter also causes subsequent
drm_helper_probe_detect() calls to see no status change and skip bumping
connector->epoch_counter.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-msm-dp-mst-v9-0-ca61be4edfc3@oss.qualcomm.com?part=19
next prev parent reply other threads:[~2026-11-19 9:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:24 [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 01/29] drm/msm/dp: skip sink requests while the mainlink clocks are off Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 02/29] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 03/29] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 04/29] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 05/29] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 06/29] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 07/29] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 08/29] drm/msm/dp: replace power_on with active_stream_mask Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 09/29] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 10/29] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-11-19 8:36 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 12/29] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 13/29] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 14/29] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 15/29] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-11-19 8:35 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 17/29] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-11-19 8:41 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 18/29] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-11-19 9:01 ` sashiko-bot [this message]
2026-11-19 8:24 ` [PATCH v9 20/29] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-11-19 8:45 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 21/29] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 22/29] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 23/29] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 24/29] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-11-19 9:05 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 26/29] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 27/29] drm/msm/dp: ignore IRQ HPD latched together with an unplug Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 29/29] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-11-19 11:54 ` [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222771@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.