All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 00/17] drm/spacemit: add SpacemiT K3 display support
@ 2026-11-21  7:40 ` Cody Kang via B4 Relay
  0 siblings, 0 replies; 82+ messages in thread
From: Cody Kang via B4 Relay @ 2026-11-21  7:40 UTC (permalink / raw)
  To: David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Yixun Lan, Troy Mitchell, Vinod Koul, Neil Armstrong,
	Manivannan Sadhasivam, Haylen Chu, Michael Turquette,
	Stephen Boyd, Brian Masney, Philipp Zabel, Paul Walmsley,
	Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Yao Zi,
	Uwe Kleine-König, Guodong Xu, Icenowy Zheng, Jerome Brunet,
	Sarah Emery, Ze Huang, Dmitry Baryshkov
  Cc: Cody Kang, dri-devel, linux-riscv, devicetree, spacemit,
	linux-kernel, linux-phy, linux-clk

This series adds display support for the SpacemiT K3 [2], a RISC-V SoC:
a new DRM driver, a new PHY driver and three new bindings.

The display path is three blocks deep:

  Saturn DPU -> Innosilicon DP/eDP controller -> Innosilicon DP PHY

New readers will find an introduction to this hardware in the v2 cover
letter [3].

In v3, two major changes, thanks to Thomas Zimmermann for the review
that led to these:

- The DPU driver lost its internal layers: the callback tables, the
  tracepoints and the command-list grouping are gone.
- Page-flip events go through the vblank machinery, and the DPU is
  powered through runtime PM.

The rest of the v3 changes please see below, with details in each patch's
changelog.

v2 ships in the Ubuntu 26.10 RISC-V kernel [4]. Thanks to Sarah Emery
for two fixes found there.

Thanks to Ze Huang for testing v2 on the K3 Pico-ITX. The Tested-by is
not carried, because the DRM driver changed too much in v3.

Ze, Sarah: if you have time to run v3, a retest would be very welcome.

Sashiko AI review contributed total review comments: 51 items, which I
accepted: 19 items.

v3 repeated the full v1 test matrix on both boards, in built-in and
modular configurations, with the module load/unload rounds of v2, plus
page-flip and DPMS rounds and unloading the modules while a client is
running.

About the series:

The DPU driver arrives as five staged patches (7 to 11) to keep each one
a reasonable size. It becomes buildable with patch 11. Bisect safe.

This series supports a single primary plane per CRTC and linear RGB
scanout (no plane scaling, rotation, YUV or writeback). It does not
support DSI, DSC or DP audio, and link rates are capped at HBR2.

Based on v7.4-rc1.

Testing this series needs a SpacemiT u-boot carrying display support:
the branch at [1], or a later official release.

Tested on two K3 boards:

  - Pico-ITX: an eDP panel and an external DisplayPort monitor.
  - CoM260-IFX: DisplayPort only, no eDP.

Note: The eDP panel DTS enablement is not part of this series; a separate
      series will follow showing how eDP can be verified.

[1] https://github.com/spacemit-com/uboot-for-k3-display-verify/tree/k3-br-v1.0.y
[2] https://www.spacemit.com/community/document/info?lang=en&nodepath=hardware/key_stone/k3
[3] https://lore.kernel.org/r/20260809-k3-display-v2-0-327d7910bf71@gmail.com
[4] https://launchpad.net/ubuntu/+source/linux-riscv/7.2.0-5.5.2

Changes in v3:
- drop the tracepoints, the hardware callback tables and the
  constant-fill path; the Saturn register code is called directly
  (Thomas Zimmermann)
- one command list per channel, allocated once and submitted by its
  owner; the grouping, sorting and chaining of lists is gone (Thomas
  Zimmermann)
- deliver the commit's event through the vblank machinery, armed from
  the CFG_RDY interrupt (Thomas Zimmermann)
- power the DPU through runtime PM, and stop the boot loader's pipeline
  at probe instead of at the first modeset (Thomas Zimmermann)
- add prepare_fb: the display MMU table is built once per GEM object
  and the buffer's fences are waited for (Thomas Zimmermann)
- program the plane from the clipped rectangles, and size its line
  buffer in atomic_check (Thomas Zimmermann)
- wrap only the hardware access in drm_dev_enter() (Thomas Zimmermann);
  release the drm_device when the aggregate unbinds
- map scanout buffers write-combining; fail AUX transfers fast when HPD
  is low (Sarah Emery)
- reject modes above 3840x2160, and bound framebuffers by what the RDMA
  registers can address (Icenowy Zheng)
- let the panel supply the modes on eDP (Guodong Xu)
- leave the DPU's pixel clock at the rate it has; on DP and eDP the PHY
  PLL is the pixel clock (Guodong Xu)
- do not advertise a gamma table (Guodong Xu)
- DT: order the display nodes by unit address; the Pico-ITX message
  names the Type-C receptacle's DP alternate mode (Icenowy Zheng)
- clk: the commit message names the binding that documents the two
  clock inputs (Jerome Brunet)
- MAINTAINERS: add Guodong Xu as maintainer; list Cody Kang with the
  vsit.ai address
- rebased onto v7.4-rc1: atomic_create_state replaces .reset
- commit messages of patches 5, 7, 8, 9, 11, 12, 14 and 16 reworded
- picked up Rob Herring's Reviewed-by on patch 4
- Link to v2: https://patch.msgid.link/20260809-k3-display-v2-0-327d7910bf71@gmail.com

Changes in v2:
- unbind: keep the online IRQ alive until the teardown commits have
  drained; module unload no longer rides two watchdog timeouts
- bridge teardown on devres: reset via
  devm_reset_control_get_exclusive_deasserted(), pxclk disable as a
  devm action ordered against the PHY child (Philipp Zabel, Yao Zi)
- all five DPU reset lines behind one reset_control_bulk_* pair
  (Philipp Zabel, Guodong Xu)
- bindings: port@1 is now required; the CoM260 board describes its DP
  receptacle with a dp-connector node; redundant minItems dropped
  (Rob Herring)
- possible_crtcs derived from the input endpoint only
- EDID reads through the AUX I2C adapter; write-1-to-clear interrupt
  acks by plain write; assorted dead code dropped
- picked up Rob Herring's Reviewed-by on patches 1-3
- Link to v1: https://lore.kernel.org/r/20260725-k3-display-v1-0-6de34d80e86c@gmail.com

Signed-off-by: Cody Kang <codykang@vsit.ai>
---
Cody Kang (17):
      dt-bindings: display: spacemit: add K3 Saturn DPU controller
      dt-bindings: phy: add SpacemiT K3 Innosilicon DP PHY
      dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller
      dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU
      phy: spacemit: add Innosilicon DP TX PHY driver
      clk: spacemit: k3: parent eDP/DP pixel clock to the PHY PLL
      drm/spacemit: add Saturn DPU register model
      drm/spacemit: add Saturn DPU core types, cmdlist and display MMU
      drm/spacemit: add Saturn DPU hardware backend
      drm/spacemit: add Saturn DPU KMS pipeline
      drm/spacemit: add Saturn DPU DRM device driver
      drm/spacemit: add Innosilicon DP/eDP controller bridge driver
      MAINTAINERS: add SpacemiT K3 display driver entry
      riscv: dts: spacemit: k3: add display nodes
      riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output
      riscv: dts: spacemit: k3-com260-ifx: enable the DisplayPort output
      riscv: defconfig: spacemit: k3: enable display driver

 .../display/spacemit/spacemit,k3-inno-dp.yaml      |  141 ++
 .../display/spacemit/spacemit,k3-saturn-dpu.yaml   |  132 ++
 .../bindings/phy/spacemit,k3-inno-dp-phy.yaml      |   48 +
 .../bindings/soc/spacemit/spacemit,k1-syscon.yaml  |   21 +-
 MAINTAINERS                                        |   11 +
 arch/riscv/boot/dts/spacemit/k3-com260-ifx.dts     |   27 +
 arch/riscv/boot/dts/spacemit/k3-display.dtsi       |  166 ++
 arch/riscv/boot/dts/spacemit/k3-pico-itx.dts       |   11 +
 arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi       |   22 +
 arch/riscv/configs/defconfig                       |    2 +
 drivers/clk/spacemit/ccu-k3.c                      |    4 +-
 drivers/gpu/drm/Kconfig                            |    1 +
 drivers/gpu/drm/Makefile                           |    1 +
 drivers/gpu/drm/spacemit/Kconfig                   |   37 +
 drivers/gpu/drm/spacemit/Makefile                  |   15 +
 drivers/gpu/drm/spacemit/dpu/dpu_saturn.c          |  353 ++++
 drivers/gpu/drm/spacemit/dpu/dpu_saturn.h          |   36 +
 drivers/gpu/drm/spacemit/dpu/dpu_saturn_hee.c      |  670 ++++++
 drivers/gpu/drm/spacemit/dpu/saturn_fbcmem.c       |   66 +
 drivers/gpu/drm/spacemit/dpu/saturn_fbcmem.h       |   16 +
 drivers/gpu/drm/spacemit/dpu/saturn_regs/dpu_int.h |   25 +
 drivers/gpu/drm/spacemit/dpu/saturn_regs/ops_hee.h |   47 +
 .../gpu/drm/spacemit/dpu/saturn_regs/reg_map_hee.h |   65 +
 .../drm/spacemit/dpu/saturn_regs/saturn_fields.h   |  312 +++
 drivers/gpu/drm/spacemit/spacemit_cmdlist.c        |  198 ++
 drivers/gpu/drm/spacemit/spacemit_cmdlist.h        |  133 ++
 drivers/gpu/drm/spacemit/spacemit_crtc.c           |  589 ++++++
 drivers/gpu/drm/spacemit/spacemit_crtc.h           |  133 ++
 drivers/gpu/drm/spacemit/spacemit_dmmu.c           |  119 ++
 drivers/gpu/drm/spacemit/spacemit_dmmu.h           |   80 +
 drivers/gpu/drm/spacemit/spacemit_dpu_ids.h        |   26 +
 drivers/gpu/drm/spacemit/spacemit_dpu_reg.h        |   99 +
 drivers/gpu/drm/spacemit/spacemit_drm.c            |  204 ++
 drivers/gpu/drm/spacemit/spacemit_drm.h            |   62 +
 drivers/gpu/drm/spacemit/spacemit_inno_dp.c        | 2186 ++++++++++++++++++++
 drivers/gpu/drm/spacemit/spacemit_inno_dp.h        |  328 +++
 drivers/gpu/drm/spacemit/spacemit_planes.c         |  332 +++
 drivers/phy/spacemit/Kconfig                       |   13 +
 drivers/phy/spacemit/Makefile                      |    1 +
 drivers/phy/spacemit/phy-k3-inno-dp.c              |  951 +++++++++
 40 files changed, 7680 insertions(+), 3 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20260713-k3-display-e8ffed67e936

Best regards,
--  
Cody Kang <codykang.hk@gmail.com>



^ permalink raw reply	[flat|nested] 82+ messages in thread

end of thread, other threads:[~2026-11-21  8:08 UTC | newest]

Thread overview: 82+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  7:40 [PATCH v3 00/17] drm/spacemit: add SpacemiT K3 display support Cody Kang via B4 Relay
2026-11-21  7:40 ` Cody Kang via B4 Relay
2026-11-21  7:40 ` Cody Kang
2026-11-21  7:40 ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 01/17] dt-bindings: display: spacemit: add K3 Saturn DPU controller Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:44   ` sashiko-bot
2026-11-21  7:44     ` sashiko-bot
2026-11-21  7:40 ` [PATCH v3 02/17] dt-bindings: phy: add SpacemiT K3 Innosilicon DP PHY Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:45   ` sashiko-bot
2026-11-21  7:45     ` sashiko-bot
2026-11-21  7:40 ` [PATCH v3 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 05/17] phy: spacemit: add Innosilicon DP TX PHY driver Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 06/17] clk: spacemit: k3: parent eDP/DP pixel clock to the PHY PLL Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 07/17] drm/spacemit: add Saturn DPU register model Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 08/17] drm/spacemit: add Saturn DPU core types, cmdlist and display MMU Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 09/17] drm/spacemit: add Saturn DPU hardware backend Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  8:01   ` sashiko-bot
2026-11-21  8:01     ` sashiko-bot
2026-11-21  7:40 ` [PATCH v3 10/17] drm/spacemit: add Saturn DPU KMS pipeline Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  8:06   ` sashiko-bot
2026-11-21  8:06     ` sashiko-bot
2026-11-21  7:40 ` [PATCH v3 11/17] drm/spacemit: add Saturn DPU DRM device driver Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 12/17] drm/spacemit: add Innosilicon DP/eDP controller bridge driver Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  8:08   ` sashiko-bot
2026-11-21  8:08     ` sashiko-bot
2026-11-21  7:40 ` [PATCH v3 13/17] MAINTAINERS: add SpacemiT K3 display driver entry Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 14/17] riscv: dts: spacemit: k3: add display nodes Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 15/17] riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 16/17] riscv: dts: spacemit: k3-com260-ifx: " Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40 ` [PATCH v3 17/17] riscv: defconfig: spacemit: k3: enable display driver Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang via B4 Relay
2026-11-21  7:40   ` Cody Kang
2026-11-21  7:40   ` Cody Kang via B4 Relay

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.