[PATCH] ASoC: Intel: Fix sparse warnings for firmware loader.

[PATCH] ASoC: Intel: Fix sparse warnings for firmware loader.

[Liam Girdwood]

Sparse gives us the following warning on sst-firmware.c

  CHECK   sound/soc/intel/sst-firmware.c
sound/soc/intel/sst-firmware.c:39:34: warning: incorrect type in argument 1 (different address spaces)
sound/soc/intel/sst-firmware.c:39:34:    expected void volatile [noderef] <asn:2>*dst
sound/soc/intel/sst-firmware.c:39:34:    got void *
sound/soc/intel/sst-firmware.c:417:36: warning: incorrect type in argument 1 (different address spaces)
sound/soc/intel/sst-firmware.c:417:36:    expected void *dest
sound/soc/intel/sst-firmware.c:417:36:    got void [noderef] <asn:2>*
sound/soc/intel/sst-firmware.c:430:5: warning: symbol 'sst_block_module_remove' was not declared. Should it be static?

This patch removes this warning.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---
 sound/soc/intel/sst-firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c
index 31cd154..dee7eb5 100644
--- a/sound/soc/intel/sst-firmware.c
+++ b/sound/soc/intel/sst-firmware.c
@@ -30,7 +30,7 @@
 #include "sst-dsp.h"
 #include "sst-dsp-priv.h"
 
-static void sst_memcpy32(void *dest, void *src, u32 bytes)
+static void sst_memcpy32(volatile void __iomem *dest, void *src, u32 bytes)
 {
 	u32 i;
 
-- 
1.8.3.2

Re: [PATCH] ASoC: Intel: Fix sparse warnings for firmware loader.

[Liam Girdwood]

On Wed, 2014-02-19 at 11:00 +0000, Liam Girdwood wrote:
> Sparse gives us the following warning on sst-firmware.c
> 
>   CHECK   sound/soc/intel/sst-firmware.c
> sound/soc/intel/sst-firmware.c:39:34: warning: incorrect type in argument 1 (different address spaces)
> sound/soc/intel/sst-firmware.c:39:34:    expected void volatile [noderef] <asn:2>*dst
> sound/soc/intel/sst-firmware.c:39:34:    got void *
> sound/soc/intel/sst-firmware.c:417:36: warning: incorrect type in argument 1 (different address spaces)
> sound/soc/intel/sst-firmware.c:417:36:    expected void *dest
> sound/soc/intel/sst-firmware.c:417:36:    got void [noderef] <asn:2>*
> sound/soc/intel/sst-firmware.c:430:5: warning: symbol 'sst_block_module_remove' was not declared. Should it be static?
> 

Btw, the last warning appears to be a false positive as
sst_block_module_remove is exported as GPL symbol.

Liam

> This patch removes this warning.
> 
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> ---
>  sound/soc/intel/sst-firmware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c
> index 31cd154..dee7eb5 100644
> --- a/sound/soc/intel/sst-firmware.c
> +++ b/sound/soc/intel/sst-firmware.c
> @@ -30,7 +30,7 @@
>  #include "sst-dsp.h"
>  #include "sst-dsp-priv.h"
>  
> -static void sst_memcpy32(void *dest, void *src, u32 bytes)
> +static void sst_memcpy32(volatile void __iomem *dest, void *src, u32 bytes)
>  {
>  	u32 i;
>  

Re: [PATCH] ASoC: Intel: Fix sparse warnings for firmware loader.

[Liam Girdwood]

On Wed, 2014-02-19 at 11:06 +0000, Liam Girdwood wrote:
> On Wed, 2014-02-19 at 11:00 +0000, Liam Girdwood wrote:
> > Sparse gives us the following warning on sst-firmware.c
> > 
> >   CHECK   sound/soc/intel/sst-firmware.c
> > sound/soc/intel/sst-firmware.c:39:34: warning: incorrect type in argument 1 (different address spaces)
> > sound/soc/intel/sst-firmware.c:39:34:    expected void volatile [noderef] <asn:2>*dst
> > sound/soc/intel/sst-firmware.c:39:34:    got void *
> > sound/soc/intel/sst-firmware.c:417:36: warning: incorrect type in argument 1 (different address spaces)
> > sound/soc/intel/sst-firmware.c:417:36:    expected void *dest
> > sound/soc/intel/sst-firmware.c:417:36:    got void [noderef] <asn:2>*
> > sound/soc/intel/sst-firmware.c:430:5: warning: symbol 'sst_block_module_remove' was not declared. Should it be static?
> > 
> 
> Btw, the last warning appears to be a false positive as
> sst_block_module_remove is exported as GPL symbol.
> 

Ignore me. Sorry for the noise, I shouldn't send patches and be on calls
at the same time ;)

I'll resend fixes for both.

Liam

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.