Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dylan Reid <dgreid@chromium.org>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Dylan Reid <dgreid@chromium.org>, swarren@wwwdotorg.org
Subject: [RFCv2 15/22] ALSA: hda - move alloc_cmd_io to hda_controller
Date: Fri, 28 Feb 2014 15:41:26 -0800	[thread overview]
Message-ID: <1393630893-29010-16-git-send-email-dgreid@chromium.org> (raw)
In-Reply-To: <1393630893-29010-1-git-send-email-dgreid@chromium.org>

Combining the call to alloc_cmd_io with the allocate pages function
removes an extra interface between hda_intel and hda_controller.

Signed-off-by: Dylan Reid <dgreid@chromium.org>
---
 sound/pci/hda/hda_controller.c | 7 ++++++-
 sound/pci/hda/hda_controller.h | 1 -
 sound/pci/hda/hda_intel.c      | 4 ----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index ed76f81..a7c5a5d 100644
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -1026,7 +1026,7 @@ EXPORT_SYMBOL_GPL(azx_attach_pcm_stream);
 /*
  * CORB / RIRB interface
  */
-int azx_alloc_cmd_io(struct azx *chip)
+static int azx_alloc_cmd_io(struct azx *chip)
 {
 	int err;
 
@@ -1549,6 +1549,11 @@ int azx_alloc_stream_pages(struct azx *chip)
 		dev_err(card->dev, "cannot allocate posbuf\n");
 		return -ENOMEM;
 	}
+
+	/* allocate CORB/RIRB */
+	err = azx_alloc_cmd_io(chip);
+	if (err < 0)
+		return err;
 	return 0;
 }
 EXPORT_SYMBOL_GPL(azx_alloc_stream_pages);
diff --git a/sound/pci/hda/hda_controller.h b/sound/pci/hda/hda_controller.h
index fb0cddd..3a3d78e 100644
--- a/sound/pci/hda/hda_controller.h
+++ b/sound/pci/hda/hda_controller.h
@@ -50,7 +50,6 @@ void azx_free_stream_pages(struct azx *chip);
 /*
  * CORB / RIRB interface
  */
-int azx_alloc_cmd_io(struct azx *chip);
 void azx_init_cmd_io(struct azx *chip);
 void azx_free_cmd_io(struct azx *chip);
 void azx_update_rirb(struct azx *chip);
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index a8af3d4..3d6ccb8 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1809,10 +1809,6 @@ static int azx_first_init(struct azx *chip)
 	err = azx_alloc_stream_pages(chip);
 	if (err < 0)
 		return err;
-	/* allocate CORB/RIRB */
-	err = azx_alloc_cmd_io(chip);
-	if (err < 0)
-		return err;
 
 	/* initialize streams */
 	azx_init_stream(chip);
-- 
1.8.1.3.605.g02339dd

  parent reply	other threads:[~2014-02-28 23:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 23:41 [RFC 00/19] Enable platform HDA drivers Dylan Reid
2014-02-28 23:41 ` [RFCv2 01/22] ALSA: hda - Move some definitions to new hda_priv.h Dylan Reid
2014-02-28 23:41 ` [RFCv2 02/22] ALSA: hda - Allow different ops to read/write registers Dylan Reid
2014-02-28 23:41 ` [RFCv2 03/22] ALSA: hda - Keep pointer to bdl_pos_fix in chip struct Dylan Reid
2014-02-28 23:41 ` [RFCv2 04/22] ALSA: hda - Use device pointer from the card instead of pci Dylan Reid
2014-02-28 23:41 ` [RFCv2 05/22] ALSA: hda - Add function pointer for disabling MSI Dylan Reid
2014-02-28 23:41 ` [RFCv2 06/22] ALSA: hda - remove unused clear of STATESTS Dylan Reid
2014-02-28 23:41 ` [RFCv2 07/22] ALSA: hda - Add jackpoll_ms to struct azx Dylan Reid
2014-02-28 23:41 ` [RFCv2 08/22] ALSA: hda - Pass max_slots and power_save to codec_create Dylan Reid
2014-02-28 23:41 ` [RFCv2 09/22] ALSA: hda - Move snd page allocation to ops Dylan Reid
2014-02-28 23:41 ` [RFCv2 10/22] ALSA: hda - Add pcm_mmap_prepare op Dylan Reid
2014-02-28 23:41 ` [RFCv2 11/22] ALSA: hda - Add hda_controller.c and move pcm ops from hda_intel Dylan Reid
2014-02-28 23:41 ` [RFCv2 12/22] ALSA: hda - Pull pages allocation to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 13/22] ALSA: hda - Move the dsp loader " Dylan Reid
2014-02-28 23:41 ` [RFCv2 14/22] ALSA: hda - Relocate RIRB/CORB interface " Dylan Reid
2014-02-28 23:41 ` Dylan Reid [this message]
2014-02-28 23:41 ` [RFCv2 16/22] ALSA: hda - Move low level functions " Dylan Reid
2014-02-28 23:41 ` [RFCv2 17/22] ALSA: hda - Add position_check op Dylan Reid
2014-02-28 23:41 ` [RFCv2 18/22] ALSA: hda - Move azx_interrupt to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 19/22] ALSA: hda - Move codec create " Dylan Reid
2014-02-28 23:41 ` [RFCv2 20/22] ALSA: core - Define snd_pci_quirk without CONFIG_PCI Dylan Reid
2014-02-28 23:41 ` [RFCv2 21/22] ALSA: hda - remove PCI dependency in Kconfig Dylan Reid
2014-02-28 23:41 ` [RFCv2 22/22] WIP: ALSA: hda - Add driver for Tegra SoC HDA Dylan Reid
2014-03-01  9:07 ` [RFC 00/19] Enable platform HDA drivers Takashi Iwai
2014-03-01  9:37   ` Dylan Reid
2014-03-01 10:42     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393630893-29010-16-git-send-email-dgreid@chromium.org \
    --to=dgreid@chromium.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=swarren@wwwdotorg.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox