From: Dylan Reid <dgreid@chromium.org>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Dylan Reid <dgreid@chromium.org>, swarren@wwwdotorg.org
Subject: [RFCv2 03/22] ALSA: hda - Keep pointer to bdl_pos_fix in chip struct
Date: Fri, 28 Feb 2014 15:41:14 -0800 [thread overview]
Message-ID: <1393630893-29010-4-git-send-email-dgreid@chromium.org> (raw)
In-Reply-To: <1393630893-29010-1-git-send-email-dgreid@chromium.org>
This will allow for a platform hda driver to use it as well. It
removes the dependency on the module param from hda_intel, which will
allow for azx_setup_periods to be shared.
Signed-off-by: Dylan Reid <dgreid@chromium.org>
---
sound/pci/hda/hda_intel.c | 12 ++++++++----
sound/pci/hda/hda_priv.h | 1 +
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 45718fb..9fcd1d1 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1147,7 +1147,7 @@ static int azx_setup_periods(struct azx *chip,
{
u32 *bdl;
int i, ofs, periods, period_bytes;
- int pos_adj;
+ int pos_adj = 0;
/* reset BDL address */
azx_sd_writel(chip, azx_dev, SD_BDLPL, 0);
@@ -1160,7 +1160,9 @@ static int azx_setup_periods(struct azx *chip,
bdl = (u32 *)azx_dev->bdl.area;
ofs = 0;
azx_dev->frags = 0;
- pos_adj = bdl_pos_adj[chip->dev_index];
+
+ if (chip->bdl_pos_adj)
+ pos_adj = chip->bdl_pos_adj[chip->dev_index];
if (!azx_dev->no_period_wakeup && pos_adj > 0) {
struct snd_pcm_runtime *runtime = substream->runtime;
int pos_align = pos_adj;
@@ -1173,7 +1175,7 @@ static int azx_setup_periods(struct azx *chip,
pos_adj = frames_to_bytes(runtime, pos_adj);
if (pos_adj >= period_bytes) {
dev_warn(chip->card->dev,"Too big adjustment %d\n",
- bdl_pos_adj[chip->dev_index]);
+ pos_adj);
pos_adj = 0;
} else {
ofs = setup_bdle(chip, snd_pcm_get_dma_buf(substream),
@@ -1184,6 +1186,7 @@ static int azx_setup_periods(struct azx *chip,
}
} else
pos_adj = 0;
+
for (i = 0; i < periods; i++) {
if (i == periods - 1 && pos_adj)
ofs = setup_bdle(chip, snd_pcm_get_dma_buf(substream),
@@ -2143,7 +2146,7 @@ static int azx_position_ok(struct azx *chip, struct azx_dev *azx_dev)
if (wallclk < (azx_dev->period_wallclk * 5) / 4 &&
pos % azx_dev->period_bytes > azx_dev->period_bytes / 2)
/* NG - it's below the first next period boundary */
- return bdl_pos_adj[chip->dev_index] ? 0 : -1;
+ return chip->bdl_pos_adj[chip->dev_index] ? 0 : -1;
azx_dev->start_wallclk += wallclk;
return 1; /* OK, it's fine */
}
@@ -3207,6 +3210,7 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci,
break;
}
}
+ chip->bdl_pos_adj = bdl_pos_adj;
err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops);
if (err < 0) {
diff --git a/sound/pci/hda/hda_priv.h b/sound/pci/hda/hda_priv.h
index 6d082d6..17afe90 100644
--- a/sound/pci/hda/hda_priv.h
+++ b/sound/pci/hda/hda_priv.h
@@ -357,6 +357,7 @@ struct azx {
/* flags */
int position_fix[2]; /* for both playback/capture streams */
+ const int *bdl_pos_adj;
int poll_count;
unsigned int running:1;
unsigned int initialized:1;
--
1.8.1.3.605.g02339dd
next prev parent reply other threads:[~2014-02-28 23:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 23:41 [RFC 00/19] Enable platform HDA drivers Dylan Reid
2014-02-28 23:41 ` [RFCv2 01/22] ALSA: hda - Move some definitions to new hda_priv.h Dylan Reid
2014-02-28 23:41 ` [RFCv2 02/22] ALSA: hda - Allow different ops to read/write registers Dylan Reid
2014-02-28 23:41 ` Dylan Reid [this message]
2014-02-28 23:41 ` [RFCv2 04/22] ALSA: hda - Use device pointer from the card instead of pci Dylan Reid
2014-02-28 23:41 ` [RFCv2 05/22] ALSA: hda - Add function pointer for disabling MSI Dylan Reid
2014-02-28 23:41 ` [RFCv2 06/22] ALSA: hda - remove unused clear of STATESTS Dylan Reid
2014-02-28 23:41 ` [RFCv2 07/22] ALSA: hda - Add jackpoll_ms to struct azx Dylan Reid
2014-02-28 23:41 ` [RFCv2 08/22] ALSA: hda - Pass max_slots and power_save to codec_create Dylan Reid
2014-02-28 23:41 ` [RFCv2 09/22] ALSA: hda - Move snd page allocation to ops Dylan Reid
2014-02-28 23:41 ` [RFCv2 10/22] ALSA: hda - Add pcm_mmap_prepare op Dylan Reid
2014-02-28 23:41 ` [RFCv2 11/22] ALSA: hda - Add hda_controller.c and move pcm ops from hda_intel Dylan Reid
2014-02-28 23:41 ` [RFCv2 12/22] ALSA: hda - Pull pages allocation to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 13/22] ALSA: hda - Move the dsp loader " Dylan Reid
2014-02-28 23:41 ` [RFCv2 14/22] ALSA: hda - Relocate RIRB/CORB interface " Dylan Reid
2014-02-28 23:41 ` [RFCv2 15/22] ALSA: hda - move alloc_cmd_io " Dylan Reid
2014-02-28 23:41 ` [RFCv2 16/22] ALSA: hda - Move low level functions " Dylan Reid
2014-02-28 23:41 ` [RFCv2 17/22] ALSA: hda - Add position_check op Dylan Reid
2014-02-28 23:41 ` [RFCv2 18/22] ALSA: hda - Move azx_interrupt to hda_controller Dylan Reid
2014-02-28 23:41 ` [RFCv2 19/22] ALSA: hda - Move codec create " Dylan Reid
2014-02-28 23:41 ` [RFCv2 20/22] ALSA: core - Define snd_pci_quirk without CONFIG_PCI Dylan Reid
2014-02-28 23:41 ` [RFCv2 21/22] ALSA: hda - remove PCI dependency in Kconfig Dylan Reid
2014-02-28 23:41 ` [RFCv2 22/22] WIP: ALSA: hda - Add driver for Tegra SoC HDA Dylan Reid
2014-03-01 9:07 ` [RFC 00/19] Enable platform HDA drivers Takashi Iwai
2014-03-01 9:37 ` Dylan Reid
2014-03-01 10:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393630893-29010-4-git-send-email-dgreid@chromium.org \
--to=dgreid@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox