From: Mark Brown <broonie@sirena.org.uk>
To: Ben Dooks <ben-alsa@fluff.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [patch 2/9] JIVE: Add ASoC audio support
Date: Wed, 4 Mar 2009 14:57:02 +0000 [thread overview]
Message-ID: <20090304145700.GG433@sirena.org.uk> (raw)
In-Reply-To: <20090304005138.373218569@fluff.org.uk>
On Wed, Mar 04, 2009 at 12:49:27AM +0000, Ben Dooks wrote:
> +static int jive_startup(struct snd_pcm_substream *substream)
> +{
> + struct snd_soc_pcm_runtime *rtd = substream->private_data;
> + struct snd_soc_codec *codec = rtd->socdev->codec;
> +
> + snd_soc_dapm_enable_pin(codec, "Headphone Jack");
> + snd_soc_dapm_enable_pin(codec, "Internal Speaker");
> + snd_soc_dapm_enable_pin(codec, "Line In");
> +
> + snd_soc_dapm_sync(codec);
> +
> + return 0;
> +}
As previously mentioned this function should be removed: the default
state of pins is that they're enabled and you never disable these pins
so there will be no effect.
> + /* These endpoints are not being used. */
> + snd_soc_dapm_disable_pin(codec, "LINPUT2");
> + snd_soc_dapm_disable_pin(codec, "RINPUT2");
> + snd_soc_dapm_disable_pin(codec, "LINPUT3");
> + snd_soc_dapm_disable_pin(codec, "RINPUT3");
> + snd_soc_dapm_disable_pin(codec, "OUT3");
> + snd_soc_dapm_disable_pin(codec, "MONO");
Should be snd_soc_dapm_nc_pin().
> + printk("JIVE WM8750 Audio support\n");
Should have KERN_INFO or use pr_info().
next prev parent reply other threads:[~2009-03-04 14:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 0:49 [patch 0/9] S3C24XX/S3C64XX updates Ben Dooks
2009-03-04 0:49 ` [patch 1/9] S3C24XX: Move and update IIS headers Ben Dooks
2009-03-04 0:49 ` [patch 2/9] JIVE: Add ASoC audio support Ben Dooks
2009-03-04 14:57 ` Mark Brown [this message]
2009-03-04 0:49 ` [patch 3/9] S3C: Move <mach/audio.h> to <plat/audio.h> Ben Dooks
2009-03-04 0:49 ` [patch 4/9] S3C24XX ASoC: Fix copyright statements on Simtec files Ben Dooks
2009-03-04 19:20 ` Mark Brown
2009-03-04 0:49 ` [patch 5/9] S3C: Split s3c2412-i2s.c into core and SoC specific parts Ben Dooks
2009-03-04 19:52 ` Mark Brown
2009-03-04 0:49 ` [patch 6/9] S3C64XX: Add s3c64xx-i2s support Ben Dooks
2009-03-04 0:56 ` Ben Dooks
2009-03-04 19:56 ` Mark Brown
2009-03-04 0:49 ` [patch 7/9] ASoC: Ensure codec check hw_write error at probe Ben Dooks
2009-03-04 19:57 ` Mark Brown
2009-03-04 0:49 ` [patch 8/9] SMDK6410: Add support for WM8731 on an add-on board Ben Dooks
2009-03-04 20:06 ` Mark Brown
2009-03-04 0:49 ` [patch 9/9] AUDIO: Select DMA if I2S is configured Ben Dooks
2009-03-04 20:29 ` [patch 0/9] S3C24XX/S3C64XX updates Mark Brown
2009-03-05 7:23 ` Takashi Iwai
2009-03-05 10:31 ` Mark Brown
2009-03-05 10:36 ` Takashi Iwai
2009-03-05 11:03 ` Mark Brown
2009-03-11 10:39 ` Ben Dooks
2009-03-11 12:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304145700.GG433@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=ben-alsa@fluff.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox