Re: [patch 8/9] SMDK6410: Add support for WM8731 on an add-on board

[Mark Brown <broonie@sirena.org.uk>]

On Wed, Mar 04, 2009 at 12:49:33AM +0000, Ben Dooks wrote:
> Add support for an WM8731 connected to an SMDK6410 instead
> of the onboard codec.

> Signed-off-by: Ben Dooks <benb@simtec.co.uk>

Is there any plan to make this board generally available?  IIRC it was a
flying wire board rather than a plugin for the baseband connector on the
SMDK6410.  I'd prefer not to start merging flying wire systems since the
numbers tend to multiply (I do rather a lot myself!).

> +static void wm_shutdown(struct snd_pcm_substream *substream)
> +{
> +	printk(KERN_INFO "%s: substream %p\n", __func__, substream);
> +}

This and several of the other printks in the driver are a bit chatty...
pr_dbg()?

> +	//fmt = SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_CBS_CFS;

C++ comment.

> +struct wm8731_setup_data wm_setup = {
> +	.i2c_bus	= 0,
> +	.i2c_address	= 0x1a,
> +};

This won't build with current git - the WM8731 has been refactored to
probe using the standard I2C registration stuff.  See the driver in
atmel/sam9g20_wm8731.c for an example, essentially all that needs doing
is to remove the struct here.