From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
Jeeja KP <jeeja.kp@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v5 2/4] ASoC: Intel - add Skylake HDA audio driver
Date: Tue, 16 Jun 2015 11:28:26 +0100 [thread overview]
Message-ID: <20150616102826.GF18309@sirena.org.uk> (raw)
In-Reply-To: <20150616035247.GT28601@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]
On Tue, Jun 16, 2015 at 09:22:47AM +0530, Vinod Koul wrote:
> On Mon, Jun 15, 2015 at 04:56:33PM +0100, Mark Brown wrote:
> > > +static const struct hdac_io_ops skl_io_ops = {
> > > + .reg_writel = skl_pci_writel,
> > > + .reg_readl = skl_pci_readl,
> > > + .reg_writew = skl_pci_writew,
> > > + .reg_readw = skl_pci_readw,
> > > + .reg_writeb = skl_pci_writeb,
> > > + .reg_readb = skl_pci_readb,
> > > + .dma_alloc_pages = skl_dma_alloc_pages,
> > > + .dma_free_pages = skl_dma_free_pages,
> > > +};
> > Still not thrilled at open coding these wrappers.
> If we have this is core, I will remove the part :)
You could always send changes to add default ops to the core!
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-06-16 10:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 16:33 [PATCH v5 0/4] ASoC: intel - add skylake PCM driver Vinod Koul
2015-06-11 16:33 ` [PATCH v5 1/4] ASoC: Intel: add Skylake HDA platform driver Vinod Koul
2015-06-11 16:33 ` [PATCH v5 2/4] ASoC: Intel - add Skylake HDA audio driver Vinod Koul
2015-06-15 15:56 ` Mark Brown
2015-06-15 16:35 ` Takashi Iwai
2015-06-15 16:42 ` Mark Brown
2015-06-15 16:46 ` Takashi Iwai
2015-06-16 15:25 ` Vinod Koul
2015-06-16 15:27 ` Takashi Iwai
2015-06-16 3:52 ` Vinod Koul
2015-06-16 10:28 ` Mark Brown [this message]
2015-06-16 15:24 ` Vinod Koul
2015-06-16 15:28 ` Takashi Iwai
2015-06-11 16:33 ` [PATCH v5 3/4] ASoC: Intel - add makefile support for SKL driver Vinod Koul
2015-06-15 15:57 ` Mark Brown
2015-06-15 16:42 ` Takashi Iwai
2015-06-15 18:54 ` Mark Brown
2015-06-16 4:44 ` Vinod Koul
2015-06-16 10:43 ` Mark Brown
2015-06-16 15:22 ` Vinod Koul
2015-06-16 5:01 ` Takashi Iwai
2015-06-16 10:52 ` Mark Brown
2015-06-11 16:33 ` [PATCH v5 4/4] ASoC: intel - adds support for decoupled mode in skl driver Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616102826.GF18309@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox