Re: [PATCH v5 3/4] ASoC: Intel - add makefile support for SKL driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1195 bytes --]

On Tue, Jun 16, 2015 at 07:01:58AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > That doesn't sound like a compatibility thing though?  Compatibility
> > makes it sound like things will break rather than we'll just use too
> > much RAM.  Is there anything else going on?

> Before the parameter was introduced, the allocation was fixed to
> 64kB.  Thus if you really want to make the driver behaving compatible
> as before, it should be 64kB -- not only reducing the memory
> footprint, it also keeps the same behavior.

Sure, but given that this is per driver applications really ought to be
able to cope with random values.

> > I'm not against having configuration, I just want it to be configuration
> > that people can understand and it seems better to make the default be
> > that for PulseAudio given how much of the common case it is now.
> > Something like "make this smaller to reduce the default memory
> > footprint" for example.

> We have no consensus how much size should be given here; e.g. I myself
> am not so convinced by a merit of so big buffer allocation like 2MB.

That's fair enough, though we do have to pick a default and like I say
the text should reflect this.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]