Re: [PATCH v5 2/4] ASoC: Intel - add Skylake HDA audio driver

[Vinod Koul <vinod.koul@intel.com>]

On Tue, Jun 16, 2015 at 11:28:26AM +0100, Mark Brown wrote:
> On Tue, Jun 16, 2015 at 09:22:47AM +0530, Vinod Koul wrote:
> > On Mon, Jun 15, 2015 at 04:56:33PM +0100, Mark Brown wrote:
> 
> > > > +static const struct hdac_io_ops skl_io_ops = {
> > > > +	.reg_writel = skl_pci_writel,
> > > > +	.reg_readl = skl_pci_readl,
> > > > +	.reg_writew = skl_pci_writew,
> > > > +	.reg_readw = skl_pci_readw,
> > > > +	.reg_writeb = skl_pci_writeb,
> > > > +	.reg_readb = skl_pci_readb,
> > > > +	.dma_alloc_pages = skl_dma_alloc_pages,
> > > > +	.dma_free_pages = skl_dma_free_pages,
> > > > +};
> 
> > > Still not thrilled at open coding these wrappers.
> 
> > If we have this is core, I will remove the part :)
> 
> You could always send changes to add default ops to the core!
Takashi, you okay with that approach?

Thanks
-- 
~Vinod