Re: [PATCH v5 3/4] ASoC: Intel - add makefile support for SKL driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1090 bytes --]

On Tue, Jun 16, 2015 at 10:14:58AM +0530, Vinod Koul wrote:

> We have been using defaults for our testing, and PA and other usermode
> entities seem happy :)

> Btw Mark, the text is not our invention. This exists in legacy driver
> as well.

So you're cargo culting it without really understanding it which isn't
so great...

> Said that, i see two thing to be done here, one is to remove this in SKL
> driver for now and if required add it later with better explanation as for
> now usermode seems happy atm, so may not be required right away

Based on what Takashi said it seems this is a memory consumption tuning
knob so it sounds like the low memory work that some of your colleagues
are doing is going to want to add it back sooner rather than later?  It
seems like a reasonable thing to tune, it's just that the text needs to
be updated to reflect reality.

> Second one is to actually make this in core, move the flag in legacy driver to
> hdac parts and be used in legacy driver as well as anywhere else

That's good, of course - just have one config option for all HDA
drivers.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]