From: Mark Brown <broonie@kernel.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@lists.codethink.co.uk, Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Edward Cragg <edward.cragg@codethink.co.uk>,
linux-tegra@vger.kernel.org, linux-tegra-owner@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/8] ASoC: tegra: Allow 24bit and 32bit samples
Date: Wed, 18 Sep 2019 13:05:56 +0100 [thread overview]
Message-ID: <20190918120553.GE2596@sirena.co.uk> (raw)
In-Reply-To: <943c243563b4936a537b52b6c3b1fd99@codethink.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 869 bytes --]
On Wed, Sep 18, 2019 at 12:50:13PM +0100, Ben Dooks wrote:
> On 2019-09-18 11:08, Mark Brown wrote:
> > > Yes, will do when this series has been reviewed and modifications
> > > done.
> > I didn't look at it due to the lack of signoffs.
> Thanks, although you could have just flagged this and reviewed the rest
> anyway. I'll post a new version with signoff sorted at the end of the week
> as I cannot get in to the office to test any changes until Friday.
None of the patches I looked at had signoffs, Pierre had already told
you about that problem and there were a bunch of other review comments
anyway before I saw the series so it was fairly clear that a new version
is needed anyway. Once you've got some review you shouldn't rely on
getting extra review explicitly since it's not generally useful to repeat
the same review comments others have already made.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-18 12:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:12 [alsa-devel] RFC: TDM mode support on the tegra30 Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 1/8] ASoC: tegra: Add a TDM configuration callback Ben Dooks
2019-09-17 18:22 ` Pierre-Louis Bossart
2019-09-18 8:42 ` Jon Hunter
2019-09-18 10:11 ` Ben Dooks
2019-09-18 10:25 ` Jon Hunter
2019-09-18 10:48 ` Mark Brown
2019-09-18 11:44 ` Ben Dooks
2019-09-18 13:33 ` Pierre-Louis Bossart
2019-09-18 15:02 ` Mark Brown
2019-09-17 18:12 ` [alsa-devel] [PATCH 2/8] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-09-17 18:26 ` Pierre-Louis Bossart
2019-09-18 7:44 ` Ben Dooks
2019-09-18 10:08 ` Mark Brown
2019-09-18 11:50 ` Ben Dooks
2019-09-18 12:05 ` Mark Brown [this message]
2019-09-17 18:12 ` [alsa-devel] [PATCH 3/8] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-09-18 8:50 ` Jon Hunter
2019-09-18 10:12 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 4/8] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly Ben Dooks
2019-09-17 19:33 ` kbuild test robot
2019-09-18 8:54 ` Jon Hunter
2019-09-18 9:02 ` Jon Hunter
2019-09-18 10:15 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 6/8] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-09-18 9:02 ` Jon Hunter
2019-09-18 11:30 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 7/8] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-09-18 9:14 ` Jon Hunter
2019-09-18 11:41 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 8/8] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
2019-09-18 9:16 ` Jon Hunter
2019-09-18 10:02 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918120553.GE2596@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=edward.cragg@codethink.co.uk \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra-owner@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox