From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Jon Hunter <jonathanh@nvidia.com>
Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Edward Cragg <edward.cragg@codethink.co.uk>,
linux-tegra@vger.kernel.org, linux-tegra-owner@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/8] ASoC: tegra: Add a TDM configuration callback
Date: Wed, 18 Sep 2019 08:33:50 -0500 [thread overview]
Message-ID: <40d78f13-c1b9-3e2d-c144-2209a4c0d716@linux.intel.com> (raw)
In-Reply-To: <20190918104827.GB2596@sirena.co.uk>
On 9/18/19 5:48 AM, Mark Brown wrote:
> On Wed, Sep 18, 2019 at 11:25:39AM +0100, Jon Hunter wrote:
>
>> Why 2? From looking at various codecs that support dsp-a/b modes, it is
>> more common for the f-sync to be 1 regardless of the number of slots.
>
> In DSP modes only one edge really matters anyway so it's not super
> important how long the pulse is.
There are exceptions to the rule.
In the early days of SOF, we had to provide support for amplifiers that
did require a pulse larger than a bit. In the SOF IPC we added an
'frame_pulse_width' field to pass the configuration all the way from
topology to the firmware and Intel SSP driver.
The other quirk we added is the ability to control zero-padding per slot
instead of at the end of the frame, e.g. 1 bit of padding after 24 bits
when using 4 slots w/ 25 bits in a 100-bit frame.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-18 13:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:12 [alsa-devel] RFC: TDM mode support on the tegra30 Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 1/8] ASoC: tegra: Add a TDM configuration callback Ben Dooks
2019-09-17 18:22 ` Pierre-Louis Bossart
2019-09-18 8:42 ` Jon Hunter
2019-09-18 10:11 ` Ben Dooks
2019-09-18 10:25 ` Jon Hunter
2019-09-18 10:48 ` Mark Brown
2019-09-18 11:44 ` Ben Dooks
2019-09-18 13:33 ` Pierre-Louis Bossart [this message]
2019-09-18 15:02 ` Mark Brown
2019-09-17 18:12 ` [alsa-devel] [PATCH 2/8] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-09-17 18:26 ` Pierre-Louis Bossart
2019-09-18 7:44 ` Ben Dooks
2019-09-18 10:08 ` Mark Brown
2019-09-18 11:50 ` Ben Dooks
2019-09-18 12:05 ` Mark Brown
2019-09-17 18:12 ` [alsa-devel] [PATCH 3/8] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-09-18 8:50 ` Jon Hunter
2019-09-18 10:12 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 4/8] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly Ben Dooks
2019-09-17 19:33 ` kbuild test robot
2019-09-18 8:54 ` Jon Hunter
2019-09-18 9:02 ` Jon Hunter
2019-09-18 10:15 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 6/8] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-09-18 9:02 ` Jon Hunter
2019-09-18 11:30 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 7/8] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-09-18 9:14 ` Jon Hunter
2019-09-18 11:41 ` Ben Dooks
2019-09-17 18:12 ` [alsa-devel] [PATCH 8/8] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
2019-09-18 9:16 ` Jon Hunter
2019-09-18 10:02 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40d78f13-c1b9-3e2d-c144-2209a4c0d716@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=edward.cragg@codethink.co.uk \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra-owner@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox