Re: [PATCH 2/2] ASoC: dt-bindings: rt5682s: add bindings for rt5682s

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

On Thu, Aug 26, 2021 at 04:09:38PM +0800, derek.fang@realtek.com wrote:

> +  realtek,dmic1-data-pin:
> +    enum:
> +      - 0 # dmic1 is not used
> +      - 1 # using GPIO2 pin as dmic1 data pin
> +      - 2 # using GPIO5 pin as dmic1 data pin
> +
> +  realtek,dmic1-clk-pin:
> +    enum:
> +      - 0 #using GPIO1 pin as dmic1 clock pin
> +      - 1 #using GPIO3 pin as dmic1 clock pin

It works but it's a bit weird that there's no unused option on the clock
- I'd expect this to be symmetric.

> +  realtek,jd-src:
> +    enum:
> +      - 0 # No JD is used
> +      - 1 # using JD1 as JD source

Are there other possible JD sources which are not supported yet?

> +  realtek,dmic-delay-ms:
> +    description: |
> +      Set the delay time (ms) for the requirement of the particular DMIC.

Startup delay or some other delay?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]