Re: [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4852 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on v5.14-rc7 next-20210826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/derek-fang-realtek-com/ASoC-rt5682s-Add-driver-for-ALC5682I-VS-codec/20210826-161340
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: sparc64-randconfig-p002-20210826 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3d7b4fdb7110791febbe2878e436192952b2cd5b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review derek-fang-realtek-com/ASoC-rt5682s-Add-driver-for-ALC5682I-VS-codec/20210826-161340
        git checkout 3d7b4fdb7110791febbe2878e436192952b2cd5b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/rt5682s.c:64:6: warning: no previous prototype for 'rt5682s_apply_patch_list' [-Wmissing-prototypes]
      64 | void rt5682s_apply_patch_list(struct rt5682s_priv *rt5682s,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:441:6: warning: no previous prototype for 'rt5682s_volatile_register' [-Wmissing-prototypes]
     441 | bool rt5682s_volatile_register(struct device *dev, unsigned int reg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:483:6: warning: no previous prototype for 'rt5682s_readable_register' [-Wmissing-prototypes]
     483 | bool rt5682s_readable_register(struct device *dev, unsigned int reg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:623:6: warning: no previous prototype for 'rt5682s_reset' [-Wmissing-prototypes]
     623 | void rt5682s_reset(struct rt5682s_priv *rt5682s)
         |      ^~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:735:5: warning: no previous prototype for 'rt5682s_headset_detect' [-Wmissing-prototypes]
     735 | int rt5682s_headset_detect(struct snd_soc_component *component, int jack_insert)
         |     ^~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:822:6: warning: no previous prototype for 'rt5682s_jack_detect_handler' [-Wmissing-prototypes]
     822 | void rt5682s_jack_detect_handler(struct work_struct *work)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:2907:5: warning: no previous prototype for 'rt5682s_parse_dt' [-Wmissing-prototypes]
    2907 | int rt5682s_parse_dt(struct rt5682s_priv *rt5682s, struct device *dev)
         |     ^~~~~~~~~~~~~~~~
>> sound/soc/codecs/rt5682s.c:2936:6: warning: no previous prototype for 'rt5682s_calibrate' [-Wmissing-prototypes]
    2936 | void rt5682s_calibrate(struct rt5682s_priv *rt5682s)
         |      ^~~~~~~~~~~~~~~~~
   In file included from sound/soc/codecs/rt5682s.c:26:
   sound/soc/codecs/rt5682s.c:1014:29: warning: 'rt5682s_sar_mode_enum' defined but not used [-Wunused-const-variable=]
    1014 | static SOC_ENUM_SINGLE_DECL(rt5682s_sar_mode_enum, 0, 0,
         |                             ^~~~~~~~~~~~~~~~~~~~~
   include/sound/soc.h:352:31: note: in definition of macro 'SOC_ENUM_DOUBLE_DECL'
     352 |         const struct soc_enum name = SOC_ENUM_DOUBLE(xreg, xshift_l, xshift_r, \
         |                               ^~~~
   sound/soc/codecs/rt5682s.c:1014:8: note: in expansion of macro 'SOC_ENUM_SINGLE_DECL'
    1014 | static SOC_ENUM_SINGLE_DECL(rt5682s_sar_mode_enum, 0, 0,
         |        ^~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_SOC_MT6359
   Depends on SOUND && !UML && SND && SND_SOC && MTK_PMIC_WRAP
   Selected by
   - SND_SOC_MT8195_MT6359_RT1019_RT5682 && SOUND && !UML && SND && SND_SOC && I2C && SND_SOC_MT8195


vim +/rt5682s_apply_patch_list +64 sound/soc/codecs/rt5682s.c

    63	
  > 64	void rt5682s_apply_patch_list(struct rt5682s_priv *rt5682s,
    65			struct device *dev)
    66	{
    67		int ret;
    68	
    69		ret = regmap_multi_reg_write(rt5682s->regmap, patch_list, ARRAY_SIZE(patch_list));
    70		if (ret)
    71			dev_warn(dev, "Failed to apply regmap patch: %d\n", ret);
    72	}
    73	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44915 bytes --]