From: Mark Brown <broonie@kernel.org>
To: "Derek [方德義]" <derek.fang@realtek.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Albert Chen" <albertchen@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec
Date: Fri, 3 Sep 2021 13:30:58 +0100 [thread overview]
Message-ID: <20210903123058.GI4932@sirena.org.uk> (raw)
In-Reply-To: <e2ad57c54ea0422d8083bbf2b116563c@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Fri, Aug 27, 2021 at 05:59:30AM +0000, Derek [方德義] wrote:
> > > +#ifdef CONFIG_COMMON_CLK
> > > + /* Check if MCLK provided */
> > > + rt5682s->mclk = devm_clk_get(component->dev, "mclk");
> >
> > Perhaps factor the clock init out into a _probe_clks() function and then have a
> > stub function rather than the two ifdefs?
> We want to factor the codes like below to reduce ifdefs.
> Could you give any comments?
That looks fine.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-03 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 8:09 [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec derek.fang
2021-08-26 8:09 ` [PATCH 2/2] ASoC: dt-bindings: rt5682s: add bindings for rt5682s derek.fang
2021-08-26 11:34 ` Mark Brown
2021-08-26 12:14 ` [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec Mark Brown
[not found] ` <e2ad57c54ea0422d8083bbf2b116563c@realtek.com>
2021-09-03 12:30 ` Mark Brown [this message]
2021-08-26 16:57 ` kernel test robot
2021-08-26 21:25 ` kernel test robot
2021-08-31 10:56 ` Bard liao
2021-08-31 12:37 ` Derek [方德義]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903123058.GI4932@sirena.org.uk \
--to=broonie@kernel.org \
--cc=albertchen@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox