From: Bard liao <yung-chuan.liao@linux.intel.com>
To: derek.fang@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, jack.yu@realtek.com,
alsa-devel@alsa-project.org, lars@metafoo.de,
albertchen@realtek.com, shumingf@realtek.com, flove@realtek.com
Subject: Re: [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec
Date: Tue, 31 Aug 2021 18:56:46 +0800 [thread overview]
Message-ID: <8d4c9eed-e641-36c9-6727-ac744e87ff45@linux.intel.com> (raw)
In-Reply-To: <20210826080938.14872-1-derek.fang@realtek.com>
On 8/26/2021 4:09 PM, derek.fang@realtek.com wrote:
> +
> +static int is_sys_clk_from_plla(struct snd_soc_dapm_widget *w,
> + struct snd_soc_dapm_widget *sink)
> +{
> + struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> + struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
> +
> + if ((rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL1) ||
> + (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2 &&
> + rt5682s->pll_comb == USE_PLLAB))
What about rt5682s->pll_comb == USE_PLLA?
> + return 1;
> +
> + return 0;
> +}
> +
> +static int is_sys_clk_from_pllb(struct snd_soc_dapm_widget *w,
> + struct snd_soc_dapm_widget *sink)
> +{
> + struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> + struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
> +
> + if (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2)
Should we also test rt5682s->pll_comb here?
> + return 1;
> +
> + return 0;
> +}
>
next prev parent reply other threads:[~2021-08-31 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 8:09 [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec derek.fang
2021-08-26 8:09 ` [PATCH 2/2] ASoC: dt-bindings: rt5682s: add bindings for rt5682s derek.fang
2021-08-26 11:34 ` Mark Brown
2021-08-26 12:14 ` [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec Mark Brown
[not found] ` <e2ad57c54ea0422d8083bbf2b116563c@realtek.com>
2021-09-03 12:30 ` Mark Brown
2021-08-26 16:57 ` kernel test robot
2021-08-26 21:25 ` kernel test robot
2021-08-31 10:56 ` Bard liao [this message]
2021-08-31 12:37 ` Derek [方德義]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d4c9eed-e641-36c9-6727-ac744e87ff45@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=albertchen@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox