Re: [PATCH v3 13/14] ASoC: SOF: Add xtensa support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 12/11/18 5:08 PM, Andy Shevchenko wrote:
> On Tue, Dec 11, 2018 at 03:23:17PM -0600, Pierre-Louis Bossart wrote:
>> Add common directory for xtensa architecture
>> +	for (i = 0; i <= stack_words - 4; i += 4) {
>> +		dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x 0x%8.8x 0x%8.8x\n",
>> +			stack_ptr + i, stack[i], stack[i + 1], stack[i + 2],
>> +			stack[i + 3]);
>> +	}
>> +
>> +	/* deal with any remaining words */
>> +	switch (stack_words - i) {
>> +	case 0:
>> +		break;
>> +	case 1:
>> +		dev_err(sdev->dev, "0x%8.8x: 0x%8.8x\n",
>> +			stack_ptr + stack_words - 1, stack[stack_words - 1]);
>> +		break;
>> +	case 2:
>> +		dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x\n",
>> +			stack_ptr + stack_words - 2, stack[stack_words - 2],
>> +			stack[stack_words - 1]);
>> +		break;
>> +	case 3:
>> +		dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x 0x%8.8x\n",
>> +			stack_ptr + stack_words - 3, stack[stack_words - 3],
>> +			stack[stack_words - 2], stack[stack_words - 1]);
>> +		break;
>> +	default:
>> +		break;
>> +	}
> hex_dump_to_buffer().
I vaguely recall there was a reason not to do it, we'll relook at this.