Re: [Sound-open-firmware] [PATCH v3 13/14] ASoC: SOF: Add xtensa support

From: "rander.wang" <rander.wang@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
	Pan Xiuli <xiuli.pan@linux.intel.com>,
	Daniel Baluta <daniel.baluta@gmail.com>,
	liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
	broonie@kernel.org, sound-open-firmware@alsa-project.org,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [Sound-open-firmware] [PATCH v3 13/14] ASoC: SOF: Add xtensa support
Date: Thu, 13 Dec 2018 17:58:44 +0800	[thread overview]
Message-ID: <9d4269b0-baca-fd4e-a8a2-5da7ea5a851a@linux.intel.com> (raw)
In-Reply-To: <93aff9af-c693-c951-4821-e9e334133ed0@linux.intel.com>

在 12/13/2018 2:15 PM, rander.wang 写道:
>
> 在 12/12/2018 8:00 AM, Pierre-Louis Bossart 写道:
>>
>> On 12/11/18 5:08 PM, Andy Shevchenko wrote:
>>> On Tue, Dec 11, 2018 at 03:23:17PM -0600, Pierre-Louis Bossart wrote:
>>>> Add common directory for xtensa architecture
>>>> +    for (i = 0; i <= stack_words - 4; i += 4) {
>>>> +        dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x 0x%8.8x 
>>>> 0x%8.8x\n",
>>>> +            stack_ptr + i, stack[i], stack[i + 1], stack[i + 2],
>>>> +            stack[i + 3]);
>>>> +    }
>>>> +
>>>> +    /* deal with any remaining words */
>>>> +    switch (stack_words - i) {
>>>> +    case 0:
>>>> +        break;
>>>> +    case 1:
>>>> +        dev_err(sdev->dev, "0x%8.8x: 0x%8.8x\n",
>>>> +            stack_ptr + stack_words - 1, stack[stack_words - 1]);
>>>> +        break;
>>>> +    case 2:
>>>> +        dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x\n",
>>>> +            stack_ptr + stack_words - 2, stack[stack_words - 2],
>>>> +            stack[stack_words - 1]);
>>>> +        break;
>>>> +    case 3:
>>>> +        dev_err(sdev->dev, "0x%8.8x: 0x%8.8x 0x%8.8x 0x%8.8x\n",
>>>> +            stack_ptr + stack_words - 3, stack[stack_words - 3],
>>>> +            stack[stack_words - 2], stack[stack_words - 1]);
>>>> +        break;
>>>> +    default:
>>>> +        break;
>>>> +    }
>>> hex_dump_to_buffer().
>> I vaguely recall there was a reason not to do it, we'll relook at this.
>>
> we don't want to convert a blob of data to "hex ASCII" in memory 
> (hex_dump_to_buffer).
>
> Here, we just want to dump the content of call stack, like:
>
> [    3.250628] sof-audio sof-audio: 0x0049fbb0: 0x8000f2d0 0x0049fc00 
> 0x6f6c6c61 0x00632e63
> [    3.250670] sof-audio sof-audio: 0x0049fbb4: 0x00ffffff 0x0010b5d4 
> 0x00000000 0x2000004c
> [    3.250710] sof-audio sof-audio: 0x0049fbb8: 0x0040d000 0x00000000 
> 0x0000024c 0x2000930c
> [    3.250747] sof-audio sof-audio: 0x0049fbbc: 0x8000454c 0x0049fc30 
> 0x00401e20 0x00000001
> [    3.250787] sof-audio sof-audio: 0x0049fbc0: 0x8000454c 0x0049fc30 
> 0x00401e20 0x00000001
> [    3.250827] sof-audio sof-audio: 0x0049fbc4: 0x00000000 0x00000001 
> 0x00000010 0x0049fcb8
> [    3.250865] sof-audio sof-audio: 0x0049fbc8: 0x0040a000 0x00401e98 
> 0x00000001 0x00000002
> [    3.250889] sof-audio sof-audio: 0x0049fbcc: 0x80005ac5 0x0049fc60 
> 0x00000000 0x00000000

Add more details: we use another tool to analysis the hex numbers with a 
ELF file to get the correct information, so we do it by ourself.

Thanks!

Rander

>> _______________________________________________
>> Sound-open-firmware mailing list
>> Sound-open-firmware@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel