RE: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot

[Kailang <kailang@realtek.com>]

[-- Attachment #1: Type: text/plain, Size: 2566 bytes --]

Hi Joseph,

Could you test attach patch?

BR,
Kailang

> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Tuesday, July 4, 2023 4:46 PM
> To: Kailang <kailang@realtek.com>
> Cc: Joseph C. Sible <josephcsible@gmail.com>; Bagas Sanjaya
> <bagasdotme@gmail.com>; regressions@lists.linux.dev; perex@perex.cz;
> tiwai@suse.com; alsa-devel@alsa-project.org
> Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP
> 15z-fc000 on warm boot
> 
> 
> External mail.
> 
> 
> 
> On Tue, 04 Jul 2023 10:38:43 +0200,
> Kailang wrote:
> >
> >
> > Below was the relation patches.
> > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit
> > /?id=5aec98913095ed3b4424ed6c5fdeb6964e9734da
> > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit
> > /?id=f30741cded62f87bb4b1cc58bc627f076abcaba8
> >
> > It shows ALC236 codec not need to run pull low 3k setting.
> >
> > I trace windows code, find it add delay for read MIC jack detected at booting
> time.
> 
> I expected something like that ;)
> If you have a test patch, let us know.
> 
> 
> thanks,
> 
> Takashi
> 
> >
> >
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai@suse.de>
> > > Sent: Sunday, June 25, 2023 5:43 PM
> > > To: Joseph C. Sible <josephcsible@gmail.com>
> > > Cc: Kailang <kailang@realtek.com>; Bagas Sanjaya
> > > <bagasdotme@gmail.com>; regressions@lists.linux.dev; perex@perex.cz;
> > > tiwai@suse.com; alsa-devel@alsa-project.org
> > > Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP
> > > 15z-fc000 on warm boot
> > >
> > >
> > > External mail.
> > >
> > >
> > >
> > > On Sat, 24 Jun 2023 03:36:11 +0200,
> > > Joseph C. Sible wrote:
> > > >
> > > > On Sun, Jun 11, 2023 at 3:36 AM Takashi Iwai <tiwai@suse.de> wrote:
> > > > >
> > > > > Thanks for checking.  So the additional delay didn't help at
> > > > > all, i.e. it's no timing issue.  We need to figure out which
> > > > > verb actually breaks things.  Oh well.
> > > >
> > > > Was there something else specific you wanted me to try for this?
> > > > If not, what do you think the next steps to get this fixed are? Do
> > > > you think it might be good to just cook the partial revert I
> > > > posted a while back after all?
> > >
> > > It's rather a call to Kailang, after all.
> > > I'm fine with any way as long as it avoids further regressions.
> > >
> > >
> > > Takashi
> > >
> > > ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0000-HP-reboot-issue.patch --]
[-- Type: application/octet-stream, Size: 2077 bytes --]

From c8eb2230e1a9e197b22de69318eb1678da6e7b04 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Thu, 13 Jul 2023 15:57:13 +0800
Subject: [PATCH] ALSA: hda/realtek - remove 3k pull low procedure

This was the ALC283 depop procedure.
Maybe this procedure wasn't suitable with new codec.
So, let us remove it. But HP 15z-fc000 must do 3k pull low. If it reboot with plugged headset,
it will have errors show don't find codec error messages. Run 3k pull low will solve issues.
So, let AMD chipset will run this for workarround.

Signed-off-by: Kailang Yang <kailang@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e2f8b608de82..afb4d82475b4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -122,6 +122,7 @@ struct alc_spec {
 	unsigned int ultra_low_power:1;
 	unsigned int has_hs_key:1;
 	unsigned int no_internal_mic_pin:1;
+	unsigned int en_3kpull_low:1;
 
 	/* for PLL fix */
 	hda_nid_t pll_nid;
@@ -3622,6 +3623,7 @@ static void alc256_shutup(struct hda_codec *codec)
 	if (!hp_pin)
 		hp_pin = 0x21;
 
+	alc_update_coefex_idx(codec, 0x57, 0x04, 0x0007, 0x1); /* Low power */
 	hp_pin_sense = snd_hda_jack_detect(codec, hp_pin);
 
 	if (hp_pin_sense)
@@ -3638,8 +3640,7 @@ static void alc256_shutup(struct hda_codec *codec)
 	/* If disable 3k pulldown control for alc257, the Mic detection will not work correctly
 	 * when booting with headset plugged. So skip setting it for the codec alc257
 	 */
-	if (codec->core.vendor_id != 0x10ec0236 &&
-	    codec->core.vendor_id != 0x10ec0257)
+	if (spec->en_3kpull_low)
 		alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
 
 	if (!spec->no_shutup_pins)
@@ -10682,6 +10683,8 @@ static int patch_alc269(struct hda_codec *codec)
 		spec->shutup = alc256_shutup;
 		spec->init_hook = alc256_init;
 		spec->gen.mixer_nid = 0; /* ALC256 does not have any loopback mixer path */
+		if (codec->bus->pci->vendor == PCI_VENDOR_ID_AMD)
+			spec->en_3kpull_low = true;
 		break;
 	case 0x10ec0257:
 		spec->codec_variant = ALC269_TYPE_ALC257;